Character Notes

Character Notes

182k Downloads

Addon Taint affecting "Copy Character Name"

MattZeeX opened this issue ยท 1 comments

commented

For reference, CharacterNotes-10.0.5 for WOTLK

Hi I just got CharacterNotes recently and I also recently noticed that the "Copy Character Name" button was no longer working (and gave the error listed below) as well as the "Promote to Main Tank" and "Promote to Main Assist" buttons being missing in the raid group panel.

4x [ADDON_ACTION_FORBIDDEN] AddOn 'ElvUI_Libraries' tried to call the protected function 'CopyToClipboard()'.
[string "@!BugGrabber\BugGrabber.lua"]:480: in function <!BugGrabber\BugGrabber.lua:480>
[string "=[C]"]: in function `CopyToClipboard'
[string "@FrameXML\UnitPopupSharedButtonMixins.lua"]:1013: in function `OnClick'
[string "@FrameXML\UnitPopupShared.lua"]:148: in function `func'
[string "@FrameXML\UIDropDownMenu.lua"]:944: in function `UIDropDownMenuButton_OnClick'
[string "*:OnClick"]:1: in function <[string "*:OnClick"]:1>

I went through and disabled my addons one by one before I figured out that the issue only persisted while CharacterNotes was enabled. I saw this issue already mentioned this as a problem, and it seemed like you ultimately conceded that nothing could really be done to fix it. You did say

I added an option to turn off the updating of the menus. It is "Add Menu Items". It will remove the "Edit Note" option but should allow Copy Character Name to work.

But I cannot seem to find this button in my addon panel (screenshot below), I suppose you did change that over a year ago so maybe it's been changed since then? As you can see I've turned off "Unit Menus-Edit Note", but I still get the same error even after reloading.

image

I really hope you can find another workaround because I would really like to use your addon, but being unable to set people as Main Tank in raid and being unable to copy people's name out of chat to search WarcraftLogs is too obstructive for me. Ideally I'd also like for the "Copy Character Name" button to function alongside the "Edit Note" button, but I suppose I can add notes through the other options available so long as I can still copy Character names.

commented

I tried to re-create the error but I couldn't.

With ElvUI and Character Notes enabled, I tested Edit Note and Copy to Clipboard after logging in on Wrath Classic. Both worked.

I created a raid group and repeated the tests including trying some of the Promote options. It still worked. I know combat affects it so I got into combat and after it finished I tried again and it still worked. I did not try in combat because some quite a few UI modifications will cause taint if you access them during combat.

Did you try disabling all addons but Character Notes to see if it occurs? It is possible there is some interaction with another addon or library. Either that or I am not testing the correct situation.

I looked over the code again and I do believe the "Unit Menus-Edit Note" option should disable the menu option. If set, when the addon loads it should not touch the unit menus. After you disable it, you will need to reload or even log out and back in for it to change.

I will try some more testing to see if I can reproduce it.