CharacterStatsClassic (Character Stats Classic)

CharacterStatsClassic (Character Stats Classic)

8M Downloads

Weaponskill calculation doesnt work on german locales

Masgalor opened this issue ยท 2 comments

commented

While working on a fix for #22 I stumbled over a general problem in local function CSC_GetPlayerMissChances(unit, playerHit).

On german locales the weapon type is not identical with the weapon skill.
E.g. while wearing a 1H sword the weapon type is "Schwert" but the weapon skill is "Schwerter". The weapon type is the singular while the weapon skill is the plural.

I tried to change the way these strings are compared, and used string.find what worked with the given example. But I dont know if this is a safe way in general.

commented

I got this by myself, maybe it was a little late yesterday.

The German translation in Localization_de.lua is the problem. The translated texts are weapon types not weapon skills.

Will have a closer look this evening.

commented

PR is up.
#27