Final fix for blockvalue detection
Masgalor opened this issue ยท 2 comments
Hey @getov, after testing your latest update I have to tell you that the blockvalue is still not correct.
However, its easy to fix, so easy that I will describe it here instead of opening a PR.
-
If a might item is detected the counter is increased at each line of the tooltip a
break;
after line 772 would prevent this. -
The bonus is only added if there are exactly 3 pieces of might present maybe a
>=
would do better in line 801.
Im glad you finally got this working, thanks.
Thanks for the catch, yeah, some silly mistakes.
However I am not sure if the WoW's version of Lua, which is 5.1 supports "break" statements.
Edit: It doesn't support "continue" but "break" should work. However I can move this check out of the inner for loop