CharacterStatsClassic (Character Stats Classic)

CharacterStatsClassic (Character Stats Classic)

8M Downloads

priest crit chance and other minor bugs

ownlyme opened this issue ยท 7 comments

commented

according to warcraftlogs, this formula should better describe my critchance:
https://wowwiki.fandom.com/wiki/Spell_critical_strike
1.24 + Int/59.2 + BonusCrit

it doesn't count the 2% holy crit chance of benediction

it doesn't count the +4 mp5 from the zg head and legs enchant (+heal of it is getting picked up correctly)

commented
  1. I don't see an explanation of this formula for level 60 in the link ?
  2. It should be adding it already. Use https://classic.wowhead.com/gear-planner to put in your gear and send me both an in-game screenshot and link to your gear setup. I can't test this because I don't have a priest, but maybe I can figure something out from the screenshots
  3. I will add them in the next release
commented

i calculated my average crit chance with flash heal over the last 2 months and you were right
seems like you don't need a formula and wow's api shows the correct base crit chance.. sorry

i don't know what you need my gear planner for but here you go:
https://classic.wowhead.com/gear-planner/priest/human/AjwAAUIZAk2tA0IcBUIbBkIdB0IaCEvtCUIeClPWC1R0DELWDUtYDkglD0vmEEiwEkvr

screenshot:
Screenshot_1

as you can see, my holy crit is only 5% higher than my other crits, but i have 5% from talents and 2% from benediction.

are you sure your addon is picking up any spellcrit from items?

commented

I started asking people to upload their gear + screenshots because I've had FALSE bug reports many times. I don't want to waste my time only to find out there was no bug.

In your case it's really strange because I cannot find out what's wrong. I have an explicit check for Benediction and it seems to be executing it.

Yes, I am sure my addon is picking spell crit from items. There are some exceptions like Benediction which need additional handling.

commented

i'm really sorry, just updated to 3.6.2 and benediction works

commented

strange, nowhere in your files i was able to find the words "benediction" or "18608" ...
i have version 3.5.4

commented

The newest version is 3.6.3. Maybe that's why

commented

The ZG enchant should work now in 3.6.3