Observation

Since the last commit, spiritual healing is added to the total +spell healing in the character sheet calculation for priests

Expectation

Spiritual healing should have no influence on +spell healing

Explanation

Spiritual healing only increases base heal of healing spells. All +heal bonus from equip is ignored and irrelevant for this talent. This can be easily tested by using any healing spell (renew works best) and calculating the added +heal to the base spell values. The current 1.1 modifier to spell healing due to spiritual healing in commit eb60fe0 is wrong.

Example

Spiritual healing is skilled 5/5 and no improved renew

Renew Rank 3 should heal 195 after all talents (https://classic.wowhead.com/spell=6075/renew base spell only heals 175)

Each renew tick of rank 3 ticks for 244, so 1220 in total

This is the +heal value shown with the most recent commit.

If we subtract the base heal of 195 from the total renew (100% coefficient), we get 1025 +heal. This is the original, correct value. The new calculation since commit eb60fe0 multiplies this value by 1.1 and arrives at a wrong value of 1129.7 (which is also wrong due to rounding errors, but this is another floating point problem that classic has everywhere).

Character planner link with equip (without spirit buff, which would add ~10 +heal for a total of 1026) https://classic.wowhead.com/gear-planner/priest/undead/AjwQUAIxEwUAHyBRUQMDAAVf8IFCGV5nAlQDg02BX2SFQhs2dQZNgodLuV5niEvtNkKJQh5c-opCGGH3C0rEDFLaDUtYDkvDD0hOkFOiWN4RS3ASVSk

Thanks for the feedback, I got it wrong and I will revert this in the next version!