Add more crowdControls spells
millanzarreta opened this issue ยท 3 comments
Is your feature request related to a problem?
No.
Describe the solution or feature you'd like:
I see that in Data.lua exist a variable namespace.crowdControls that have a list of crowd controls spell debuffs, with the purpose of stop the casting bar if one of these crow crontrols affect a unit.
I have expanded this list by adding a good number of crowd control spells, especially NPC spells.
I know that I have to be careful, because when SPELL_AURA_APPLIED of COMBAT_LOG_EVENT_UNFILTERED is triggered, the name of the spell debuff will be compared and not the spellId, so I have been verifying that these spells debuffs do not cause conflict with other ones that have the same spell name but do not cause effects of loss of control and I have been removing them. I think I have done well, but maybe I was wrong, I hope not, an additional review would not hurt. This is the final list in Data.lua:
...
-- List of crowd controls.
-- We want to stop the castbar when these auras are detected
-- as SPELL_CAST_FAILED is not triggered when an unit gets CC'ed.
namespace.crowdControls = {
[GetSpellInfo(5211)] = 1, -- Bash
[GetSpellInfo(24394)] = 1, -- Intimidation
[GetSpellInfo(853)] = 1, -- Hammer of Justice
[GetSpellInfo(22703)] = 1, -- Inferno Effect (Summon Infernal)
[GetSpellInfo(408)] = 1, -- Kidney Shot
[GetSpellInfo(12809)] = 1, -- Concussion Blow
[GetSpellInfo(20253)] = 1, -- Intercept Stun
[GetSpellInfo(20549)] = 1, -- War Stomp
[GetSpellInfo(2637)] = 1, -- Hibernate
[GetSpellInfo(3355)] = 1, -- Freezing Trap
[GetSpellInfo(19386)] = 1, -- Wyvern Sting
[GetSpellInfo(118)] = 1, -- Polymorph
[GetSpellInfo(28271)] = 1, -- Polymorph: Turtle
[GetSpellInfo(28272)] = 1, -- Polymorph: Pig
[GetSpellInfo(20066)] = 1, -- Repentance
[GetSpellInfo(1776)] = 1, -- Gouge
[GetSpellInfo(6770)] = 1, -- Sap
[GetSpellInfo(1513)] = 1, -- Scare Beast
[GetSpellInfo(8122)] = 1, -- Psychic Scream
[GetSpellInfo(2094)] = 1, -- Blind
[GetSpellInfo(5782)] = 1, -- Fear
[GetSpellInfo(5484)] = 1, -- Howl of Terror
[GetSpellInfo(6358)] = 1, -- Seduction
[GetSpellInfo(5246)] = 1, -- Intimidating Shout
[GetSpellInfo(6789)] = 1, -- Death Coil
[GetSpellInfo(9005)] = 1, -- Pounce
[GetSpellInfo(1833)] = 1, -- Cheap Shot
[GetSpellInfo(16922)] = 1, -- Improved Starfire
[GetSpellInfo(19410)] = 1, -- Improved Concussive Shot
[GetSpellInfo(12355)] = 1, -- Impact
[GetSpellInfo(20170)] = 1, -- Seal of Justice Stun
[GetSpellInfo(15269)] = 1, -- Blackout
[GetSpellInfo(18093)] = 1, -- Pyroclasm
[GetSpellInfo(12798)] = 1, -- Revenge Stun
[GetSpellInfo(5530)] = 1, -- Mace Stun
[GetSpellInfo(19503)] = 1, -- Scatter Shot
[GetSpellInfo(605)] = 1, -- Mind Control
[GetSpellInfo(7922)] = 1, -- Charge Stun
[GetSpellInfo(18469)] = 1, -- Counterspell - Silenced
[GetSpellInfo(15487)] = 1, -- Silence
[GetSpellInfo(18425)] = 1, -- Kick - Silenced
[GetSpellInfo(24259)] = 1, -- Spell Lock
[GetSpellInfo(18498)] = 1, -- Shield Bash - Silenced
[GetSpellInfo(2878)] = 1, -- Turn Undead
[GetSpellInfo(710)] = 1, -- Banish
-- ITEMS
[GetSpellInfo(13327)] = 1, -- Reckless Charge
[GetSpellInfo(1090)] = 1, -- Sleep
[GetSpellInfo(5134)] = 1, -- Flash Bomb Fear
[GetSpellInfo(19821)] = 1, -- Arcane Bomb Silence
[GetSpellInfo(4068)] = 1, -- Iron Grenade
[GetSpellInfo(19769)] = 1, -- Thorium Grenade
[GetSpellInfo(13808)] = 1, -- M73 Frag Grenade
[GetSpellInfo(4069)] = 1, -- Big Iron Bomb
[GetSpellInfo(12543)] = 1, -- Hi-Explosive Bomb
[GetSpellInfo(4064)] = 1, -- Rough Copper Bomb
[GetSpellInfo(12421)] = 1, -- Mithril Frag Bomb
[GetSpellInfo(19784)] = 1, -- Dark Iron Bomb
[GetSpellInfo(4067)] = 1, -- Big Bronze Bomb
[GetSpellInfo(4066)] = 1, -- Small Bronze Bomb
[GetSpellInfo(4065)] = 1, -- Large Copper Bomb
[GetSpellInfo(13237)] = 1, -- Goblin Mortar
[GetSpellInfo(835)] = 1, -- Tidal Charm
[GetSpellInfo(13181)] = 1, -- Gnomish Mind Control Cap
[GetSpellInfo(12562)] = 1, -- The Big One
[GetSpellInfo(15283)] = 1, -- Stunning Blow (Weapon Proc)
[GetSpellInfo(56)] = 1, -- Stun (Weapon Proc)
[GetSpellInfo(26108)] = 1, -- Glimpse of Madness
[GetSpellInfo(8345)] = 1, -- Control Machine (Gnomish Universal Remote trinket)
[GetSpellInfo(13235)] = 1, -- Forcefield Collapse (Gnomish Harm Prevention Belt)
[GetSpellInfo(15753)] = 1, -- Linken's Boomerang (trinket)
[GetSpellInfo(15535)] = 1, -- Enveloping Winds (Six Demon Bag trinket)
[GetSpellInfo(28406)] = 1, -- Polymorph Backfire
[GetSpellInfo(16600)] = 1, -- Might of Shahram (Blackblade of Shahram sword)
[GetSpellInfo(13907)] = 1, -- Smite Demon (Enchant Weapon - Demonslaying)
[GetSpellInfo(15822)] = 1, -- Dreamless Sleep Potion
[GetSpellInfo(16053)] = 1, -- Dominion of Soul (Orb of Draconic Energy)
[GetSpellInfo(21330)] = 1, -- Corrupted Fear (Deathmist Raiment set)
-- NPCS
[GetSpellInfo(3242)] = 1, -- Ravage
[GetSpellInfo(3271)] = 1, -- Fatigued
[GetSpellInfo(5708)] = 1, -- Swoop
[GetSpellInfo(11430)] = 1, -- Slam
[GetSpellInfo(17276)] = 1, -- Scald
[GetSpellInfo(18812)] = 1, -- Knockdown
[GetSpellInfo(3442)] = 1, -- Enslave
[GetSpellInfo(20683)] = 1, -- Highlord's Justice
[GetSpellInfo(17286)] = 1, -- Crusader's Hammer
[GetSpellInfo(3109)] = 1, -- Presence of Death
[GetSpellInfo(3143)] = 1, -- Glacial Roar
[GetSpellInfo(3263)] = 1, -- Touch of Ravenclaw
[GetSpellInfo(5106)] = 1, -- Crystal Flash
[GetSpellInfo(6266)] = 1, -- Kodo Stomp
[GetSpellInfo(6730)] = 1, -- Head Butt
[GetSpellInfo(6982)] = 1, -- Gust of Wind
[GetSpellInfo(7961)] = 1, -- Azrethoc's Stomp
[GetSpellInfo(8151)] = 1, -- Surprise Attack
[GetSpellInfo(3635)] = 1, -- Crystal Gaze
[GetSpellInfo(21188)] = 1, -- Stun Bomb Attack
[GetSpellInfo(16451)] = 1, -- Judge's Gavel
[GetSpellInfo(3589)] = 1, -- Deafening Screech
[GetSpellInfo(4320)] = 1, -- Trelane's Freezing Touch
[GetSpellInfo(6942)] = 1, -- Overwhelming Stench
[GetSpellInfo(8715)] = 1, -- Terrifying Howl
[GetSpellInfo(8817)] = 1, -- Smoke Bomb
[GetSpellInfo(25772)] = 1, -- Mental Domination
[GetSpellInfo(15859)] = 1, -- Dominate Mind
[GetSpellInfo(24753)] = 1, -- Trick
[GetSpellInfo(19408)] = 1, -- Panic
[GetSpellInfo(23364)] = 1, -- Tail Lash
[GetSpellInfo(19364)] = 1, -- Ground Stomp
[GetSpellInfo(19369)] = 1, -- Ancient Despair
[GetSpellInfo(19641)] = 1, -- Pyroclast Barrage
[GetSpellInfo(19393)] = 1, -- Soul Burn
[GetSpellInfo(20277)] = 1, -- Fist of Ragnaros
[GetSpellInfo(19780)] = 1, -- Hand of Ragnaros
[GetSpellInfo(18431)] = 1, -- Bellowing Roar
[GetSpellInfo(22289)] = 1, -- Brood Power: Green
[GetSpellInfo(22291)] = 1, -- Brood Power: Bronze
[GetSpellInfo(22561)] = 1, -- Brood Power: Green
[GetSpellInfo(19872)] = 1, -- Calm Dragonkin
[GetSpellInfo(22274)] = 1, -- Greater Polymorph
[GetSpellInfo(23310)] = 1, -- Time Lapse
[GetSpellInfo(23174)] = 1, -- Chromatic Mutation
[GetSpellInfo(23171)] = 1, -- Time Stop (Brood Affliction: Bronze)
[GetSpellInfo(22667)] = 1, -- Shadow Command
[GetSpellInfo(23603)] = 1, -- Wild Polymorph
[GetSpellInfo(23182)] = 1, -- Mark of Frost
[GetSpellInfo(25043)] = 1, -- Aura of Nature
[GetSpellInfo(24811)] = 1, -- Draw Spirit
[GetSpellInfo(25806)] = 1, -- Creature of Nightmare
[GetSpellInfo(6253)] = 1, -- Backhand
[GetSpellInfo(6466)] = 1, -- Axe Toss
[GetSpellInfo(8242)] = 1, -- Shield Slam
[GetSpellInfo(8285)] = 1, -- Rampage
[GetSpellInfo(6524)] = 1, -- Ground Tremor
[GetSpellInfo(6607)] = 1, -- Lash
[GetSpellInfo(7399)] = 1, -- Terrify
[GetSpellInfo(8150)] = 1, -- Thundercrack
[GetSpellInfo(11020)] = 1, -- Petrify
[GetSpellInfo(11641)] = 1, -- Hex
[GetSpellInfo(17307)] = 1, -- Knockout
[GetSpellInfo(16075)] = 1, -- Throw Axe
[GetSpellInfo(16104)] = 1, -- Crystallize
[GetSpellInfo(11836)] = 1, -- Freeze Solid
[GetSpellInfo(29419)] = 1, -- Flash Bomb
[GetSpellInfo(6304)] = 1, -- Rhahk'Zor Slam
[GetSpellInfo(6435)] = 1, -- Smite Slam
[GetSpellInfo(6432)] = 1, -- Smite Stomp
[GetSpellInfo(228)] = 1, -- Polymorph: Chicken
[GetSpellInfo(8040)] = 1, -- Druid's Slumber
[GetSpellInfo(7967)] = 1, -- Naralex's Nightmare
[GetSpellInfo(7139)] = 1, -- Fel Stomp
[GetSpellInfo(7621)] = 1, -- Arugal's Curse
[GetSpellInfo(7803)] = 1, -- Thundershock
[GetSpellInfo(7074)] = 1, -- Screams of the Past
[GetSpellInfo(8281)] = 1, -- Sonic Burst
[GetSpellInfo(8359)] = 1, -- Left for Dead
[GetSpellInfo(9256)] = 1, -- Deep Sleep
[GetSpellInfo(12946)] = 1, -- Putrid Stench
[GetSpellInfo(3636)] = 1, -- Crystalline Slumber
[GetSpellInfo(10093)] = 1, -- Harsh Winds
[GetSpellInfo(21808)] = 1, -- Summon Shardlings
[GetSpellInfo(21869)] = 1, -- Repulsive Gaze
[GetSpellInfo(12888)] = 1, -- Cause Insanity
[GetSpellInfo(12480)] = 1, -- Hex of Jammal'an
[GetSpellInfo(12890)] = 1, -- Deep Slumber
[GetSpellInfo(25774)] = 1, -- Mind Shatter
[GetSpellInfo(15471)] = 1, -- Enveloping Web
[GetSpellInfo(3609)] = 1, -- Paralyzing Poison
[GetSpellInfo(17492)] = 1, -- Hand of Thaurissan
[GetSpellInfo(14870)] = 1, -- Drunken Stupor
[GetSpellInfo(13902)] = 1, -- Fist of Ragnaros
[GetSpellInfo(6945)] = 1, -- Chest Pains
[GetSpellInfo(3551)] = 1, -- Skull Crack
[GetSpellInfo(15618)] = 1, -- Snap Kick
[GetSpellInfo(16508)] = 1, -- Intimidating Roar
[GetSpellInfo(16497)] = 1, -- Stun Bomb
[GetSpellInfo(17405)] = 1, -- Domination
[GetSpellInfo(16798)] = 1, -- Enchanting Lullaby
[GetSpellInfo(12734)] = 1, -- Ground Smash
[GetSpellInfo(17293)] = 1, -- Burning Winds
[GetSpellInfo(16869)] = 1, -- Ice Tomb
[GetSpellInfo(22856)] = 1, -- Ice Lock
[GetSpellInfo(16838)] = 1, -- Banshee Shriek
}
...
As a summary, 2 player spells, 10 items spells and 106 NPC spells have been added.
Awesome, names seems fine.
Feel free to send in a pull request and I'll merge it. If not I can add the data myself later.