cleangroupassigns

cleangroupassigns

10.2k Downloads

Small improvements (v1.8)

Road-block opened this issue ยท 1 comments

commented

I thought this addon was in hiatus why I didn't bother opening tickets earlier ๐Ÿ˜Š

Functions that rely on valid results from GetGuildRosterInfo and GetRaidRosterInfo have been occasionally erroring in the past shortly after PLAYER_ENTERING_WORLD (either initial login or crossing loading screens) as both of those methods have a chance to not return valid results.

I had fixed that in my local copy by checking for valid returns in lines 93, 103 and 467 thus:

if tmpName and tmpName ~= _G.UNKNOWNOBJECT then

and

if name and name ~= _G.UNKNOWNOBJECT then

respectively.

A small cosmetic change I've also made to my local copy was around line 1025 replacing

self.f:SetTitle("<clean> group assignments")

with this small block.

local guild_name = IsInGuild() and (GetGuildInfo("player"))
self.f:SetTitle(guild_name and "<"..guild_name.."> group assignments" or "<clean> group assignments")

Finally an actual feature request.

Reuse the dropdown in the Player Bank that currently only has a Delete menu item to save a raid mark on that player (๐Ÿ’€ , โŒ etc) and have rearrange, apply those marks.

Use case: We use marks to arrange subgroups for a bunch of encounters (and is something that will likely continue in the future) eg. C'Thun pie slices, 4HM dps groups and so on.

commented

hey. always nice to hear from you :) yeah the addon was technically in hiatus but in #7 tobbi007 was kind enough to write a contribution so I felt like helping him out.

PLAYER_ENTERING_WORLD -> good catch. I think those functions become available only after receiving the first GUILD_ROSTER_UPDATE or PLAYER_GUILD_UPDATE which signal to the addon that the data has been populated for those APIs in the client. it's a minor issue but probably worthwhile to patch in the next update (if there is one).

cosmetic change -> but my guild needs a shoutout :p

raid markers in right click -> good suggestion, that's definitely doable. as always, feel free to make a PR or i'll get to it the next time i feel like resurrecting the project.