ColorPickerPlus

ColorPickerPlus

326k Downloads

Error with 10.2.5

MetalHeadSeven opened this issue ยท 1 comments

commented

1x ColorPickerPlus/ColorPickerPlus.lua:325: attempt to index global 'ColorPickerWheel' (a nil value)
[string "@ColorPickerPlus/ColorPickerPlus.lua"]:325: in function CleanUpColorPickerFrame' [string "@ColorPickerPlus/ColorPickerPlus.lua"]:1109: in function Initialize_UI'
[string "@ColorPickerPlus/ColorPickerPlus.lua"]:1137: in function `?'
[string "@ColorPickerPlus/ColorPickerPlus.lua"]:137: in function <ColorPickerPlus/ColorPickerPlus.lua:137>

Locals:
self =

{
CreateClassPalette = defined @ColorPickerPlus/ColorPickerPlus.lua:613
CreateCheckerboardBG = defined @ColorPickerPlus/ColorPickerPlus.lua:374
CreateOpacityBar = defined @ColorPickerPlus/ColorPickerPlus.lua:920
ShowHideAlpha = defined @ColorPickerPlus/ColorPickerPlus.lua:291
CleanUpColorPickerFrame = defined @ColorPickerPlus/ColorPickerPlus.lua:322
Initialize_UI = defined @ColorPickerPlus/ColorPickerPlus.lua:1108
UpdateOldColor = defined @ColorPickerPlus/ColorPickerPlus.lua:222
CreateHelpFrame = defined @ColorPickerPlus/ColorPickerPlus.lua:1051
UpdateOpacityBarThumb = defined @ColorPickerPlus/ColorPickerPlus.lua:260
CreateTextBoxes = defined @ColorPickerPlus/ColorPickerPlus.lua:950
UpdateHexText = defined @ColorPickerPlus/ColorPickerPlus.lua:1264
CreateColorGradient = defined @ColorPickerPlus/ColorPickerPlus.lua:731
Hooked_OnShow = defined @ColorPickerPlus/ColorPickerPlus.lua:308
UpdateAlphaText = defined @ColorPickerPlus/ColorPickerPlus.lua:1288
UpdateHSVfromColorPickerRGB = defined @ColorPickerPlus/ColorPickerPlus.lua:194
PLAYER_LOGIN = defined @ColorPickerPlus/ColorPickerPlus.lua:1135
UpdateRGBTexts = defined @ColorPickerPlus/ColorPickerPlus.lua:1252
UpdateChosenColor = defined @ColorPickerPlus/ColorPickerPlus.lua:216
UpdateColorTexts = defined @ColorPickerPlus/ColorPickerPlus.lua:1234
CreatePalette = defined @ColorPickerPlus/ColorPickerPlus.lua:555
UpdateHueBarThumb = defined @ColorPickerPlus/ColorPickerPlus.lua:267
CreateColorSwatches = defined @ColorPickerPlus/ColorPickerPlus.lua:415
SetRGBfromHSV = defined @ColorPickerPlus/ColorPickerPlus.lua:197
CreatePaletteSwitcher = defined @ColorPickerPlus/ColorPickerPlus.lua:1093
UpdateHSVTexts = defined @ColorPickerPlus/ColorPickerPlus.lua:1240
GetAlpha = defined @ColorPickerPlus/ColorPickerPlus.lua:201
CreatePaletteFrame = defined @ColorPickerPlus/ColorPickerPlus.lua:1068
ADDON_LOADED = defined @ColorPickerPlus/ColorPickerPlus.lua:226
UpdateColorGraphics = defined @ColorPickerPlus/ColorPickerPlus.lua:274
CreateCopyPasteArea = defined @ColorPickerPlus/ColorPickerPlus.lua:446
UpdateGradientColorOverlay = defined @ColorPickerPlus/ColorPickerPlus.lua:211
UpdateGradientThumb = defined @ColorPickerPlus/ColorPickerPlus.lua:245
HexTextChanged = defined @ColorPickerPlus/ColorPickerPlus.lua:1176
RGBTextChanged = defined @ColorPickerPlus/ColorPickerPlus.lua:1141
CreateHueBar = defined @ColorPickerPlus/ColorPickerPlus.lua:827
AlphaTextChanged = defined @ColorPickerPlus/ColorPickerPlus.lua:1274
HSVTextChanged = defined @ColorPickerPlus/ColorPickerPlus.lua:1200
}
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = "attempt to index global 'ColorPickerWheel' (a nil value)"
isClassic = false
isWrath = false
dialogHeight = 380

commented

Hey, i commented my fix on CurseForge, this is more meant for the author if he is busy and wants one solution to the errors.

Hello, on todays patch they did some changes to various stuff, i overwrote my export code so i cant see the previous version for the ColorPickerFrame but managed to get it to work.

They renamed OpacitySliderFrame to OpacityFrameSlider, replacing all instances of this worked.

Seems like they changed the organization of the frame, earlier it was ColorPickerFrame:SetColorRGB but it is now ColorPickerFrame.Content.ColorPicker:SetColorRGB, replacing all instances of this worked.

In your function CleanUpColorPickerFrame you are hiding several frames, since their reorganization the names are changed so i simply commented out all of those except for OpacityFrameSlider, instead added

local ColorPickerFrame = ColorPickerFrame
ColorPickerFrame:HookScript("OnShow",
 function ()
	ColorPickerFrame.Content.ColorPicker.Alpha:Hide();
	ColorPickerFrame.Content.ColorPicker.AlphaThumb:Hide();
	ColorPickerFrame.Content.AlphaBackground:Hide();
	ColorPickerFrame.Content.ColorPicker:Hide()
	ColorPickerFrame.Content.HexBox:Hide()
	ColorPickerFrame.Content.ColorSwatchOriginal:Hide()
	ColorPickerFrame.Content.ColorSwatchCurrent:Hide()
 end
)

It works, dont know if this is a bad way to solve it though, i couldnt do it like you did since blizz now seems to call Show each time the main window shows.

After calling SetColorRGB you seem to call ColorPickerFrame.func, since i dont have the previous version i dont know what function this is, i found ColorPickerFrame.swatchFunc which i guess is the renamed function. However in blizz documentation they comment that "SetColorRGB must be called last since it triggers swatchFunc", so simply commenting out all instances of ColorPickerFrame.func in your addon fixed that issue, i guess in the previous version SetColorRGB didnt call func.

And with those changes the addon seems to be working again, cheers!