Command Palette

Command Palette

2.7k Downloads

Doesn't pick up at least one toy that once was picked up

raptormama opened this issue ยท 6 comments

commented

Addon currently isn't detecting the Minute Glass toy (ID 208058).

This toy was picked up when I installed Command Palette two or three versions ago.

commented

Try 1.2.2 and see if this issue is resolved. It now waits for item data for toys and heirlooms. It's quite technical how it works so I hope it does not get stuck or cause other issues.

commented

It does seem to work now -- screenshot attached. I like that it does show an animation to indicate that it's caching the data it needs.

command-palette-minute

commented

Thanks! Let me know if any other issues arise.

commented

On a fresh load or /reload, before Command Palette is opened for the first time, what do these commands output?

/dump C_ToyBox.GetNumToys()
/dump C_ToyBox.GetNumFilteredToys()
/dump PlayerHasToy(208058)
/dump C_ToyBox.GetToyInfo(208058)

And does the toy appear in the Command Palette after running these commands?

commented

I did this after loading in tonight. The timestamps are from ElvUI.

Running each command in order yielded:

[20:41] Dump: value=C_ToyBox.GetNumToys()
[20:41] [1]=922
[20:42] Dump: value=C_ToyBox.GetNumFilteredToys()
[20:42] [1]=831
[20:42] Dump: value=PlayerHasToy(208058)
[20:42] [1]=true
[20:42] Dump: value=C_ToyBox.GetToyInfo(208058)
[20:42] [1]=208058,
[20:42] [4]=false,
[20:42] [5]=false,
[20:42] [6]=3

And it does appear in the list after the commands are run. I do not know why it does not autopopulate.

It's also not picking up the Friendsurge Defenders toy, which I added after posting the bug, so some things aren't being detected for some reason.

commented

This shows that GetToyInfo is not returning information about the toy immediately. If you run that command a second time you will see information populate on the second call. I will have to figure out how I can ensure the item information loads before trying to access it.