CommunityDKP

CommunityDKP

194k Downloads

DKP Values Stored as singles

caspervk opened this issue · 3 comments

commented

It looks like DKP values are stored as singles in some places:
image

On the other hand, the value is correctly shown in other places:
image

I haven't looked through the code, but as with all currency, maybe the numbers should be stored as integers (in µDKP) or as Decimal?

commented

For information, this issue was migrated from the original Roeshambo repository. I haven't tested if this issue persists in your fork.

commented

The issue still exists, I haven't made changes to this issue.

commented

I'm not sure #6 fixes the underlying issue. The values are still stored as singles; are all values you could use representable? I better approach would probably be to store all DKP values as µDKP, and then only format it into decimals for the UI.