Completely broken in 10.0 retail. Update please!

Question

Completely broken in 10.0 retail. Update please!

Voxxel opened this issue 2 years ago · 22 comments

Voxxel commented 2 years ago

The addon is completely broken in 10.0 retail pre-patch. Would love an update.

1x CreateFrame(): Couldn't find inherited node "OribosScrollBarTemplate"
[string "=[C]"]: ?
[string "=[C]"]: in function `CreateFrame'
[string "@Interface/AddOns/CovenantMissionHelper/UI.lua"]:139: in function <Interface/AddOns/CovenantMissionHelper/UI.lua:137>
[string "@Interface/AddOns/CovenantMissionHelper/UI.lua"]:166: in function <Interface/AddOns/CovenantMissionHelper/UI.lua:156>
[string "@Interface/AddOns/CovenantMissionHelper/UI.lua"]:317: in function `createMissionHelperFrame'
[string "@Interface/AddOns/CovenantMissionHelper/CovenantMissionHelper.lua"]:31: in function <...dOns/CovenantMissionHelper/CovenantMissionHelper.lua:26>
[string "=[C]"]: in function `LoadAddOn'
[string "@Interface/FrameXML/UIParent.lua"]:530: in function `UIParentLoadAddOn'
[string "@Interface/FrameXML/UIParent.lua"]:727: in function `Garrison_LoadUI'
[string "@Interface/FrameXML/UIParent.lua"]:2058: in function <Interface/FrameXML/UIParent.lua:1350>

Locals:

7x .../AddOns/CovenantMissionHelper/MissionHelperFrame.lua:24: attempt to index field 'ScrollBar' (a nil value)
[string "@Interface/AddOns/CovenantMissionHelper/MissionHelperFrame.lua"]:24: in function `clearFrames'
[string "@Interface/AddOns/CovenantMissionHelper/CovenantMissionHelper.lua"]:39: in function <...dOns/CovenantMissionHelper/CovenantMissionHelper.lua:36>
[string "=[C]"]: ?
[string "=[C]"]: in function `UpdateAllyPower'
[string "@Interface/AddOns/Blizzard_GarrisonUI/Blizzard_CovenantMissionUI.lua"]:347: in function <...s/Blizzard_GarrisonUI/Blizzard_CovenantMissionUI.lua:298>
[string "=[C]"]: in function `ShowMission'
[string "@Interface/AddOns/Blizzard_GarrisonUI/Blizzard_GarrisonMissionUI.lua"]:210: in function `OnClickMission'
[string "@Interface/AddOns/Blizzard_GarrisonTemplates/Blizzard_CovenantMissionTemplates.lua"]:375: in function <...risonTemplates/Blizzard_CovenantMissionTemplates.lua:370>

Locals:

qops1981 · Answer 1 · 2022-10-28T18:30:30.000Z

+1 I would appreciate this as well. Thank you for your time.

sauljaffe · Answer 2 · 2022-10-28T19:21:50.000Z

+1 I really miss this.

Walkerbo · Answer 3 · 2022-10-31T04:07:42.000Z

+1 saves a heap of time and a lot of headaches

Voxxel · Answer 4 · 2022-10-31T08:43:13.000Z

+1 saves a heap of time and a lot of headaches

For time-saving purposes, "TLDR missions" addon cant be beaten as it fully automates the mission table minigame.
CovenantMissionHelper however is for speeding up only the slow and boring parts of the minigame while you can still play and enjoy it if you wish.

datgrl · Answer 5 · 2022-11-01T23:08:03.000Z

Here's what I see: https://imgur.com/a/3zSWYJP

sauljaffe · Answer 6 · 2022-11-02T03:08:45.000Z

I don’t even see that. The second panel is almost completely covered. I’m on a smaller screen though. Regardless, it doesn’t appear to be working at all. There’s another add-on called, IIRC, “TL;DR” that helps and does some of the work of covenant helper but I don’t like it as much, and it tends to cause my machine to run out of “application memory”. Although, I don’t think that’s a problem with the add-on, I think it’s a problem generally with this new version of WoW because a lot of things seem to cause that issue. I’m really hating this version of WoW...

…

On Nov 1, 2022, at 7:08 PM, datgrl ***@***.***> wrote: Here's what I see: https://imgur.com/a/3zSWYJP <https://imgur.com/a/3zSWYJP> — Reply to this email directly, view it on GitHub <#69 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AGIRZ3LB57BX7VNJW3AET2DWGGPF3ANCNFSM6AAAAAARRFHVKM>. You are receiving this because you commented.

-- Saul Jaffe ***@***.*** “Together, we must remove the physical barriers we have created and the social barriers that we have accepted. For ours will never be a truly prosperous nation until all within it prosper.” President George Bush upon signing the Americans with Disabilities Act July 26, 1990

Cappersz · Answer 7 · 2022-11-04T12:28:36.000Z

Please fix ASAP !

inot · Answer 8 · 2022-11-05T12:36:56.000Z

at UI.lua change 140 line to
local scrollBar = CreateFrame("Slider", nil, combatLogFrame, "ScrollBarBaseTemplate")

its not the solution, just workaround

inot · Answer 9 · 2022-11-05T13:30:02.000Z

Doesn’t quite work for me. Half the screen is still hidden. It’s useable… but barely since I can’t get at all the buttons.
…
On Nov 5, 2022, at 8:37 AM, inot @.> wrote: local scrollBar = CreateFrame("Slider", nil, combatLogFrame, "ScrollBarBaseTemplate")
-- Saul Jaffe @. “Together, we must remove the physical barriers we have created and the social barriers that we have accepted. For ours will never be a truly prosperous nation until all within it prosper.” President George Bush upon signing the Americans with Disabilities Act July 26, 1990

Did you /reload or full game restart. Coz this is work for me only after full restart.

sauljaffe · Answer 10 · 2022-11-05T13:27:56.000Z

Doesn’t quite work for me. Half the screen is still hidden. It’s useable… but barely since I can’t get at all the buttons.

…

On Nov 5, 2022, at 8:37 AM, inot ***@***.***> wrote: local scrollBar = CreateFrame("Slider", nil, combatLogFrame, "ScrollBarBaseTemplate")

-- Saul Jaffe ***@***.*** “Together, we must remove the physical barriers we have created and the social barriers that we have accepted. For ours will never be a truly prosperous nation until all within it prosper.” President George Bush upon signing the Americans with Disabilities Act July 26, 1990

sauljaffe · Answer 11 · 2022-11-05T13:35:12.000Z

Full restart. First time entering into the game today… and all I did was visit the covenant missions board.

…

On Nov 5, 2022, at 9:30 AM, inot ***@***.***> wrote: Doesn’t quite work for me. Half the screen is still hidden. It’s useable… but barely since I can’t get at all the buttons. … <x-msg://3/#> On Nov 5, 2022, at 8:37 AM, inot @.> wrote: local scrollBar = CreateFrame("Slider", nil, combatLogFrame, "ScrollBarBaseTemplate") -- Saul Jaffe @. “Together, we must remove the physical barriers we have created and the social barriers that we have accepted. For ours will never be a truly prosperous nation until all within it prosper.” President George Bush upon signing the Americans with Disabilities Act July 26, 1990 Did you /reload or full game restart. Coz this is work for me only after full restart. — Reply to this email directly, view it on GitHub <#69 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AGIRZ3NGBVVIHJATURM5M6LWGZOOJANCNFSM6AAAAAARRFHVKM>. You are receiving this because you commented.

-- Saul Jaffe ***@***.*** “Together, we must remove the physical barriers we have created and the social barriers that we have accepted. For ours will never be a truly prosperous nation until all within it prosper.” President George Bush upon signing the Americans with Disabilities Act July 26, 1990

catmaretoo · Answer 12 · 2022-11-11T19:02:17.000Z

I just get a big empty black screen since the new pre-patch in Nov.

inot · Answer 13 · 2022-11-11T19:43:23.000Z

For me everything ok with mine workaround.

catmaretoo · Answer 14 · 2022-11-11T21:30:53.000Z

Well, drat! It doesn't work on any of my characters. Just the big black screen. It does show a few of the things, like the XP, but doesn't figure the mission followers. Cathy Wright Hamilton2760 Willamette St., #119 Eugene, OR 97405 541-619-0645 On Friday, November 11, 2022 at 11:43:34 AM PST, inot ***@***.***> wrote: For me everything ok with mine workaround. — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you commented.Message ID: ***@***.***>

takenek · Answer 15 · 2022-11-12T08:08:24.000Z

Project death? Last update on Jul 27, 2021 ?

BloodDragon2580 · Answer 16 · 2022-11-12T08:41:40.000Z

Yes is death

takenek · Answer 17 · 2022-11-12T08:43:22.000Z

We will see i write on project Discord there is still 12 ppl maybe someone know anything....

takenek · Answer 18 · 2022-11-18T06:50:27.000Z

Noone answer on Discord i saw few times Kreolix online but he do not answer about the future this Addon.

takenek · Answer 19 · 2022-11-18T06:51:31.000Z

Someone put this information you can test it:

Fix for LUA-Errors
UI.xml, replace Line 146:

PanelTemplates_TabResize(self, 0, nil, 50, 100)
with
PanelTemplates_TabResize(self, 0, 125)

and Line 159:

with

Ui.lua, replace Line 139:
local scrollBar = CreateFrame("Slider", nil, combatLogFrame, "OribosScrollBarTemplate")
with
local scrollBar = CreateFrame("Slider", nil, combatLogFrame, "OribosScrollBar")

Source: https://www.curseforge.com/wow/addons/covenantmissionhelper

outlawzgosu · Answer 20 · 2022-11-25T07:39:18.000Z

Someone put this information you can test it:

Fix for LUA-Errors UI.xml, replace Line 146:

PanelTemplates_TabResize(self, 0, nil, 50, 100) with PanelTemplates_TabResize(self, 0, 125)

and Line 159: with

Ui.lua, replace Line 139: local scrollBar = CreateFrame("Slider", nil, combatLogFrame, "OribosScrollBarTemplate") with local scrollBar = CreateFrame("Slider", nil, combatLogFrame, "OribosScrollBar")

Source: https://www.curseforge.com/wow/addons/covenantmissionhelper

This works still. Only your copy/paste didn't copy this part:

and Line 159:

<ButtonText name="$parentText">

 with

<ButtonText name="$parentText" parentKey="Text">

sauljaffe · Answer 21 · 2022-11-25T13:50:51.000Z

It doesn’t fix the problem for me. I’m on a MacBook… and all of the new UI is just… screwed for me. Blizzard won’t respond to bug reports on it that I’ve filed. I can play… sort of… but a lot of stuff on the screen is covered by other stuff on the screen. CovenantMissionHelper is one of those things - the helper window is partially covered up by the Covenant Mission window. Clicking on one brings the other to the top so it kinda works but it’s damned inconvenient.

…

On Nov 25, 2022, at 2:39 AM, outlawzgosu ***@***.***> wrote: Someone put this information you can test it: Fix for LUA-Errors UI.xml, replace Line 146: PanelTemplates_TabResize(self, 0, nil, 50, 100) with PanelTemplates_TabResize(self, 0, 125) and Line 159: with Ui.lua, replace Line 139: local scrollBar = CreateFrame("Slider", nil, combatLogFrame, "OribosScrollBarTemplate") with local scrollBar = CreateFrame("Slider", nil, combatLogFrame, "OribosScrollBar") Source: https://www.curseforge.com/wow/addons/covenantmissionhelper <https://www.curseforge.com/wow/addons/covenantmissionhelper> This works still. Only your copy/paste didn't copy this part: and Line 159: <ButtonText name="$parentText"> with <ButtonText name="$parentText" parentKey="Text"> — Reply to this email directly, view it on GitHub <#69 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AGIRZ3NZIKBIXCNLJID65ALWKBULDANCNFSM6AAAAAARRFHVKM>. You are receiving this because you commented.

-- Saul Jaffe ***@***.*** “Together, we must remove the physical barriers we have created and the social barriers that we have accepted. For ours will never be a truly prosperous nation until all within it prosper.” President George Bush upon signing the Americans with Disabilities Act July 26, 1990

acidiko · Answer 22 · 2023-05-28T15:01:44.000Z

The solution of changing lines worked for me. 28/5/2023 at Dragonflight

Just open the two files, "ui.xlm" and "ui.lua" with notepad and replace the lines with provided text:

in "UI.xml":

replace Line 146:

PanelTemplates_TabResize(self, 0, nil, 50, 100) 
with 
PanelTemplates_TabResize(self, 0, 125)

and Line 159:

<ButtonText name="$parentText">
 with
<ButtonText name="$parentText" parentKey="Text">

in "UI.lua" replace Line 139:

local scrollBar = CreateFrame("Slider", nil, combatLogFrame, "OribosScrollBarTemplate") 
with 
local scrollBar = CreateFrame("Slider", nil, combatLogFrame, "OribosScrollBar")

Share to