CraftSim

CraftSim

2M Downloads

Lua error opening Fishing Journal

b-morgan opened this issue ยท 4 comments

commented

With 17.3.2 I got the following error when opening the Fishing Journal. It doesn't happen on every character nor did it happen the second time on this character. See issue #385 for a possible fix.

I'm not sure why Craftsim is even involved with the Fishing Journal (or the Herbalism Journal).

1x CraftSim/Classes/ProfessionData.lua:44: bad argument #1 to 'pairs' (table expected, got nil)
[string "=[C]"]: in function `pairs'
[string "@CraftSim/Classes/ProfessionData.lua"]:44: in function `new'
[string "@CraftSim/Libs/classic.lua"]:64: in function `ProfessionData'
[string "@CraftSim/Classes/RecipeData.lua"]:69: in function `new'
[string "@CraftSim/Libs/classic.lua"]:64: in function `RecipeData'
[string "@CraftSim/Init/Init.lua"]:532: in function `TriggerModulesByRecipeType'
[string "@CraftSim/Init/Init.lua"]:85: in function <CraftSim/Init/Init.lua:83>
[string "@CraftSim/Libs/GUTIL/GUTIL.lua"]:605: in function `checkCondition'
[string "@CraftSim/Libs/GUTIL/GUTIL.lua"]:611: in function `WaitFor'
[string "@CraftSim/Init/Init.lua"]:74: in function `TriggerModuleUpdate'
[string "@CraftSim/Init/Init.lua"]:126: in function <CraftSim/Init/Init.lua:106>
[string "=[C]"]: ?
...
[string "@Ace3/CallbackHandler-1.0-8/CallbackHandler-1.0.lua"]:19: in function <...Ons/Ace3/CallbackHandler-1.0/CallbackHandler-1.0.lua:15>
[string "@Ace3/CallbackHandler-1.0-8/CallbackHandler-1.0.lua"]:54: in function `Fire'
[string "@Ace3/AceEvent-3.0-4/AceEvent-3.0.lua"]:120: in function <Ace3/AceEvent-3.0/AceEvent-3.0.lua:119>
[string "=[C]"]: in function `UseAction'
[string "@Blizzard_FrameXML/Mainline/SecureTemplates.lua"]:342: in function `handler'
[string "@Blizzard_FrameXML/Mainline/SecureTemplates.lua"]:667: in function <...ddOns/Blizzard_FrameXML/Mainline/SecureTemplates.lua:649>
[string "@Blizzard_FrameXML/Mainline/SecureTemplates.lua"]:681: in function <...ddOns/Blizzard_FrameXML/Mainline/SecureTemplates.lua:674>
[string "@Blizzard_FrameXML/Mainline/SecureTemplates.lua"]:723: in function `SecureActionButton_OnClick'
[string "@Blizzard_ActionBar/Mainline/ActionButton.lua"]:1438: in function <Blizzard_ActionBar/Mainline/ActionButton.lua:1408>
[string "=[C]"]: ?

Locals:
(*temporary) = nil
(*temporary) = "table expected, got nil"
commented

A different error when opening the Fishing Journal:

1x CraftSim/Classes/RecipeData.lua:1103: attempt to compare string with number
[string "@CraftSim/Classes/RecipeData.lua"]:1103: in function `IsOldWorldRecipe'
[string "@CraftSim/Classes/RecipeData.lua"]:129: in function `new'
[string "@CraftSim/Libs/classic.lua"]:64: in function `RecipeData'
[string "@CraftSim/Init/Init.lua"]:572: in function `TriggerModulesByRecipeType'
[string "@CraftSim/Init/Init.lua"]:85: in function <CraftSim/Init/Init.lua:83>
[string "@CraftSim/Libs/GUTIL/GUTIL.lua"]:605: in function `checkCondition'
[string "@CraftSim/Libs/GUTIL/GUTIL.lua"]:611: in function `WaitFor'
[string "@CraftSim/Init/Init.lua"]:74: in function `TriggerModuleUpdate'
[string "@CraftSim/Init/Init.lua"]:126: in function <CraftSim/Init/Init.lua:106>
[string "=[C]"]: ?
[string "=[C]"]: in function `Init'
[string "@Blizzard_ProfessionsTemplates/Blizzard_ProfessionsRecipeSchematicForm.lua"]:192: in function <...emplates/Blizzard_ProfessionsRecipeSchematicForm.lua:186>
...
[string "@Ace3/CallbackHandler-1.0-8/CallbackHandler-1.0.lua"]:19: in function <...Ons/Ace3/CallbackHandler-1.0/CallbackHandler-1.0.lua:15>
[string "@Ace3/CallbackHandler-1.0-8/CallbackHandler-1.0.lua"]:54: in function `Fire'
[string "@Ace3/AceEvent-3.0-4/AceEvent-3.0.lua"]:120: in function <Ace3/AceEvent-3.0/AceEvent-3.0.lua:119>
[string "=[C]"]: in function `UseAction'
[string "@Blizzard_FrameXML/Mainline/SecureTemplates.lua"]:342: in function `handler'
[string "@Blizzard_FrameXML/Mainline/SecureTemplates.lua"]:667: in function <...ddOns/Blizzard_FrameXML/Mainline/SecureTemplates.lua:649>
[string "@Blizzard_FrameXML/Mainline/SecureTemplates.lua"]:681: in function <...ddOns/Blizzard_FrameXML/Mainline/SecureTemplates.lua:674>
[string "@Blizzard_FrameXML/Mainline/SecureTemplates.lua"]:723: in function `SecureActionButton_OnClick'
[string "@Blizzard_ActionBar/Mainline/ActionButton.lua"]:1438: in function <Blizzard_ActionBar/Mainline/ActionButton.lua:1408>
[string "=[C]"]: ?

Locals:
self = <table> {
 concentrating = false
 isBaseRecraftRecipe = false
 crafterData = <table> {
 }
 specializationDataCached = false
 recipeID = 176408
 categoryID = 402
 recipeInfoCached = false
 isQuestRecipe = false
 recipeInfo = <table> {
 }
 concentrationCost = 0
 isEnchantingRecipe = false
 subRecipeCostsEnabled = false
 professionGearCached = false
 isGear = false
 expansionID = "BASE"
 subRecipeDepth = 0
 optimizedSubRecipes = <table> {
 }
 parentRecipeInfo = <table> {
 }
 professionData = <table> {
 }
 operationInfoCached = false
 supportsSpecializations = false
}
(*temporary) = "BASE"
(*temporary) = 9
(*temporary) = "attempt to compare string with number"
CraftSim = <table> {
 COOLDOWNS = <table> {
 }
 STATISTICS = <table> {
 }
 OPTIONAL_REAGENT_DATA = <table> {
 }
 NEWS = <table> {
 }
 CraftRecipeData = <table> {
 }
 DEBUG = <table> {
 }
 PRICE_DETAILS = <table> {
 }
 ProfessionGear = <table> {
 }
 CRAFT_BUFFS = Frame {
 }
 NodeData = <table> {
 }
 PRICE_OVERRIDE = <table> {
 }
 ConcentrationData = <table> {
 }
 LOCAL_MX = <table> {
 }
 ENCHANT_RECIPE_DATA = <table> {
 }
 REAGENT_DATA = <table> {
 }
 COST_OPTIMIZATION = <table> {
 }
 EXPLANATIONS = <table> {
 }
 LibCompress = <table> {
 }
 TopGearResult = <table> {
 }
 ReagentData = <table> {
 }
 LOCAL_DE = <table> {
 }
 CONCENTRATION_TRACKER = <table> {
 }
 SUPPORTERS = <table> {
 }
 LibGraph = <table> {
 }
 OptionalReagentSlot = <table> {
 }
 Reagent = <table> {
 }
 PRICE_APIS = <table> {
 }
 LOCAL_FR = <table> {
 }
 SPECIALIZATION_DATA = <table> {
 }
 PRICE_SOURCE = <table> {
 }
 UTIL = <table> {
 }
 LOCAL_ES = <table> {
 }
 CraftSimObject = <table> {
 }
 PerkData = <table> {
 }
 ITEM_COUNT = Frame {
 }
 TOPGEAR = <table> {
 }
 PriceData = <table> {
 }
 OptionalReagent = <table> {
 }
 CONCENTRATION_CURVE_DATA = <table> {
 }
 LOCAL_IT = <table> {
 }
 CONTROL_PANEL = <table> {
 }
 CraftQueueItem = <table> {
 }
 ResultData = <table> {
 }
 CraftQueue = <table> {
 }
 RECIPE_SCAN = <table> {
 }
 AVERAGEPROFIT = <table> {
 }
 BagBuff = <table> {
 }
 Buff = <table> {
 }
 BuffData = <table> {
 }
 SIMULATION_MODE = <table> {
 }
 JSONBuilder = <table> {
 }
 OPTIONS = <table> {
 }
 CraftSessionData = <table> {
 }
 INIT = Frame {
 }
 CALC = <table> {
 }
 ProfessionGearSet = <table> {
 }
 SpecializationData = <table> {
 }
 ProfessionData = <table> {
 }
 LOCAL_RU = <table> {
 }
 CraftResultSavedReagent = <table> {
 }
 CraftResultItem = <table> {
 }
 CraftResult = <table> {
 }
 LOCAL_CN = <table> {
 }
 ReagentOptimizationResult = <table> {
 }
 DB = <table> {
 }
 Statweights = <table> {
 }
 ProfessionStat = <table> {
 }
 SalvageReagentSlot = <table> {
 }
 ProfessionStats = <table> {
 }
 ReagentListItem = <table> {
 }
 GUTIL = <table> {
 }
 CUSTOMER_HISTORY = Frame {
 }
 ReagentItem = <table> {
 }
 REAGENT_OPTIMIZATION = <table> {
 }
 COMM = <table> {
 }
 LOCAL_EN = <table> {
 }
 FRAME = <table> {
 }
 CRAFT_RESULTS = Frame {
 }
 RecipeData = <table> {
 }
 LOCAL_KO = <table> {
 }
 LOCAL_TW = <table> {
 }
 Object = <table> {
 }
 LOCAL_PT = <table> {
 }
 LibIcon = <table> {
 }
 LOCAL = <table> {
 }
 CooldownData = <table> {
 }
 PRICE_API = <table> {
 }
 SPECIALIZATION_INFO = <table> {
 }
 CONST = <table> {
 }
 CRAFTQ = Frame {
 }
 GGUI = <table> {
 }
 MEDIA = <table> {
 }
}
commented

its involved cause the ui is the same as the crafting professions, just the content is different

commented

Hello,
Can't reproduce.
No error pop when i open the fishing journal
I recently cleaned all cache, maybe it's actually solved with a fresh install ?

commented

also cannot reproduce