CraftSim

CraftSim

2M Downloads

LUA error on craft finish possibly after filter applied

hollo6 opened this issue ยท 8 comments

commented

Got this when crafting a Chilled Rune:

1x ...faceCraftSim/Modules/CraftResults/Frames.lua:170: attempt to compare nil with number
[string "@CraftSim/Modules/CraftResults/Frames.lua"]:170: in function compFunc' [string "@CraftSim/Util/Util.lua"]:335: in function Sort'
[string "@CraftSim/Modules/CraftResults/Frames.lua"]:169: in function UpdateItemList' [string "@CraftSim/Modules/CraftResults/CraftResults.lua"]:110: in function AddCraftData'
[string "@CraftSim/Modules/CraftResults/CraftResults.lua"]:165: in function AddResult' [string "@CraftSim/Modules/CraftResults/CraftResults.lua"]:221: in function callback'
[string "@CraftSim/Util/Util.lua"]:80: in function ContinueOnAllItemsLoaded' [string "@CraftSim/Modules/CraftResults/CraftResults.lua"]:220: in function processCraftResults'
[string "@CraftSim/Modules/CraftResults/CraftResults.lua"]:42: in function <...ddOns/CraftSim/Modules/CraftResults/CraftResults.lua:41>

Locals:
a =

{
qualityID = 2
quantity = 107
item =
{
}
quantityMulticraft = 0
}
b =
{
qualityID = 3
quantity = 24
item =
{
}
quantityMulticraft = 0
}
(*temporary) = 1
(*temporary) = nil
(*temporary) =
{
GetItemLocation = defined @FrameXML/ObjectAPI/Item.lua:104
IsDataEvictable = defined @FrameXML/ObjectAPI/Item.lua:306
LockItem = defined @FrameXML/ObjectAPI/Item.lua:175
IsItemDataCached = defined @FrameXML/ObjectAPI/Item.lua:295
GetInventoryTypeName = defined @FrameXML/ObjectAPI/Item.lua:289
GetItemQualityColor = defined @FrameXML/ObjectAPI/Item.lua:252
Matches = defined @FrameXML/ObjectAPI/Item.lua:66
itemLink = "|cffffffff|Hitem:198423::::::::70:252::::1:38:3:::::|h[Shimmering Pigment |A:Professions-ChatIcon-Quality-Tier3:17:18::1|a]|h|r"
GetItemQuality = defined @FrameXML/ObjectAPI/Item.lua:223
Clear = defined @FrameXML/ObjectAPI/Item.lua:131
GetItemIcon = defined @FrameXML/ObjectAPI/Item.lua:187
GetItemMaxStackSize = defined @FrameXML/ObjectAPI/Item.lua:262
ContinueWithCancelOnItemLoad = defined @FrameXML/ObjectAPI/Item.lua:334
IsItemLocked = defined @FrameXML/ObjectAPI/Item.lua:171
IsRecordDataCached = defined @FrameXML/ObjectAPI/Item.lua:344
IsItemEmpty = defined @FrameXML/ObjectAPI/Item.lua:138
SetItemID = defined @FrameXML/ObjectAPI/Item.lua:94
IsStackable = defined @FrameXML/ObjectAPI/Item.lua:273
SetItemLink = defined @FrameXML/ObjectAPI/Item.lua:89
GetInventoryType = defined @FrameXML/ObjectAPI/Item.lua:278
SetItemGUID = defined @FrameXML/ObjectAPI/Item.lua:99
GetItemID = defined @FrameXML/ObjectAPI/Item.lua:160
GetCurrentItemLevel = defined @FrameXML/ObjectAPI/Item.lua:241
GetItemQualityColorRGB = defined @FrameXML/ObjectAPI/Item.lua:257
UnlockItem = defined @FrameXML/ObjectAPI/Item.lua:181
GetItemGUID = defined @FrameXML/ObjectAPI/Item.lua:115
SetItemLocation = defined @FrameXML/ObjectAPI/Item.lua:84
GetItemName = defined @FrameXML/ObjectAPI/Item.lua:197
IsItemInPlayersControl = defined @FrameXML/ObjectAPI/Item.lua:150
GetItemLink = defined @FrameXML/ObjectAPI/Item.lua:208
ValidateForContinueOnItemLoad = defined @FrameXML/ObjectAPI/Item.lua:311
GetStaticBackingItem = defined @FrameXML/ObjectAPI/Item.lua:146
HasItemLocation = defined @FrameXML/ObjectAPI/Item.lua:127
ContinueWithCancelOnRecordLoad = defined @FrameXML/ObjectAPI/Item.lua:340
ContinueOnItemLoad = defined @FrameXML/ObjectAPI/Item.lua:328
GetStackCount = defined @FrameXML/ObjectAPI/Item.lua:234
}
(*temporary) = "attempt to compare nil with number"

commented

Could not reproduce this

  1. Logged on my scribe
  2. crafted a chilled rune
  3. all as expected
commented

I believe I got this for the first craft and not the ones after. Maybe it has to do with some residual or nonexistent historical data?

Edit: first craft as in, first after updating to this addon version, it was not a First Craft for that item.

commented

The same thing just happened when using Dragon Isles Crushing. I already had some Silken Gemdust in my bags, and this happened the first time using this Recipe today and not on any consecutive crafts.

1x ...faceCraftSim/Modules/CraftResults/Frames.lua:170: attempt to compare number with nil
[string "@CraftSim/Modules/CraftResults/Frames.lua"]:170: in function compFunc' [string "@CraftSim/Util/Util.lua"]:335: in function Sort'
[string "@CraftSim/Modules/CraftResults/Frames.lua"]:169: in function UpdateItemList' [string "@CraftSim/Modules/CraftResults/CraftResults.lua"]:110: in function AddCraftData'
[string "@CraftSim/Modules/CraftResults/CraftResults.lua"]:164: in function AddResult' [string "@CraftSim/Modules/CraftResults/CraftResults.lua"]:220: in function callback'
[string "@CraftSim/Util/Util.lua"]:80: in function ContinueOnAllItemsLoaded' [string "@CraftSim/Modules/CraftResults/CraftResults.lua"]:219: in function processCraftResults'
[string "@CraftSim/Modules/CraftResults/CraftResults.lua"]:42: in function <...ddOns/CraftSim/Modules/CraftResults/CraftResults.lua:41>

Locals:
a =

{
qualityID = 3
quantity = 2
item =
{
}
quantityMulticraft = 0
}
b =
{
qualityID = 5
quantity = 1
item =
{
}
quantityMulticraft = 0
}
(*temporary) = nil
(*temporary) = 4
(*temporary) =
{
GetItemLocation = defined @FrameXML/ObjectAPI/Item.lua:104
IsDataEvictable = defined @FrameXML/ObjectAPI/Item.lua:306
LockItem = defined @FrameXML/ObjectAPI/Item.lua:175
IsItemDataCached = defined @FrameXML/ObjectAPI/Item.lua:295
GetInventoryTypeName = defined @FrameXML/ObjectAPI/Item.lua:289
GetItemQualityColor = defined @FrameXML/ObjectAPI/Item.lua:252
Matches = defined @FrameXML/ObjectAPI/Item.lua:66
itemLink = "|cffa335ee|Hitem:192999::::::::70:252::13:6:8836:8840:8902:8780:8802:8792:6:28:2164:29:49:30:36:38:8:40:258:48:194569:::::|h[Signet of Titanic Insight |A:Professions-ChatIcon-Quality-Tier5:17:17::1|a]|h|r"
GetItemQuality = defined @FrameXML/ObjectAPI/Item.lua:223
Clear = defined @FrameXML/ObjectAPI/Item.lua:131
GetItemIcon = defined @FrameXML/ObjectAPI/Item.lua:187
GetItemMaxStackSize = defined @FrameXML/ObjectAPI/Item.lua:262
ContinueWithCancelOnItemLoad = defined @FrameXML/ObjectAPI/Item.lua:334
IsItemLocked = defined @FrameXML/ObjectAPI/Item.lua:171
IsRecordDataCached = defined @FrameXML/ObjectAPI/Item.lua:344
IsItemEmpty = defined @FrameXML/ObjectAPI/Item.lua:138
SetItemID = defined @FrameXML/ObjectAPI/Item.lua:94
IsStackable = defined @FrameXML/ObjectAPI/Item.lua:273
SetItemLink = defined @FrameXML/ObjectAPI/Item.lua:89
GetInventoryType = defined @FrameXML/ObjectAPI/Item.lua:278
SetItemGUID = defined @FrameXML/ObjectAPI/Item.lua:99
GetItemID = defined @FrameXML/ObjectAPI/Item.lua:160
GetCurrentItemLevel = defined @FrameXML/ObjectAPI/Item.lua:241
GetItemQualityColorRGB = defined @FrameXML/ObjectAPI/Item.lua:257
UnlockItem = defined @FrameXML/ObjectAPI/Item.lua:181
GetItemGUID = defined @FrameXML/ObjectAPI/Item.lua:115
SetItemLocation = defined @FrameXML/ObjectAPI/Item.lua:84
GetItemName = defined @FrameXML/ObjectAPI/Item.lua:197
IsItemInPlayersControl = defined @FrameXML/ObjectAPI/Item.lua:150
GetItemLink = defined @FrameXML/ObjectAPI/Item.lua:208
ValidateForContinueOnItemLoad = defined @FrameXML/ObjectAPI/Item.lua:311
GetStaticBackingItem = defined @FrameXML/ObjectAPI/Item.lua:146
HasItemLocation = defined @FrameXML/ObjectAPI/Item.lua:127
ContinueWithCancelOnRecordLoad = defined @FrameXML/ObjectAPI/Item.lua:340
ContinueOnItemLoad = defined @FrameXML/ObjectAPI/Item.lua:328
GetStackCount = defined @FrameXML/ObjectAPI/Item.lua:234
}
(*temporary) = "attempt to compare number with nil"

commented

Another one, when crafting a Blazing Ink. This was not even the first craft this session, let alone today.
I can see that the error is different but I got it in the same situation.

1x ...faceCraftSim/Modules/CraftResults/Frames.lua:183: attempt to concatenate a nil value
[string "@CraftSim/Modules/CraftResults/Frames.lua"]:183: in function UpdateItemList' [string "@CraftSim/Modules/CraftResults/CraftResults.lua"]:110: in function AddCraftData'
[string "@CraftSim/Modules/CraftResults/CraftResults.lua"]:164: in function AddResult' [string "@CraftSim/Modules/CraftResults/CraftResults.lua"]:220: in function callback'
[string "@CraftSim/Util/Util.lua"]:80: in function ContinueOnAllItemsLoaded' [string "@CraftSim/Modules/CraftResults/CraftResults.lua"]:219: in function processCraftResults'
[string "@CraftSim/Modules/CraftResults/CraftResults.lua"]:42: in function <...ddOns/CraftSim/Modules/CraftResults/CraftResults.lua:41>

Locals:
self =

{
UpdateRecipeData = defined @CraftSim/Modules/CraftResults/Frames.lua:62
UpdateItemList = defined @CraftSim/Modules/CraftResults/Frames.lua:163
Init = defined @CraftSim/Modules/CraftResults/Frames.lua:7
}
craftResultFrame = CraftSimCraftResultsFrame {
BottomLeftCorner = Texture {
}
OnBackdropLoaded = defined @SharedXML/Backdrop.lua:152
GetBackdropColor = defined @SharedXML/Backdrop.lua:390
SetTransparency = defined @CraftSim/Util/Frames.lua:467
TopLeftCorner = Texture {
}
RightEdge = Texture {
}
decollapse = defined @CraftSim/Util/Frames.lua:352
ApplyBackdrop = defined @SharedXML/Backdrop.lua:294
SetBackdrop = defined @SharedXML/Backdrop.lua:329
ClearBackdrop = defined @SharedXML/Backdrop.lua:282
GetBackdropBorderColor = defined @SharedXML/Backdrop.lua:409
title = FontString {
}
collapsed = false
SetBorderBlendMode = defined @SharedXML/Backdrop.lua:266
originalX = 700
hookFrame = Frame {
}
resetPosition = defined @CraftSim/Util/Frames.lua:446
backdropInfo =
{
}
OnBackdropSizeChanged = defined @SharedXML/Backdrop.lua:182
TopRightCorner = Texture {
}
content = Frame {
}
collapse = defined @CraftSim/Util/Frames.lua:340
originalY = 450
BottomRightCorner = Texture {
}
GetEdgeSize = defined @SharedXML/Backdrop.lua:188
0 =
closeButton = Button {
}
TopEdge = Texture {
}
Center = Texture {
}
BottomEdge = Texture {
}
enabledLinks = true
SetupTextureCoordinates = defined @SharedXML/Backdrop.lua:214
HasBackdropInfo = defined @SharedXML/Backdrop.lua:278
SetBackdropBorderColor = defined @SharedXML/Backdrop.lua:422
collapseButton = Button {
}
SetupPieceVisuals = defined @SharedXML/Backdrop.lua:246
SetBackdropColor = defined @SharedXML/Backdrop.lua:399
LeftEdge = Texture {
}
GetBackdrop = defined @SharedXML/Backdrop.lua:347
}
craftResultItems =
{
1 =
{
}
2 =
{
}
3 =
{
}
4 =
{
}
5 =
{
}
6 =
{
}
7 =
{
}
}
craftedItemsText = "1 x |cffa335ee|Hitem:192999::::::::70:252::13:6:8836:8840:8902:8780:8802:8792:6:28:2164:29:49:30:36:38:8:40:258:48:194569:::::|h[Signet of Titanic Insight |A:Professions-ChatIcon-Quality-Tier5:17:17::1|a]|h|r
18 x |cff1eff00|Hitem:198419::::::::70:252::::1:38:2:::::|h[Blazing Pigment |A:Professions-ChatIcon-Quality-Tier2:17:23::1|a]|h|r
2 x |cff1eff00|Hitem:198420::::::::70:252::::1:38:3:::::|h[Blazing Pigment |A:Professions-ChatIcon-Quality-Tier3:17:18::1|a]|h|r
7 x |cff1eff00|Hitem:194829::::::::70:252::::1:40:666:::::|h[Fated Fortune Card]|h|r
38 x |cff1eff00|Hitem:193369::::::::70:252:::::::::|h[Silken Gemdust |A:Professions-ChatIcon-Quality-Tier2:17:23::1|a]|h|r
10 x |cff1eff00|Hitem:193370::::::::70:252::::1:38:3:::::|h[Silken Gemdust |A:Professions-ChatIcon-Quality-Tier3:17:18::1|a]|h|r
16 x |cffffffff|Hitem:194846::::::::70:252::::2:38:3:40:636:::::|h[Blazing Ink |A:Professions-ChatIcon-Quality-Tier3:17:18::1|a]|h|r
"
savedReagentsText = "
Saved Reagents:
"
(for generator) = defined =[C]:-1
(for state) =
{
1 =
{
}
2 =
{
}
}
(for control) = 1
_ = 1
savedReagent =
{
savedCosts = 235500
quantity = 1
item =
{
}
qualityID = 0
}
(*temporary) = "
Saved Reagents:
"
(*temporary) = 1
(*temporary) = " x "
(*temporary) = nil
(*temporary) = "
"
(*temporary) = "attempt to concatenate a nil value"

commented

Still happening, this time when finishing a craft of Sensei's Sundered Onyx.

1x ...faceCraftSim/Modules/CraftResults/Frames.lua:185: attempt to compare two nil values
[string "@CraftSim/Modules/CraftResults/Frames.lua"]:185: in function compFunc' [string "@CraftSim/Libs/GUTIL-1.0/GUTIL.lua"]:393: in function Sort'
[string "@CraftSim/Modules/CraftResults/Frames.lua"]:184: in function UpdateItemList' [string "@CraftSim/Modules/CraftResults/CraftResults.lua"]:110: in function AddCraftData'
[string "@CraftSim/Modules/CraftResults/CraftResults.lua"]:165: in function AddResult' [string "@CraftSim/Modules/CraftResults/CraftResults.lua"]:225: in function callback'
[string "@CraftSim/Libs/GUTIL-1.0/GUTIL.lua"]:332: in function ContinueOnAllItemsLoaded' [string "@CraftSim/Modules/CraftResults/CraftResults.lua"]:224: in function processCraftResults'
[string "@CraftSim/Modules/CraftResults/CraftResults.lua"]:42: in function <...ddOns/CraftSim/Modules/CraftResults/CraftResults.lua:41>

Locals:
a =

{
quantity = 1
item =
{
}
quantityMulticraft = 0
}
b =
{
quantity = 1
item =
{
}
quantityMulticraft = 0
}
(*temporary) = nil
(*temporary) = nil
(*temporary) =
{
GetItemLocation = defined @FrameXML/ObjectAPI/Item.lua:104
IsDataEvictable = defined @FrameXML/ObjectAPI/Item.lua:306
LockItem = defined @FrameXML/ObjectAPI/Item.lua:175
IsItemDataCached = defined @FrameXML/ObjectAPI/Item.lua:295
GetInventoryTypeName = defined @FrameXML/ObjectAPI/Item.lua:289
GetItemQualityColor = defined @FrameXML/ObjectAPI/Item.lua:252
Matches = defined @FrameXML/ObjectAPI/Item.lua:66
itemLink = "|cff0070dd|Hitem:197394::::::::70:252::13::2:28:2164:40:703:::::|h[Renewed Proto-Drake: Predator Pattern]|h|r"
GetItemQuality = defined @FrameXML/ObjectAPI/Item.lua:223
Clear = defined @FrameXML/ObjectAPI/Item.lua:131
GetItemIcon = defined @FrameXML/ObjectAPI/Item.lua:187
GetItemMaxStackSize = defined @FrameXML/ObjectAPI/Item.lua:262
ContinueWithCancelOnItemLoad = defined @FrameXML/ObjectAPI/Item.lua:334
IsItemLocked = defined @FrameXML/ObjectAPI/Item.lua:171
IsRecordDataCached = defined @FrameXML/ObjectAPI/Item.lua:344
IsItemEmpty = defined @FrameXML/ObjectAPI/Item.lua:138
SetItemID = defined @FrameXML/ObjectAPI/Item.lua:94
IsStackable = defined @FrameXML/ObjectAPI/Item.lua:273
SetItemLink = defined @FrameXML/ObjectAPI/Item.lua:89
GetInventoryType = defined @FrameXML/ObjectAPI/Item.lua:278
SetItemGUID = defined @FrameXML/ObjectAPI/Item.lua:99
GetItemID = defined @FrameXML/ObjectAPI/Item.lua:160
GetCurrentItemLevel = defined @FrameXML/ObjectAPI/Item.lua:241
GetItemQualityColorRGB = defined @FrameXML/ObjectAPI/Item.lua:257
UnlockItem = defined @FrameXML/ObjectAPI/Item.lua:181
GetItemGUID = defined @FrameXML/ObjectAPI/Item.lua:115
SetItemLocation = defined @FrameXML/ObjectAPI/Item.lua:84
GetItemName = defined @FrameXML/ObjectAPI/Item.lua:197
IsItemInPlayersControl = defined @FrameXML/ObjectAPI/Item.lua:150
GetItemLink = defined @FrameXML/ObjectAPI/Item.lua:208
ValidateForContinueOnItemLoad = defined @FrameXML/ObjectAPI/Item.lua:311
GetStaticBackingItem = defined @FrameXML/ObjectAPI/Item.lua:146
HasItemLocation = defined @FrameXML/ObjectAPI/Item.lua:127
ContinueWithCancelOnRecordLoad = defined @FrameXML/ObjectAPI/Item.lua:340
ContinueOnItemLoad = defined @FrameXML/ObjectAPI/Item.lua:328
GetStackCount = defined @FrameXML/ObjectAPI/Item.lua:234
}
(*temporary) = "attempt to compare two nil values"

commented

Still happening.
This time when crafting an Alacritous Alchemist Stone for a public crafting order. (got some mats saved by resourcefulness, no clue if that matters).

2x ...faceCraftSim/Modules/CraftResults/Frames.lua:185: attempt to compare nil with number
[string "@CraftSim/Modules/CraftResults/Frames.lua"]:185: in function compFunc' [string "@CraftSim/Libs/GUTIL-1.0/GUTIL.lua"]:393: in function Sort'
[string "@CraftSim/Modules/CraftResults/Frames.lua"]:184: in function UpdateItemList' [string "@CraftSim/Modules/CraftResults/CraftResults.lua"]:110: in function AddCraftData'
[string "@CraftSim/Modules/CraftResults/CraftResults.lua"]:164: in function AddResult' [string "@CraftSim/Modules/CraftResults/CraftResults.lua"]:220: in function callback'
[string "@CraftSim/Libs/GUTIL-1.0/GUTIL.lua"]:332: in function ContinueOnAllItemsLoaded' [string "@CraftSim/Modules/CraftResults/CraftResults.lua"]:219: in function processCraftResults'
[string "@CraftSim/Modules/CraftResults/CraftResults.lua"]:42: in function <...ddOns/CraftSim/Modules/CraftResults/CraftResults.lua:41>

Locals:
a =

{
quantity = 1
item =
{
}
quantityMulticraft = 0
}
b =
{
quantity = 1
item =
{
}
quantityMulticraft = 0
}
(*temporary) = 3
(*temporary) = nil
(*temporary) =
{
GetItemLocation = defined @FrameXML/ObjectAPI/Item.lua:104
IsDataEvictable = defined @FrameXML/ObjectAPI/Item.lua:306
LockItem = defined @FrameXML/ObjectAPI/Item.lua:175
IsItemDataCached = defined @FrameXML/ObjectAPI/Item.lua:295
GetInventoryTypeName = defined @FrameXML/ObjectAPI/Item.lua:289
GetItemQualityColor = defined @FrameXML/ObjectAPI/Item.lua:252
Matches = defined @FrameXML/ObjectAPI/Item.lua:66
itemLink = "|cff0070dd|Hitem:193033::::::::70:252::13::2:28:2164:40:273:::::|h[Convergent Prism]|h|r"
GetItemQuality = defined @FrameXML/ObjectAPI/Item.lua:223
Clear = defined @FrameXML/ObjectAPI/Item.lua:131
GetItemIcon = defined @FrameXML/ObjectAPI/Item.lua:187
GetItemMaxStackSize = defined @FrameXML/ObjectAPI/Item.lua:262
ContinueWithCancelOnItemLoad = defined @FrameXML/ObjectAPI/Item.lua:334
IsItemLocked = defined @FrameXML/ObjectAPI/Item.lua:171
IsRecordDataCached = defined @FrameXML/ObjectAPI/Item.lua:344
IsItemEmpty = defined @FrameXML/ObjectAPI/Item.lua:138
SetItemID = defined @FrameXML/ObjectAPI/Item.lua:94
IsStackable = defined @FrameXML/ObjectAPI/Item.lua:273
SetItemLink = defined @FrameXML/ObjectAPI/Item.lua:89
GetInventoryType = defined @FrameXML/ObjectAPI/Item.lua:278
SetItemGUID = defined @FrameXML/ObjectAPI/Item.lua:99
GetItemID = defined @FrameXML/ObjectAPI/Item.lua:160
GetCurrentItemLevel = defined @FrameXML/ObjectAPI/Item.lua:241
GetItemQualityColorRGB = defined @FrameXML/ObjectAPI/Item.lua:257
UnlockItem = defined @FrameXML/ObjectAPI/Item.lua:181
GetItemGUID = defined @FrameXML/ObjectAPI/Item.lua:115
SetItemLocation = defined @FrameXML/ObjectAPI/Item.lua:84
GetItemName = defined @FrameXML/ObjectAPI/Item.lua:197
IsItemInPlayersControl = defined @FrameXML/ObjectAPI/Item.lua:150
GetItemLink = defined @FrameXML/ObjectAPI/Item.lua:208
ValidateForContinueOnItemLoad = defined @FrameXML/ObjectAPI/Item.lua:311
GetStaticBackingItem = defined @FrameXML/ObjectAPI/Item.lua:146
HasItemLocation = defined @FrameXML/ObjectAPI/Item.lua:127
ContinueWithCancelOnRecordLoad = defined @FrameXML/ObjectAPI/Item.lua:340
ContinueOnItemLoad = defined @FrameXML/ObjectAPI/Item.lua:328
GetStackCount = defined @FrameXML/ObjectAPI/Item.lua:234
}
(*temporary) = "attempt to compare nil with number"

commented

Thx for all this data! I think it might have something to do with items being loaded and cached by blizzard and craftsim waiting for the finished load!
I ll take a closer look at some point!

commented

This is not related to first craft in a session, can and does happen all the time.
What I've observed since writing this ticket is they mostly happen after some (any) filtering, be it entering something in the filter field, shift+clicking an item to see what recipes it's used in, changing to and back from Crafting Orders tab, selecting some option or expansion in the Filter dropdown, etc.