CTMod

CTMod

766k Downloads

Dragonflight Beta support

Voxxel opened this issue ยท 19 comments

commented

Addons are now enabled in the Beta but CTMod is not working. I would really appreciate it if you could fix it anytime soon.

commented

When the Dragonflight pre-patch arrives, I now intend to retire CT_BarMod and CT_BottomBar. I will issue a new version of CTMod coinciding with the prepatch that will simply disable these two modules in Retail (while keeping them in Classic).

However, a few things are lost that the new Dragonflight UI doesn't replace. These niche features will be added to CT_Core, starting with the ability to drag the menu bar and bags from the bottom-right corner of the screen.

commented

I believe there are lot of other up-to-date addons covering action bars so I don't know if so many people affected by this change. I personally use Bartender4 for all the action bar stuff and it fulfills all my need (and even beyond).

commented

While it was working on the previous Beta build in the new build I can't use CT_Core's Movable Objectives Tracker because even if it's unlocked I can't grab the window anywhere. It can show up the border too but I can't move the window. However, the "Reset window position" button is working.
I get this LUA error everytime when I toggle "Enable these options" :

5x bad argument #2 to '?' (Usage: self:SetParent([parent]))
[string "=[C]"]: ?
[string "@Interface/AddOns/CT_Core/CT_Core_Other.lua"]:2413: in function <Interface/AddOns/CT_Core/CT_Core_Other.lua:2395>
[string "@Interface/AddOns/CT_Core/CT_Core_Other.lua"]:2737: in function `func'
[string "@Interface/AddOns/CT_Core/CT_Core_Other.lua"]:3208: in function `modupdate'
[string "@Interface/AddOns/CT_Core/CT_Core.lua"]:233: in function `updateFunc'
[string "@Interface/AddOns/CT_Library/CT_Library.lua"]:978: in function `setOption'
[string "@Interface/AddOns/CT_Library/CT_Library.lua"]:1723: in function <Interface/AddOns/CT_Library/CT_Library.lua:1718>

Locals:

Another bug in CT_Core:
Can't resize chat window because even if I enable resize buttons to all corner they don't show up. The only time they're visible when I enable "Edit Mode", the new DF feature to edit the HUD, but during the Edit Mode it's not able to use CT_core's resize buttons. This is not a new bug.

I don't get any particular LUA error for this but toggling "Show resize buttons for mouseovers only" option gives this error:

3x Usage: self:SetNormalTexture(asset)
[string "=[C]"]: in function `SetNormalTexture'
[string "@Interface/AddOns/CT_Core/CT_Core_Chat.lua"]:648: in function <Interface/AddOns/CT_Core/CT_Core_Chat.lua:627>
[string "@Interface/AddOns/CT_Core/CT_Core_Chat.lua"]:669: in function <Interface/AddOns/CT_Core/CT_Core_Chat.lua:665>
[string "@Interface/AddOns/CT_Core/CT_Core_Chat.lua"]:678: in function <Interface/AddOns/CT_Core/CT_Core_Chat.lua:674>
[string "@Interface/AddOns/CT_Core/CT_Core_Chat.lua"]:1214: in function `chatupdate'
[string "@Interface/AddOns/CT_Core/CT_Core.lua"]:234: in function `updateFunc'
[string "@Interface/AddOns/CT_Library/CT_Library.lua"]:978: in function `setOption'
[string "@Interface/AddOns/CT_Library/CT_Library.lua"]:1723: in function <Interface/AddOns/CT_Library/CT_Library.lua:1718>

Locals:
commented

I am now able to load the following modules in the Dragonflight pre-patch on the public test realm:

  • CT_BuffMod
  • CT_Core
  • CT_ExpenseHistory
  • CT_MapMod
  • CT_RaidAssist
  • CT_Timer
  • CT_Viewport

However, I have not yet added the new herb and ore nodes to CT_MapMod for the actual expansion itself.

Update: CT_PartyBuffs is now also updated.

commented

Looks promising!
I can't reach the settings of Viewport because it brings up the settings of CT_Timer. Likewise Mapmod settings opens Mailmod settings and CTRA settings opens Mapmod settings. The not-yet-updated plugins cause this error and also the text overlapping bug.
I also encountered a Core bug where it seems the addon can't make chat resize buttons in any corner.

commented

I started toying with CT_BarMod to get a sense for how hard it might be. I made some progress, but its still too soon to conclude how much more work remains to get it working.

I don't want to delay the already-updated portions of CTMod while waiting on these harder challenges, so I am going to defer that code to a future "9.2.0.3". This means that 9.2.0.2 will exclude CT_BarMod and CT_BottomBar.

commented

Working on CT_UnitFrames. I'll have to make some decisions soon concerning whether to embrace the new look, or retro, or maybe a toggle for both?

image

These are "focus" unit frames -- the one at the top by CTMod, the one at the bottom by Dragonflight

commented

Some modernization always feels refreshing but some people rather tend to stick with retro pixels indeed. A toggle would fit all needs imo. Meanwhile, I caught a CT_Core lua error in the latest DF Beta build :

 4x Interface/AddOns/CT_Core/CT_Core_Chat.lua:925: attempt to call method 'SetMinResize' (a nil value)
[string "@Interface/AddOns/CT_Core/CT_Core_Chat.lua"]:925: in function <Interface/AddOns/CT_Core/CT_Core_Chat.lua:878>
[string "@Interface/AddOns/CT_Core/CT_Core_Chat.lua"]:950: in function <Interface/AddOns/CT_Core/CT_Core_Chat.lua:946>
[string "@Interface/AddOns/CT_Core/CT_Core_Chat.lua"]:959: in function <Interface/AddOns/CT_Core/CT_Core_Chat.lua:955>
[string "@Interface/AddOns/CT_Core/CT_Core_Chat.lua"]:1116: in function <Interface/AddOns/CT_Core/CT_Core_Chat.lua:1102>
[string "@Interface/AddOns/CT_Core/CT_Core_Chat.lua"]:1152: in function `value'
[string "@Interface/AddOns/CT_Library/CT_Library.lua"]:697: in function <Interface/AddOns/CT_Library/CT_Library.lua:693>

Dahk Celes says: Edited for brevity. Thanks for the error report!

commented

10.0.0.1 (2022-10-23)

  • Further updates for WoW Dragonflight
  • Target health bar text on live servers with CT_UnitFrames
  • Some features will be disabled (but remain in Classic) to facilitate a timely, stable release.

The WoW Dragonflight UI includes a new "edit mode" with eight movable action bars.

  • CT_BarMod will disable itself automatically
  • CT_BottomBar will focus on parts that Blizzard omitted
    • Bags
    • Menu buttons
    • Rep and XP bars (future version - work in progress)

Blizzard is preventing action bar and buff frame addons from responding to key-press and mouse-press "down" clicks.

  • CT_BuffMod will remove buffs only when releasing the right mouse button
  • If CT_BarMod is restored in a future version, it will be affected by the same restrictions.
commented

"When the Dragonflight pre-patch arrives, I now intend to retire CT_BarMod and CT_BottomBar." At first this disappointed me. But, then I loaded up 9.2.0.3a into the DF beta and stated playing around. What I have found so far.

  1. Voxxel's issue "I can't reach the settings of Viewport because it brings up the settings of CT_Timer. Likewise Mapmod settings opens Mailmod settings and CTRA settings opens Mapmod settings."

This 1 module offset affects everything below CT_core. It is being caused by CT_ExpenseHistory failing to load (It doesn't show up in the Main Menu list). Disabling CT_ExpenseHistory before launching the game clears up this issue and all modules open correctly matching.

  1. Voxxel reports problem with "CT_Core's Movable Objectives Tracker because even if it's unlocked I can't grab the window anywhere. It can show up the border too but I can't move the window. I get this LUA error everytime when I toggle "Enable these options" :"

I get the same LUA error message. Except for moving the window everything else seems to work. The Default UI allows you to move this window now so not really needed in this addon anymore I guess.

  1. Voxxel also reports problem with resizing chat window. I see this happening with the main General/Combat log windows but any additional chat window you create the CT_Core tools work. Again the Default UI allows resizing the main General chat window.

  2. At this point the Default UI makes CT_Bottombar redundant and unnecessary as far as I can see.

  3. From what I see the only thing I would use CT_Barmod for would be additional action bars. I use 7 but Default UI limited to 5. Also CT_Barmod has more flexibility in modifying bars i.e. Default UI padding between slots only has a 2-10 range (I set all mine to -2) and Default UI only has 10% steps for resizing vs 1% (I'm set at 87% on retail) **EDIT Oct 11: With todays new build on Beta there are now 8 Action bars available! Yay! **

If you decide to not update CT_Barmod I'll just move to Bartender4. I played with it for the first time Sunday and it gives me the extra bars and increased padding/sizing range/granularity. Plus it already has the Microbar and Bags bar repositioning (but thanks for putting this in CT_Core).

  1. CT_UnitFrames: After playing with the new UI I prefer the old look. So the ability to use the old look (default or toggle) would be great! Thanks!

  2. I like and am using CT_Buffmod, Partybuffs, Mailmod and Mapmod. The first two seem to be working but I haven't done any testing beyond cursory. The last two look like they need work from casual poking (I'll try to get some more specifics soon_TM)

  3. Have I thanked you lately for keeping this addon viable these last couple expansions? ;) THANK YOU!!!

commented

@ilmare-tuor

Thanks for all the feedback. I'm definitely encouraged by the beta officially supporting ten action bars.

With this news, maybe I should look at rebuilding CT_BarMod as a slimmer module that simply enhances Edit Mode. For example, adding in the finer adjustments like 1% scaling increments. Whether or not this is possible will depend quite a bit on how Edit Mode actually works. I haven't studied it in depth yet.

commented

Oops! Sorry that should have been Eight (8) action bars. A lot of people were ASKING for 10 but we got 8. Somewhere in there I confused myself ;)

Having CT_BarMod as a slimmer module for enhanced editing would be nice. The Bartender4 update supports wider ranges already but I'd hate to add a new addon just for that (and they haven't updated for the new default bars).

I'm currently running the Default bars with 8 active. On my 27", 4K display I have 2 rows of 4 bars across the bottom. 2 of the bars are set at 11 slots so they can fit with the current padding. There is a noticeable gap between buttons at padding of 2. I'm sure if I could just get a padding of 0 they would fit with all 12 buttons enabled.

So I'm running CT_Core and using that to reposition the microbar and bag bar plus these modules
CT_BuffMod
CT_Library
CT_MailMod
CT_MapMod
CT_PartyBuffs
CT_Timer
CT_UnitFrames
CT_Viewport (although I don't use it I have it enabled while testing)

Looks like you've made some updates and I will grab 9.2.0.3b and play with that.

commented

I've been playing with 9.2.0.3b and still having an issue with CT_ExpenseHistory enabled. I saw you had an update so grabbed 9.2.0.4a to see if that made an improvement. I get the same LUA error for 9.2.0.3b or 9.2.0.4a when I first log in on a character or reload the UI. Also The 1 module offset still affects everything below CT_core and CT_ExpenseHistory doesn't show up in the Main Menu list.

Page 1/5
Message: ...rface/AddOns/CT_ExpenseHistory/CT_ExpenseHistory.lua:422: hooksecurefunc(): UseContainerItem is not a function
Time: Mon Oct 17 14:24:55 2022
Count: 1
Stack: ...rface/AddOns/CT_ExpenseHistory/CT_ExpenseHistory.lua:422: hooksecurefunc(): UseContainerItem is not a function
[string "=[C]"]: in function `hooksecurefunc'
[string "@Interface/AddOns/CT_ExpenseHistory/CT_ExpenseHistory.lua"]:422: in main chunk

Locals:

Page 2/5
Message: Interface/AddOns/CT_ExpenseHistory/CT_ExpenseHistory.lua:1 (null)
Time: Mon Oct 17 14:24:55 2022
Count: 1

Page 3/5
Message: Interface/AddOns/CT_ExpenseHistory/CT_ExpenseHistory.xml:954 Frame CT_ExpenseHistoryFrame: Unknown function CT_ExpenseHistoryFrame_OnLoad in element OnLoad
Time: Mon Oct 17 14:24:55 2022
Count: 1

Page 4/5
Message: Interface\FrameXML\Bindings.xml:1 Interface/AddOns/CT_ExpenseHistory/CT_ExpenseHistory.lua:1 (null)
Time: Mon Oct 17 14:24:55 2022
Count: 1

Page 5/5
Message: Interface\FrameXML\Bindings.xml:1 Interface/AddOns/CT_ExpenseHistory/CT_ExpenseHistory.xml:954 Frame CT_ExpenseHistoryFrame: Unknown function CT_ExpenseHistoryFrame_OnLoad in element OnLoad
Time: Mon Oct 17 14:24:55 2022
Count: 1

commented

Okay, I think I understand what's happening. I heard a rumour that some bag-related API changes didn't make it yet into the public test realm -- they might be arriving in 10.0.2 but not yet in 10.0.0 which is what I've been working in. It stands to reason this could affect CT_ExpenseHistory.

Judging from the error log, I probably need to change the hook at line 422 to something else.

Edit: it appears I've been invited to the beta . :)

commented

Makes sense. Ironically for all the stuff I've put up here about CT_ExpenseHistory it is not a module I really use. It's just there. Can't remember the last time I opened it in game ;) If it had not popped LUA errors and affected the Main Menu I wouldn't have noticed any issues.

CT_UnitFrames, CT_Core and CT_BuffMod are the primary modules modifying my setup in Beta that I would miss if they were not there. Mail and Map mods are nice QOL adds but, I wouldn't miss them. A slimmer CT_BarMod module for enhanced editing is my wish list incase I hadn't mentioned it ;->

Glad you have been invited to the Beta! Thanks for all your work!

commented

Alright. The CT_EH problem is fixed. I also learned a few new things about the API that I'll have to document in the wiki if they remain unchanged in a couple weeks.

commented

Work in progress, but CT_BottomBar can now be re-enabled. I still need to figure out what happens to the default UI with pet battles and vehicles, because that will possibly impact the bags and menu bar. I also haven't setup the xp/rep bars yet.

Meanwhile, I'm back to thinking about resurfacing my work on CT_BarMod. I previously tried to get it working, but was running into serious issues -- I've since learned of new limitations Blizzard are imposing (and will hopefully reverse) on secure frames and mouse clicks... but now that I know about it, there might be a possible workaround to revive the bars.

commented

Well I didn't expect this outcome... but here is CT_BottomBar after disabling anything to do with the actual main menu bar.

image

commented

Thank you very much for reviving CTmod, m8! <3