CT_Bottom Bar moves my menu bar and cannot be shifted
DavePNZ opened this issue · 11 comments
I think I have a fix for CTBottomBar. at least it's mostly working for me now.
If you replace every instance (there are several) of ReputationWatchBar_UpdateMaxLevel
with ReputationWatchBar_Update
things sees mostly better. Still a work in progress though, and I'm not a lua/wow mod developer so I'm mostly just doing stuff with trial and error
Here is the change: master...robertzak:CTMod:4.4.0_fix_attempt
I released a "fixed" version for cata classic you can download: https://github.com/robertzak/CTMod/archive/refs/tags/4.4.0_cata_classic_fix.zip
So far this looks really good. Huge thanks. I get the following error when a spell procs that lights up the taskbar:
Date: 2024-05-12 21:48:50
ID: 1
Error occured in: Global
Count: 3
Message: Interface/AddOns/CT_BarMod/CT_BarMod_Use.lua line 868:
attempt to index field 'ProcStartAnim' (a nil value)
Debug:
[string "=[C]"]: ?
[string "@Interface/AddOns/CT_BarMod/CT_BarMod_Use.lua"]:868:
Interface/AddOns/CT_BarMod/CT_BarMod_Use.lua:838
[string "@Interface/AddOns/CT_BarMod/CT_BarMod_Use.lua"]:899: ?()
[string "@Interface/AddOns/CT_BarMod/CT_BarMod_ActionButton.lua"]:651: showOverlayGlow()
[string "@Interface/AddOns/CT_BarMod/CT_BarMod_Use.lua"]:1704: eventFuncs()
[string "@Interface/AddOns/CT_Library/CT_Library.lua"]:694:
Interface/AddOns/CT_Library/CT_Library.lua:687
Locals:
(*temporary) = defined =[C]:-1
I can try to take a look after work, but I don't have much time. I may not be able to spend much on it until the weekend.
Can you provide more specifics? What spell/class caused this? Was it a proc or something?
Being able to recreate it locally will be important for me to try to test any fix (assuming I can come up with one)
My specific issue was when Impact or Hot Streak procs. This is in the Cata pre-patch, btw.
When these proc, the bar should light up, but instead this error happens, and the bars do nothing.
@ablib2 I think I fixed it (and another lua error I ran into when I logged onto my mage).
Give it a try when you have a chance and let me know: https://github.com/robertzak/CTMod/archive/refs/tags/10.3.0.1.zip
@ablib2 I think I fixed it (and another lua error I ran into when I logged onto my mage).
Give it a try when you have a chance and let me know: https://github.com/robertzak/CTMod/archive/refs/tags/10.3.0.1.zip
So far so good. You're amazing!