DBM - PvP Mods (Requires Deadly Boss Mods) - DBM

DBM - PvP Mods (Requires Deadly Boss Mods) - DBM

Addons
21M Downloads

AV timers seems broken in wotlk

Nillx opened this issue · 11 comments

commented

Did a few AVs today and it doesnt really show any timers or if it does they are wrong. Wotlk prepatch.

commented

To be clear, the timers start when a team recaptures a tower/graveyard (e.g., Horde captures a bunker [no timer] and then Alliance recaptures a bunker [timer starts, "The Alliance has taken Stonehearth Bunker!" appears in chat])

commented

This is being investigated shortly. :)

commented

The timers are broken in the pre-patch. They randomly appear and disappear, sometimes they don't appear at all.

commented

if its any help, removing isTBC from here fixes them as far as i can tell

DBM-PvP/DBM-PvP/PvPGeneral.lua

Lines 377 to 385 in 6906098

[(isClassic or isTBC) and 3 or 4] = State.ALLY_CONTESTED,
[(isClassic or isTBC) and 14 or 15] = State.ALLY_CONTROLLED,
[(isClassic or isTBC) and 13 or 14] = State.HORDE_CONTESTED,
[(isClassic or isTBC) and 12 or 13] = State.HORDE_CONTROLLED,
-- Tower/Lighthouse
[(isClassic or isTBC) and 8 or 9] = State.ALLY_CONTESTED,
[(isClassic or isTBC) and 10 or 11] = State.ALLY_CONTROLLED,
[(isClassic or isTBC) and 11 or 12] = State.HORDE_CONTESTED,
[(isClassic or isTBC) and 9 or 10] = State.HORDE_CONTROLLED,
not sure of any other changes, but looks like they swapped to retail values for this, and looks like they kept
WOW_PROJECT_ID = (WOW_PROJECT_BURNING_CRUSADE_CLASSIC) for wrath :P

commented

Could you try the alpha version? That was all changed to support wrath 🗡️

commented

Alpha version has the same issue.

commented

if its ur recent commits, no

DBM-PvP/DBM-PvP/PvPGeneral.lua

Line 381 in 81e443d

[not isRetail and 3 or 4] = State.ALLY_CONTESTED,

wrath is using 'retail' values here, so check should be not isRetail and not isWrath and 3 or 4 or something similar

havent checked anything else, just been grinding av :P

commented

These have been updated in latest alpha :)

commented

also

DBM-PvP/DBM-PvP/PvPGeneral.lua

Line 514 in 81e443d

self:UpdateWinTimer(2000, tonumber(smatch(GetIconAndTextWidgetVisualizationInfo(1893).text, '(%d+)/2000')), tonumber(smatch(GetIconAndTextWidgetVisualizationInfo(1894).text, '(%d+)/2000')), allyBases, hordeBases)
needs to be changed from 2000 to 1600 in the three spots there for arathi

commented

The most recent file on curseforge has fixed this issue (r135-9-g2923988).

commented

All BGs should be fixed. Tagged a new release and closing this issue for now since I'm pretty sure AB and AV issues all resolved.