DBM-SpellTimers

DBM-SpellTimers

8M Downloads

Icons on Spells

orionshock opened this issue ยท 5 comments

commented

Describe the bug
Classic Version - there are no icons on the bars.

image

commented

Have you turned icons off inside of DBM-Core? This can be found inside of "/dbm -> options -> timers -> bar apperance"

commented

Have you turned icons off inside of DBM-Core? This can be found inside of "/dbm -> options -> timers -> bar apperance"

Icons Enabled there. All the normal stuff from the boss mods have icons and show as expected.
I do have icons set to show on the right side -- tho when i too that screenshot it was set left

image

commented

That's a bug in classic. has always been there. it's because the way the code works when you input a spellId it translates to name right away, and as a result spellicon look up fials because it's being looked up with name instead of ID as expected. I saw that bug months ago just forgot about it :D

commented

after further research, I appear to be asking the impossible :

Patch 1.13.2 (2019-08-26): The spellId and extraSpellId parameters are defunct in Classic, returning 0 to resemble the pre-2.4.0 combat log.
https://wow.gamepedia.com/COMBAT_LOG_EVENT

commented

however the spell id is available, as it's required when setting your own spells to watch.

Line 371 & 387:

SpellBarIndex[bartext] = Bars:CreateBar(v.cooldown, bartext, GetSpellTexture(v.spell), nil, true)

makes it work as desired - tho i don't know how you'd code that to be retail & classic friendly