DBM - Deadly Boss Mods (DBM-Core)

DBM - Deadly Boss Mods (DBM-Core)

522M Downloads

DBM-Core/Libs/LibCustomGlow-1.0-20/LibCustomGlow-1.0.lua:932: attempt to index local 'r' (a nil value)

R-Adrian opened this issue ยท 1 comments

commented

Describe the bug
geting LUA error notifications spam in Darkflame Cleft (heroic) dungeon.
I think it happens when the target is moving to an area in the dungeon where there is no light and thus becomes immune to attacks.

Do you have an error log of what happened?

794x ...BM-Core/Libs/LibCustomGlow-1.0-20/LibCustomGlow-1.0.lua:932: attempt to index local 'r' (a nil value)
[string "@DBM-Core/Libs/LibCustomGlow-1.0-20/LibCustomGlow-1.0.lua"]:932: in function `ProcGlow_Stop'
[string "@DBM-Core/DBM-Nameplate.lua"]:429: in function `StopGlow'
[string "@DBM-Core/DBM-Nameplate.lua"]:462: in function <DBM-Core/DBM-Nameplate.lua:434>

Locals:
r = nil
key = "DBM_ImportantMinDurationGlow"
(*temporary) = "_ProcGlowDBM_ImportantMinDurationGlow"
(*temporary) = "DBM_ImportantMinDurationGlow"
(*temporary) = nil
(*temporary) = nil
(*temporary) = "attempt to index local 'r' (a nil value)"
ProcGlowPool = <table> {
}

To Reproduce

  • use DBM 11.0.5-27-g9216200
  • go in a LFG dungeon (heroic mode - probably it can also happen in normal mode)

Which version of DeadlyBossMods are you using?
11.0.5-27-g9216200

Was it working in a previous version? If yes, which was the last good one?
not seen it before today

To fix error
at the berinning of the function lib.ProcGlow_Stop(r, key) (line 930) add the same lines as the earlier function lib.ProcGlow_Start(r, options) - these are missing here and i think are also needed

    if not r then
        return
    end
commented

also getting same error in another function now... this time in the Priory dungeon.
same type of fix applies: add a check for r being nil at the start of function lib.ButtonGlow_Stop(r)

901x ...BM-Core/Libs/LibCustomGlow-1.0-20/LibCustomGlow-1.0.lua:738: attempt to index local 'r' (a nil value)
[string "@DBM-Core/Libs/LibCustomGlow-1.0-20/LibCustomGlow-1.0.lua"]:738: in function `ButtonGlow_Stop'
[string "@DBM-Core/DBM-Nameplate.lua"]:431: in function `StopGlow'
[string "@DBM-Core/DBM-Nameplate.lua"]:462: in function <DBM-Core/DBM-Nameplate.lua:434>

Locals:
r = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = "attempt to index local 'r' (a nil value)"
ButtonGlowPool = <table> {
}