DBM - Deadly Boss Mods (DBM-Core)

DBM - Deadly Boss Mods (DBM-Core)

530M Downloads

Expand Upwards does not invert timer order (Sort by remaining time ON)

stoic-x opened this issue ยท 0 comments

commented

Describe the bug
When expand upwards is enabled, the shortest timer is now at the top since the last update. Previously the shortest timer would have been at the bottom.

Do you have an error log of what happened?
No

To Reproduce

  1. Ensure "Sort by remaining time" is enabled
  2. Start test bar
  3. Toggle Expand Upwards on and off and you will see the order never becomes inverted like it used to be

Did you try having DeadlyBossMods as the only enabled addon and everything else (especially something like ElvUI) disabled?
No

Which version of DeadlyBossMods are you using?
9.0.23

Was it working in a previous version? If yes, which was the last good one?
Yes. I have VODs that show the correct behavior as of 3/10/21 before updating to 9.0.23. However I'm not sure exactly which version I was using before.

Additional context
Making the following change fixed it for me and works when Expand Upwards is ON or OFF. I'm assuming the list is now inverted elsewhere so in the case of ExpandUpwards ON it was being inverted twice resulting in a no-op.

tsort(smallBars, function(x, y)
	if self.Options.ExpandUpwards then
		return x.timer < y.timer
	end
	return x.timer < y.timer
end)
tsort(smallBars, function(x, y)
	return x.timer < y.timer
end)