Decursive

Decursive

Addons
26M Downloads

Possible to disable blacklist?

Meivyn opened this issue · 3 comments

commented

Is this even possible with your current code?

Decursive/Dcr_Events.lua

Lines 779 to 792 in 5f9a738

if (auraTYPE_failTYPE == SPELL_FAILED_LINE_OF_SIGHT or auraTYPE_failTYPE == SPELL_FAILED_BAD_TARGETS) then
if not self.profile.DoNot_Blacklist_Prio_List or not self:IsInPriorList(self.Status.Unit_Array_UnitToGUID[self.Status.ClickedMF.CurrUnit]) then
self.Status.Blacklisted_Array[self.Status.ClickedMF.CurrUnit] = self.profile.CureBlacklist;
self:Debug("|cFFFF0000XXXXX|r |cFF11FF11Updating color of blacklist frame|r");
self:ScheduleDelayedCall("Dcr_Update"..self.Status.ClickedMF.CurrUnit, self.Status.ClickedMF.UpdateSkippingSetBuf, self.profile.DebuffsFrameRefreshRate, self.Status.ClickedMF);
end
self:SafePlaySoundFile(DC.FailedSound);
--[=[
elseif auraTYPE_failTYPE == SPELL_FAILED_BAD_IMPLICIT_TARGETS then
self:AddDebugText("ERR_GENERIC_NO_TARGET", "Unit:", self.Status.ClickedMF.CurrUnit, "UE:", UnitExists(self.Status.ClickedMF.CurrUnit), "UiF:", UnitIsFriend("player",self.Status.ClickedMF.CurrUnit), "CBEs:", timestamp, event, sourceGUID, sourceName, sourceFlags, destGUID, destName, destFlags, spellID, spellNAME, _spellSCHOOL, auraTYPE_failTYPE); --]=]
end

I don't get the point of that feature, and as a healer, I find it actually very annoying, I had to look into your code and disable that manually (but I'd rather have it fixed in the addon than do it every single update). I'd like to know if it could be possibly implemented in a future release.

My point is that I don't want Decursive to auto-blacklist people who are out of the line of sight, because I'd rather move and find them than let them "notice they have to move near me" and die from the debuff. I don't get the point of that feature honestly. Would appreciate it if you could explain a bit.

I would not mind making PR to make it at the very least configurable, but testing this stuff is actually not very straightforward.

commented

There is a "seconds on the blacklist" option in the General tab, now it can be set to 0 to effectively disable the blacklisting feature completely.
It can also be disabled by using the priority lists (there is an option to not blacklist units in the priority lists - in the curing options)

  • ❤️1
commented

This feature is a a legacy feature from the time when Decursive was a 'just smash the same button add-on' used in big 40 people raids groups where several players were removing debuffs at the same time so that it would not get stuck on out of sight targets. It was ported over as the idea was that one should not have to care about who each box is and just click each box.

I'm not sure if people rely on this feature, I'll add an option to disable it.

commented

We can't detect distance to other players inside instances anymore unfortunately, but maybe could just make it reset after a couple of seconds of trying?