Dejunk (Sell & Destroy Junk)

Dejunk (Sell & Destroy Junk)

1M Downloads

[Request] Search button for the Inclusion & Exclusion lists

zeenk opened this issue ยท 6 comments

commented

Now that we have Wowhead support from #197 I thought of another idea, lets say you run Naxx 25man normal every week on multiple alts to farm something you could use this filter https://www.wowhead.com/items?filter=148;3456;0 to import ALL items that drops from that raid & mode but since it's over 500 items and maybe there is some items that you want to keep it would be nice to have a search button added so we could quickly find those items and remove them from the list ๐Ÿ˜„

You could do something like this, I did a paint edit at the bottom of this post to show what it could look like in Dejunk with these suggestions added

Search bar that expands when you click on the search icon (from Bagnon)

2024-02-17_18-25-34.mp4

Update the list live as you start typing (from Stash)

2024-02-17_18-27-18.mp4

Example what it could look like in Dejunk: (could also move the 3 buttons a bit closer to each other so they don't take up as much space ^^)
2024-02-17_18-41-18
Or you can of course do it whichever way you think is best.

Alternative design that puts a search bar at the top of the list instead of blocking text in title when you click the search button
Edit

commented

This is a good idea; however, I don't imagine implementing something like this until I get around to refactoring the brittle UI code I've slapped together. It'll probably be a while.

commented

Sure no problem ๐Ÿ‘

commented

Awesome, thank you :)

commented

Thanks for the suggestions!

commented

I saw that you reworked the UI a bit, nice ๐Ÿ‘
If you still plan to add this search feature I tried to do a new design with the new UI, maybe something you like? (just some suggestions ^^)

  1. Have a toggle search icon top right next to keybinds button so you can show/hide the search bar (or you could just have it show all the time and no toggle button to hide it if you think it's good enough)
  2. Move the version display to top left so it's not overlapping with search bar.
  3. If it's possible you could make the search bar search in all the lists at the same time, otherwise maybe have a search icon in each list to "select this list for searching"

2024-05-03_20-48-08

commented

I had gotten a start on this idea:

image

But it might be better being able to search all lists at once, as you suggested. I'll play around with it and see what feels best.