Details! Damage Meter

Details! Damage Meter

250M Downloads

Details Show & Hide with ElvUI

magetower-rgb opened this issue · 15 comments

commented

I don't know which addon broke something (ElvUI Update or Details Update), but when ElvUI is enabled the Keybind for show & hide details doesnt work anymore.

It only works to hide it, but it can't be restored with the keybind again.
When i click on the minimap button with control + shift + left click it doent show, too.

I have to reloard the ui or go into the details option to show the window again.
I tried that on a new character too with a fresh ElvUI profile and no other addons enabled then details and elvui

commented

Can confirm, same issue here. Typing /details show works to bring it back, but the keybinding for ToggleWindows only hides.

commented

Same problem. Showing and hiding manually works, but toggling doesn't. The keybind for toggle hides but doesn't show windows, and /details toggle is the same. Only started happing since around the last reset (?)

I've tried reinstalling the latest version, and also resetting. No difference, and happens on all my characters. I don't use ElvUI.

commented

Same issue here. Don't use ElvUI. Before the recent update, I could use a macro with /details toggle to show/hide the Details window on each button press. Now it only hides it and doesn't show when I use the macro.

commented
commented

Game version: 8.3.7.35662
ElvUI: I don't use ElvUI
Details! version: 8.3.0.7356141

I see there is another update to Details named 8.3.0.7356141-a-geabba12-alpha, will try that and reply back with results.

commented

After installing Details! version 8.3.0.7356141-a-geabba12-alpha, same issue occurs. Details window shows up after logon, and the /details toggle command only hides the window, does not show it.

commented
commented

Here's the steps you can perform to recreate the issue:

1.) Delete all saved variables for Details! (account and character variables)
2.) Install latest version of Details!
3.) Launch WoW and log into your character.
4.) When Details! setup window appears, click the next arrow continuously leaving all settings default and finish the setup.
5.) Type /details toggle and hit enter, you will see the Details! window disappear.
6.) Type /details toggle and hit enter again, you won't see the Details! window appear...

commented

The issue is with the Ace libraries being updated in other addons. It is a conflict with those addons overriding the version of the Ace libraries that Details uses.

commented
commented

It is on any version afaik. But yes, there are reports in both classic and retail.

commented

Also affecting Classic. Though my issue has nothing to do with ElvUI. /details toggle will only hide the windows, not show, when I have either Masque or Gathermate2 enabled. I am using ElvUI as well, but that being enable or not doesn't matter.

Game version: 1.13.5.35753
ElvUI version (for reference since others seem to have issues related to this): 1.31 (90fe0bfe)
Details! version: DetailsClassic.1.13.5.213.142
Masque version: 8.3.0-classic
Gathermate2 version: 1.45.6-classic

commented

This is the issue: mixxorz/Glass#85

commented

The keybind for toggle hides but doesn't show windows after install last version Hekili (v8.3.7-01) and GatherMate2 (v1.45.6). Everything works with previous versions of these addons.

commented

As far as I can tell the problem happens because Details overrides one of the functions that AceAddon puts into the addon object - and when the library updates, it also updates the functions it put into addons - overriding your override.

One likely candidate is https://github.com/Tercioo/Details-Damage-Meter/blob/master/classes/classe_instancia.lua#L293 since AceAddon has an IsEnabled function. Having conflicting function names like this is likely the culprit.

You can of course resolve this temporarily by simply including the latest version of Ace3, since then it won't update itself. And AceAddon doesn't change that often to present a recurring problem. But in the long run something you might want to fix.