Arena enemy pet damage not captured
crudos opened this issue · 17 comments
Before Start!
Make sure the bug also happen when Details! is the only addon enabled.
Game and Details! version
WD 10736 RELEASE 10.0.7
Describe the bug
-
Steps to Reproduce (what did you do to make the bug happen):
Play an arena match against a pet heavy class (BM hunter/Demo lock) -
Result (what happens when you follow the steps above):
A large portion of their damage is missing from Details. Most obvious is BM hunter where Kill Command isn't being captured by the addon. -
Expected (what you think the expected behavior would be when following the steps):
I expect to see Kill Command for the enemy hunter in Details. There are potentially other abilities being filtered but I don't know the class enough. -
When the bug started (a date, wow path release, details update, etc)?
I believe this has been the case since DF has released -
Additional information:
Lua Error
Post here lua errors, if you aren't getting any, use /console scriptErrors 1
Screenshots
Post images of the bug if necessary.
Combat Log
Include a link to a combatlog file if the error is about not detecting a skill, usable item or item proc.
The log can be as simple as hitting a mob with white damage and using the item/skill.
Other Information
If necessary, add more info here.
Don't have screenshots right now but I'll add them once I get some recent examples.
Determining pet ownership and attributing it to the player is an adventure. Blizzard has no process to query ownership, so we use other methods if possible. One method we tend to use that is both reliable and slightly unreliable is using tooltips. Those generally give a GUID for the pet owner.
If you're able to, could you get a screenshot of the pet tooltip mid fight, and also if the issue happens can you see if the pet attacked first? It could be due to that as well, I'm not sure.
Here's a version that should give a lot of information. And by a lot of information I mean it will record how every single pet goes through the detection.
Should you encounter pets not showing with this, please report with /details version
and /details dumppets
Alrighty. I'm gonna add a bit more 'error checking' into a new version just for testing purposes. Stuff that would let me/you see the data after the fact. I'll post a zip here sometime soon with that version.
Not sure if the pet attacks first but the hunter stunned (Intimidation) someone first. As soon as the pets went to me and the hunter/pets did damage he appeared on Details!. But it appeared to happen at the same time besides the initial stun.
Also note that this is only for enemy hunters. When a hunter is on my side the damage seems to be shown correctly.
Damage taken for my character:
That would likely be the cause. Could you get a /combatlog
of an arena where this occurs?
I think these should be the right logs:
If you are able, could you test with the changes in #496
Can provide the files directly if you wish
And just to confirm you manually installed with the updated container_actors.lua file?
Yeah I just updated that 1 file that was changed and it seemed to update Demo lock damage
Edit: actually some of the demo damage may actually still be missing
Sorry I've been out for a couple weeks on vacation, I'll install this one and check out what happens next time I do arena.
It still doesn't appear to be tracking the pet damage fully. I tried /details dumppets
but it doesn't seem to do anything.