Details! Damage Meter

Details! Damage Meter

250M Downloads

inconsistent values with Dynamic Overall Damage, because the values get constantly updated out of combat

Undisclosed-Information opened this issue · 2 comments

commented

The values from a "Dynamic Overall Damage" window are constantly updated out of combat, resulting in a values constantly changing between [value] and [value + 1].

From function classCustom.UpdateBar#L511:

Image from Gyazo

As you can see, the value is getting rounded, resulting in the value constantly changing between 659 and 660.

Proposition

There is no need for a "Dynamic Overall Damage" window to be constantly updating the values out of combat.
Make it stop, when we are out of combat, reflecting the same output from "Damage Done Overall".

commented

All displays, including Dynamic Overall Damage, have their display code run every update interval. Combat or not.

commented

Ye I noticed, I can kinda fix it by making the "search code" of said script return nil when I'm out of combat. That way it doesnt wiggle between two values. Feels like a dirty hack tho... 😢