Details! Damage Meter

Details! Damage Meter

250M Downloads

TinyThreat does not respect the 'Show Percent' toggle in options.

Chalos-Atiesh opened this issue ยท 3 comments

commented

Before Start!

Make sure the bug also happen when Details! is the only addon enabled.
Yes.

Game and Details! version
Use /details to grab these two.
N/A

Describe the bug

  • Steps to Reproduce (what did you do to make the bug happen):
  1. Enable TinyThreat.
  2. Toggle 'Show Percent' off in the TinyThreat panel.
  3. Attack a mob.
  • Result (what happens when you follow the steps above):
    The percent threat is still shown.

  • Expected (what you think the expected behavior would be when following the steps):
    The percent threat should not be shown.

  • When the bug started (a date, wow path release, details update, etc)?
    I don't remember it ever respecting this option.

  • Additional information:

Lua Error
Post here lua errors, if you aren't getting any, use /console scriptErrors 1
N/A

Screenshots
Post images of the bug if necessary.
N/A

Combat Log
Include a link to a combatlog file if the error is about not detecting a skill, usable item or item proc.
The log can be as simple as hitting a mob with white damage and using the item/skill.
N/A

Other Information
If necessary, add more info here.

commented

I have a fix but not permission to push a branch.

commented

Create a fork, commit your changes and push them to your fork, and create a pull request to merge the changes.

commented

Here's the PR: #78