Details! Damage Meter

Details! Damage Meter

243M Downloads

Github Action trigger causes release on every commit

AySz88 opened this issue ยท 0 comments

commented

(This was discovered while investigating Advanced Death Logs issue #6, but appears to be distinct.)

The "Release AddOn" Github Action kicks off multiple releases when multiple commits are pushed, once for each individual commit, such as with the merge for Details.12820.159.

on:
push:
branches:
- master
tags:
- '**'

This appears to be interpreted as two separate triggers, one for the branch filter, and one for the tags filter.

In addition, for certain individual commits which are then tagged for release, this causes the action to be run twice: once because that commit was to the master branch, and then again when the commit gets a tag. In these cases, one the duplicate runs is aborted with a message about a "future tag".

If the intention was to only run when a tag is applied to the main branch, I found this Stack Overflow answer regarding how to configure release.yml.