BookUI Error with Libram Items

Question

BookUI Error with Libram Items

Haembina opened this issue 4 months ago · 5 comments

Haembina commented 4 months ago

Tested with:
Libram of Rumination
Libram of Constitution
Libram of Resilience
Libram of Voracity
Libram of Tenacity

Error from BugSack:

1x DialogueUI/Code/Book/BookUI.lua:928: attempt to compare nil with number
[string "@DialogueUI/Code/Book/BookUI.lua"]:928: in function GetCurrentPage' [string "@DialogueUI/Code/Book/BookUI.lua"]:1357: in function UpdatePagination'
[string "@DialogueUI/Code/Scroll/Scroll_EasySmooth.lua"]:151: in function SnapTo' [string "@DialogueUI/Code/Scroll/Scroll_EasySmooth.lua"]:156: in function ResetScroll'
[string "@DialogueUI/Code/Book/BookUI.lua"]:840: in function ResetScroll' [string "@DialogueUI/Code/Book/BookUI.lua"]:1257: in function RebuildContentFromCache'
[string "@DialogueUI/Code/Book/BookUI.lua"]:1487: in function `ShowUI'
[string "@DialogueUI/Code/Book/BookUI.lua"]:361: in function <DialogueUI/Code/Book/BookUI.lua:346>

Locals:
self = DUIBookFrame {
nodeignore = true
scrollFromOffetY = 15
widgetTheme = 4
textureFile = "DialogueUI/Art/Book/TextureKit-Metal.png"
CloseButton = Button {
}
textureKitID = 2
fontStringPool =

{
}
ContentFrame = Frame {
}
Header = Frame {
}
CopyTextButton = Button {
}
defaultOffsetX = -634.666667
SourceItemButton = Frame {
}
useTwoPieceBG = true
PixelSnapDisabled = true
defaultAnchor = "LEFT"
Footer = Frame {
}
ScrollFrame = ScrollFrame {
}
ScreenVignette = Texture {
}
texturePool =

{
}
scrollable = true
BackgroundPieces =

{
}
}
offset = 132.071143
maxPage = 4
pageOffset = nil
(for index) = 4
(for limit) = 1
(for step) = -1
page = 4
(*temporary) = nil
(*temporary) = Frame {
t = 0
needTurnBack = false
data =

{
}
fromContentIndex = 8
toContentIndex = 7
nextContentIsPageStart = true
fullyCached = true
identifier = "Item11732"
activeData =

{
}
}
(*temporary) = 4
(*temporary) = "attempt to compare nil with number"
Cache = Frame {
t = 0
needTurnBack = false
data =

{
}
fromContentIndex = 8
toContentIndex = 7
nextContentIsPageStart = true
fullyCached = true
identifier = "Item11732"
activeData =

{
}
}

Haembina · Answer 1 · 2024-12-01T09:52:40.000Z

this change in BookUI.lua seems to have fixed the issue:

function DUIBookUIMixin:GetCurrentPage()
-- ... (rest of the function code) ...

for page = maxPage, 1, -1 do
    pageOffset = Cache:GetPageStartOffset(page);
    if pageOffset and offset > pageOffset then  --  👈 Add 'pageOffset and' here
        return page
    end
end

-- ... (rest of the function code) ...

end

Peterodox · Answer 2 · 2024-12-01T15:18:51.000Z

Hi! Could you enable the Copy Text button in the addon Settings - UI, copy the raw text, and send it here? Any one of these books is fine.
I think something went wrong because these books have images and they may use a different syntax.

Haembina · Answer 3 · 2024-12-01T16:33:46.000Z

Hello, yea gladly Libram of Rumination [itemID:11732] 1 <The pages are covered in ancient elven runes.> The pages herein contain memories of events that transpired in the collection and creation of the reagents required to craft lesser arcanum. May our enemies never gain access to these libram. May I live to see the pallid light of the moon shine upon Quel'Thalas once again. May I die but for the grace of Kael'thas. May I kill for the glory of Illidan.

…

-Master Kariel Winthalus 2 <HTML> <BODY> <IMG src="Interface\Pictures\11733_blackrock_256"/> </BODY> </HTML> 3 <HTML> <BODY> <IMG src="Interface\Pictures\11733_blasted_256"/> </BODY> </HTML> 4 <HTML> <BODY> <IMG src="Interface\Pictures\11733_ungoro_256"/> </BODY> </HTML>

On Sun, Dec 1, 2024 at 4:19 PM Peter Yu ***@***.***> wrote: Hi! Could you enable the Copy Text button in the addon Settings - UI, copy the raw text, and send it here? Any one of these books is fine. I think something went wrong because these books have images and they may use a different syntax. — Reply to this email directly, view it on GitHub <#93 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ANUWJWCJVBUBAPFFKMS2SRL2DMSHBAVCNFSM6AAAAABSZPRQM6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKMBZHAYTENBQGE> . You are receiving this because you authored the thread.Message ID: ***@***.***>

Haembina · Answer 4 · 2024-12-01T16:34:11.000Z

[image: image.png]

…

On Sun, Dec 1, 2024 at 5:33 PM Haembina ***@***.***> wrote: Hello, yea gladly Libram of Rumination [itemID:11732] 1 <The pages are covered in ancient elven runes.> The pages herein contain memories of events that transpired in the collection and creation of the reagents required to craft lesser arcanum. May our enemies never gain access to these libram. May I live to see the pallid light of the moon shine upon Quel'Thalas once again. May I die but for the grace of Kael'thas. May I kill for the glory of Illidan. -Master Kariel Winthalus 2 <HTML> <BODY> <IMG src="Interface\Pictures\11733_blackrock_256"/> </BODY> </HTML> 3 <HTML> <BODY> <IMG src="Interface\Pictures\11733_blasted_256"/> </BODY> </HTML> 4 <HTML> <BODY> <IMG src="Interface\Pictures\11733_ungoro_256"/> </BODY> </HTML> On Sun, Dec 1, 2024 at 4:19 PM Peter Yu ***@***.***> wrote: > Hi! Could you enable the Copy Text button in the addon Settings - UI, > copy the raw text, and send it here? Any one of these books is fine. > I think something went wrong because these books have images and they may > use a different syntax. > > — > Reply to this email directly, view it on GitHub > <#93 (comment)>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/ANUWJWCJVBUBAPFFKMS2SRL2DMSHBAVCNFSM6AAAAABSZPRQM6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKMBZHAYTENBQGE> > . > You are receiving this because you authored the thread.Message ID: > ***@***.***> >

Peterodox · Answer 5 · 2024-12-02T12:17:23.000Z

Thanks :)
I've located the issue. It will be fixed in the next update and the images will be correctly displayed.

Share to