What happened?

Hello! I'm getting these errors after the recent update:

1x Diminish\Diminish-v2.5.0.lua:203: attempt to index field 'DEFAULT_SETTINGS' (a nil value)
[string "@diminish\Diminish-v2.5.0.lua"]:203: in function 'InitDB'
[string "@diminish\Diminish-v2.5.0.lua"]:232: in function <Diminish\Diminish.lua:231>
[string "=(tail call)"]: ?

1x Diminish\core\config.lua:48: bad argument #2 to 'format' (string expected, got nil)
[string "=[C]:"]: in function 'format'
[string "@diminish\core\config.lua"]:48: in main chunk

Locals:
(*temporary) = "Error: You're currently using the %s version of Diminish on a Retail client. You need to download the Retail version instead."
(*temporary) = nil
(*temporary) = "string expected, got nil"

I've updated with the Overwolf app, then manually from WoWInterface and Curse, by downlodaing the Diminish-v2.5.0.zip but that didn't solve the problem.

Thanks!

Is there any errors?

No response

Game Version

Retail

Game Language

English

Does the issue still occur when all other addons are temporarily disabled?

Yes, issue still occurs.

Any additional info?

Disabling all other addons doesn't help.

The actual first error for me is

1x Diminish\core\config.lua:50: bad argument #2 to 'format' (string expected, got nil)
[string "=[C]"]: in function `format'
[string "@Diminish\core\config.lua"]:50: in main chunk

Locals:
(*temporary) = "Error: You're currently using the %s version of Diminish on a TBC client. You need to download the TBC version instead."
(*temporary) = nil
(*temporary) = "string expected, got nil"

then the DEFAULT_SETTINGS one posted at the top, then a bunch of null errors

Playing on a BCC enUS client.

Same for me on Retail. I reverted back to prior version, issues gone.

It's a packager issue it's not excluding the

#@version-wrath@
## X-Expansion: 6
#@end-version-wrath@

from your .toc

But looking at the client detection in the lua file it's also problematic.

You want something like this instead to cover the case on PTR / Wrath Beta of not having a separate PROJECT_ID

    local tocVersion = select(4, GetBuildInfo())
    local isWotlk = tocVersion > 30000 and tocVersion < 40000 -- until / if we get a new PROJECT_ID
    local isClassic = WOW_PROJECT_ID == WOW_PROJECT_CLASSIC
    local isTBC = WOW_PROJECT_ID == (WOW_PROJECT_BURNING_CRUSADE_CLASSIC or 5) and not isWotlk
    local isRetail = WOW_PROJECT_ID == WOW_PROJECT_MAINLINE

    NS.IS_CLASSIC = isClassic
    NS.IS_CLASSIC_OR_TBC = isClassic or isTBC

Sorry been gone all day, will take a look now in a sec

NS.IS_CLASSIC_OR_TBC should really be NS.IS_NOT_CLASSIC or similar, just haven't renamed it yet. Had to do a quick hotfix yesterday to fix an issue with the embedded DRList-1.0 lib so things went a little quick :p

Edit: Seems like im still using packager v1 instead of v2, will re-deploy it asap.

Should be fixed now in v2.5.1 (tested classic+tbc, but not retail as i dont have it installed atm; let me know if there's any issues). Thanks for notifying.

PS: I don't have access to wotlk beta for testing so I won't be able to deploy for wrath yet.

The problem seems to be fixed for Retail now. Thanks!