Dominos

Dominos

19M Downloads

When using Masque with 'Pushed' color set, the color stays after the button is released

bady92 opened this issue ยท 7 comments

commented

Hi there, so I've fount this issue with Dominos and Masque that when you set 'Pushed' color in Maque and then use the ability that has the AoE circle via the mouse scroll it stays 'pushed' all the time untill you click on that button. It has been reported here https://github.com/StormFX/Masque/issues/9

Steps to replicate:
Bind a wheelDown or wheelUp to a button
Put spell with AoE circle targeting on that button
Use the bind

commented

Okay so apparently this only happens on DominosFrame2 and doesn't matter if the spell has AoE targetting or not

commented

I can repro it on bars 2 and 7-10, it works just fine on all the other ones

commented

I be its due to bar 2 being comprised of buttons Dominos has generated itself, and not the standard action bar ones. Do you experience similar behavior on bar 7, but not on bar 3?

commented

I've taken a closer look, and buttons which activate a targeting reticle are only receiving an OnMouseDown event and not an OnMouseUp event when pressing a hotkey. All other buttons are receiving both events.

This is only happening when ActionButtonUseKeyDown is set to 1, the default. Therefore, SurrogateButton:OnMouseDown() is being called to set the texture to PUSHED, but SurrogateButton:OnMouseUp() isn't being called to set the texture back to NORMAL.

A dirty workaround would be to type /console ActionButtonUseKeyDown 0 and then /reload, but this comes at the cost of less responsive spell casting.

commented

You'll probably need to listen for the "ACTIONBAR_UPDATE_STATE" event to fix the issue. Here's a working example which appears to resolve it: http://www.mergely.com/LsTRtkBs/

commented

This is also happening with Masque's Zoomed skin. It doesn't appear to be affecting DominosFrame1, only DominosFrame2 and potentially others which I haven't tested. It's only happening to spells with a targeting reticle, and only when they're activated using a key binding. Check out the attached screenshot:
9790fa

commented

I wonder if hooking/adding PostClick could accomplish the same thing without watching the event.