Dominos

Dominos

19M Downloads

Release V1.24 causing taint issues...

Twisthor opened this issue ยท 1 comments

commented

Dominos & Dominos_Config are the only active addons during the test.

From taint.log:

2/8 23:44:22.436 Global variable SHOW_MULTI_ACTIONBAR_3 tainted by Dominos - Interface\FrameXML\InterfaceOptionsPanels.lua:1179 InterfaceOptions_UpdateMultiActionBars()
2/8 23:44:22.436 *:OnLoad:4 setFunc()
2/8 23:44:22.436 Interface\FrameXML\InterfaceOptionsPanels.lua:1165
2/8 23:44:22.436 Execution tainted by Dominos while reading SHOW_MULTI_ACTIONBAR_3 - Interface\FrameXML\MultiActionBars.lua:60 MultiActionBar_Update()
2/8 23:44:22.436 Interface\FrameXML\InterfaceOptionsPanels.lua:1195 InterfaceOptions_UpdateMultiActionBars()
2/8 23:44:22.436 *:OnLoad:4 setFunc()
2/8 23:44:22.436 Interface\FrameXML\InterfaceOptionsPanels.lua:1165
2/8 23:44:22.436 An action was blocked in combat because of taint from Dominos - DominosActionButton25:SetAttribute()
2/8 23:44:22.436 Interface\AddOns\Dominos\actionBar.lua:158 DominosActionButton25:SetFlyoutDirection()
2/8 23:44:22.436 Interface\AddOns\Dominos\actionBar.lua:538 :UpdateFlyoutDirection()
2/8 23:44:22.436 Interface\AddOns\Dominos\actionBar.lua:290
2/8 23:44:22.436 :Play()
2/8 23:44:22.436 Interface\FrameXML\ActionButton.lua:402 ActionButton_ShowOverlayGlow()
2/8 23:44:22.436 Interface\FrameXML\ActionButton.lua:502 ActionButton_OnEvent()
2/8 23:44:22.436 DominosActionButton23:OnEvent()
2/8 23:44:22.436 An action was blocked in combat because of taint from Dominos - DominosActionButton26:SetAttribute()
2/8 23:44:22.436 Interface\AddOns\Dominos\actionBar.lua:158 DominosActionButton26:SetFlyoutDirection()
2/8 23:44:22.436 Interface\AddOns\Dominos\actionBar.lua:538 :UpdateFlyoutDirection()
2/8 23:44:22.436 Interface\AddOns\Dominos\actionBar.lua:290
2/8 23:44:22.436 :Play()
2/8 23:44:22.436 Interface\FrameXML\ActionButton.lua:402 ActionButton_ShowOverlayGlow()
2/8 23:44:22.436 Interface\FrameXML\ActionButton.lua:502 ActionButton_OnEvent()
2/8 23:44:22.436 DominosActionButton23:OnEvent()
2/8 23:44:22.436 An action was blocked in combat because of taint from Dominos - DominosActionButton27:SetAttribute()
2/8 23:44:22.436 Interface\AddOns\Dominos\actionBar.lua:158 DominosActionButton27:SetFlyoutDirection()
2/8 23:44:22.436 Interface\AddOns\Dominos\actionBar.lua:538 :UpdateFlyoutDirection()
2/8 23:44:22.436 Interface\AddOns\Dominos\actionBar.lua:290
2/8 23:44:22.436 :Play()
2/8 23:44:22.436 Interface\FrameXML\ActionButton.lua:402 ActionButton_ShowOverlayGlow()
2/8 23:44:22.436 Interface\FrameXML\ActionButton.lua:502 ActionButton_OnEvent()
2/8 23:44:22.436 DominosActionButton23:OnEvent()
2/8 23:44:22.436 An action was blocked in combat because of taint from Dominos - DominosActionButton28:SetAttribute()
2/8 23:44:22.436 Interface\AddOns\Dominos\actionBar.lua:158 DominosActionButton28:SetFlyoutDirection()
2/8 23:44:22.436 Interface\AddOns\Dominos\actionBar.lua:538 :UpdateFlyoutDirection()
2/8 23:44:22.436 Interface\AddOns\Dominos\actionBar.lua:290
2/8 23:44:22.436 :Play()
2/8 23:44:22.436 Interface\FrameXML\ActionButton.lua:402 ActionButton_ShowOverlayGlow()
2/8 23:44:22.436 Interface\FrameXML\ActionButton.lua:502 ActionButton_OnEvent()
2/8 23:44:22.436 DominosActionButton23:OnEvent()
2/8 23:44:22.436 An action was blocked in combat because of taint from Dominos - DominosActionButton29:SetAttribute()
2/8 23:44:22.436 Interface\AddOns\Dominos\actionBar.lua:158 DominosActionButton29:SetFlyoutDirection()
2/8 23:44:22.436 Interface\AddOns\Dominos\actionBar.lua:538 :UpdateFlyoutDirection()
2/8 23:44:22.436 Interface\AddOns\Dominos\actionBar.lua:290
2/8 23:44:22.436 :Play()
2/8 23:44:22.436 Interface\FrameXML\ActionButton.lua:402 ActionButton_ShowOverlayGlow()
2/8 23:44:22.436 Interface\FrameXML\ActionButton.lua:502 ActionButton_OnEvent()
2/8 23:44:22.436 DominosActionButton23:OnEvent()
2/8 23:44:22.436 An action was blocked in combat because of taint from Dominos - DominosActionButton30:SetAttribute()
2/8 23:44:22.436 Interface\AddOns\Dominos\actionBar.lua:158 DominosActionButton30:SetFlyoutDirection()
2/8 23:44:22.436 Interface\AddOns\Dominos\actionBar.lua:538 :UpdateFlyoutDirection()
2/8 23:44:22.436 Interface\AddOns\Dominos\actionBar.lua:290
2/8 23:44:22.436 :Play()
2/8 23:44:22.436 Interface\FrameXML\ActionButton.lua:402 ActionButton_ShowOverlayGlow()
2/8 23:44:22.436 Interface\FrameXML\ActionButton.lua:502 ActionButton_OnEvent()
2/8 23:44:22.436 DominosActionButton23:OnEvent()
2/8 23:44:22.436 An action was blocked in combat because of taint from Dominos - DominosActionButton31:SetAttribute()
2/8 23:44:22.436 Interface\AddOns\Dominos\actionBar.lua:158 DominosActionButton31:SetFlyoutDirection()
2/8 23:44:22.436 Interface\AddOns\Dominos\actionBar.lua:538 :UpdateFlyoutDirection()
2/8 23:44:22.436 Interface\AddOns\Dominos\actionBar.lua:290
2/8 23:44:22.436 :Play()
2/8 23:44:22.436 Interface\FrameXML\ActionButton.lua:402 ActionButton_ShowOverlayGlow()
2/8 23:44:22.436 Interface\FrameXML\ActionButton.lua:502 ActionButton_OnEvent()
2/8 23:44:22.436 DominosActionButton23:OnEvent()
2/8 23:44:22.436 An action was blocked in combat because of taint from Dominos - DominosActionButton32:SetAttribute()
2/8 23:44:22.436 Interface\AddOns\Dominos\actionBar.lua:158 DominosActionButton32:SetFlyoutDirection()
2/8 23:44:22.436 Interface\AddOns\Dominos\actionBar.lua:538 :UpdateFlyoutDirection()
2/8 23:44:22.436 Interface\AddOns\Dominos\actionBar.lua:290
2/8 23:44:22.436 :Play()
2/8 23:44:22.436 Interface\FrameXML\ActionButton.lua:402 ActionButton_ShowOverlayGlow()
2/8 23:44:22.436 Interface\FrameXML\ActionButton.lua:502 ActionButton_OnEvent()
2/8 23:44:22.436 DominosActionButton23:OnEvent()
2/8 23:44:22.436 An action was blocked in combat because of taint from Dominos - DominosActionButton33:SetAttribute()
2/8 23:44:22.436 Interface\AddOns\Dominos\actionBar.lua:158 DominosActionButton33:SetFlyoutDirection()
2/8 23:44:22.436 Interface\AddOns\Dominos\actionBar.lua:538 :UpdateFlyoutDirection()
2/8 23:44:22.436 Interface\AddOns\Dominos\actionBar.lua:290
2/8 23:44:22.436 :Play()
2/8 23:44:22.436 Interface\FrameXML\ActionButton.lua:402 ActionButton_ShowOverlayGlow()
2/8 23:44:22.436 Interface\FrameXML\ActionButton.lua:502 ActionButton_OnEvent()
2/8 23:44:22.436 DominosActionButton23:OnEvent()
2/8 23:44:22.436 An action was blocked in combat because of taint from Dominos - DominosActionButton34:SetAttribute()
2/8 23:44:22.436 Interface\AddOns\Dominos\actionBar.lua:158 DominosActionButton34:SetFlyoutDirection()
2/8 23:44:22.436 Interface\AddOns\Dominos\actionBar.lua:538 :UpdateFlyoutDirection()
2/8 23:44:22.436 Interface\AddOns\Dominos\actionBar.lua:290
2/8 23:44:22.436 :Play()
2/8 23:44:22.436 Interface\FrameXML\ActionButton.lua:402 ActionButton_ShowOverlayGlow()
2/8 23:44:22.436 Interface\FrameXML\ActionButton.lua:502 ActionButton_OnEvent()
2/8 23:44:22.436 DominosActionButton23:OnEvent()
2/8 23:44:22.436 An action was blocked in combat because of taint from Dominos - DominosActionButton35:SetAttribute()
2/8 23:44:22.436 Interface\AddOns\Dominos\actionBar.lua:158 DominosActionButton35:SetFlyoutDirection()
2/8 23:44:22.436 Interface\AddOns\Dominos\actionBar.lua:538 :UpdateFlyoutDirection()
2/8 23:44:22.436 Interface\AddOns\Dominos\actionBar.lua:290
2/8 23:44:22.436 :Play()
2/8 23:44:22.436 Interface\FrameXML\ActionButton.lua:402 ActionButton_ShowOverlayGlow()
2/8 23:44:22.436 Interface\FrameXML\ActionButton.lua:502 ActionButton_OnEvent()
2/8 23:44:22.436 DominosActionButton23:OnEvent()
2/8 23:44:22.436 An action was blocked in combat because of taint from Dominos - DominosActionButton36:SetAttribute()
2/8 23:44:22.436 Interface\AddOns\Dominos\actionBar.lua:158 DominosActionButton36:SetFlyoutDirection()
2/8 23:44:22.436 Interface\AddOns\Dominos\actionBar.lua:538 :UpdateFlyoutDirection()
2/8 23:44:22.436 Interface\AddOns\Dominos\actionBar.lua:290
2/8 23:44:22.436 :Play()
2/8 23:44:22.436 Interface\FrameXML\ActionButton.lua:402 ActionButton_ShowOverlayGlow()
2/8 23:44:22.436 Interface\FrameXML\ActionButton.lua:502 ActionButton_OnEvent()
2/8 23:44:22.436 DominosActionButton23:OnEvent()
2/8 23:44:22.436 An action was blocked in combat because of taint from Dominos - DominosActionButton13:SetAttribute()
2/8 23:44:22.436 Interface\AddOns\Dominos\actionBar.lua:158 DominosActionButton13:SetFlyoutDirection()
2/8 23:44:22.436 Interface\AddOns\Dominos\actionBar.lua:538 :UpdateFlyoutDirection()
2/8 23:44:22.436 Interface\AddOns\Dominos\actionBar.lua:290
2/8 23:44:22.436 :Play()
2/8 23:44:22.436 Interface\FrameXML\ActionButton.lua:402 ActionButton_ShowOverlayGlow()
2/8 23:44:22.436 Interface\FrameXML\ActionButton.lua:502 ActionButton_OnEvent()
2/8 23:44:22.436 DominosActionButton23:OnEvent()
2/8 23:44:22.436 An action was blocked in combat because of taint from Dominos - DominosActionButton14:SetAttribute()
2/8 23:44:22.436 Interface\AddOns\Dominos\actionBar.lua:158 DominosActionButton14:SetFlyoutDirection()
2/8 23:44:22.436 Interface\AddOns\Dominos\actionBar.lua:538 :UpdateFlyoutDirection()
2/8 23:44:22.436 Interface\AddOns\Dominos\actionBar.lua:290
2/8 23:44:22.436 :Play()
2/8 23:44:22.436 Interface\FrameXML\ActionButton.lua:402 ActionButton_ShowOverlayGlow()
2/8 23:44:22.436 Interface\FrameXML\ActionButton.lua:502 ActionButton_OnEvent()
2/8 23:44:22.436 DominosActionButton23:OnEvent()
2/8 23:44:22.436 An action was blocked in combat because of taint from Dominos - DominosActionButton15:SetAttribute()
2/8 23:44:22.436 Interface\AddOns\Dominos\actionBar.lua:158 DominosActionButton15:SetFlyoutDirection()
2/8 23:44:22.436 Interface\AddOns\Dominos\actionBar.lua:538 :UpdateFlyoutDirection()
2/8 23:44:22.436 Interface\AddOns\Dominos\actionBar.lua:290
2/8 23:44:22.436 :Play()
2/8 23:44:22.436 Interface\FrameXML\ActionButton.lua:402 ActionButton_ShowOverlayGlow()
2/8 23:44:22.436 Interface\FrameXML\ActionButton.lua:502 ActionButton_OnEvent()
2/8 23:44:22.436 DominosActionButton23:OnEvent()
2/8 23:44:22.436 An action was blocked in combat because of taint from Dominos - DominosActionButton16:SetAttribute()
2/8 23:44:22.436 Interface\AddOns\Dominos\actionBar.lua:158 DominosActionButton16:SetFlyoutDirection()
2/8 23:44:22.436 Interface\AddOns\Dominos\actionBar.lua:538 :UpdateFlyoutDirection()
2/8 23:44:22.436 Interface\AddOns\Dominos\actionBar.lua:290
2/8 23:44:22.436 :Play()
2/8 23:44:22.436 Interface\FrameXML\ActionButton.lua:402 ActionButton_ShowOverlayGlow()
2/8 23:44:22.436 Interface\FrameXML\ActionButton.lua:502 ActionButton_OnEvent()
2/8 23:44:22.436 DominosActionButton23:OnEvent()
2/8 23:44:22.436 An action was blocked in combat because of taint from Dominos - DominosActionButton17:SetAttribute()
2/8 23:44:22.436 Interface\AddOns\Dominos\actionBar.lua:158 DominosActionButton17:SetFlyoutDirection()
2/8 23:44:22.436 Interface\AddOns\Dominos\actionBar.lua:538 :UpdateFlyoutDirection()
2/8 23:44:22.436 Interface\AddOns\Dominos\actionBar.lua:290
2/8 23:44:22.436 :Play()
2/8 23:44:22.436 Interface\FrameXML\ActionButton.lua:402 ActionButton_ShowOverlayGlow()
2/8 23:44:22.436 Interface\FrameXML\ActionButton.lua:502 ActionButton_OnEvent()
2/8 23:44:22.436 DominosActionButton23:OnEvent()
2/8 23:44:22.436 An action was blocked in combat because of taint from Dominos - DominosActionButton18:SetAttribute()
2/8 23:44:22.436 Interface\AddOns\Dominos\actionBar.lua:158 DominosActionButton18:SetFlyoutDirection()
2/8 23:44:22.436 Interface\AddOns\Dominos\actionBar.lua:538 :UpdateFlyoutDirection()
2/8 23:44:22.436 Interface\AddOns\Dominos\actionBar.lua:290
2/8 23:44:22.436 :Play()
2/8 23:44:22.436 Interface\FrameXML\ActionButton.lua:402 ActionButton_ShowOverlayGlow()
2/8 23:44:22.436 Interface\FrameXML\ActionButton.lua:502 ActionButton_OnEvent()
2/8 23:44:22.436 DominosActionButton23:OnEvent()
2/8 23:44:22.436 An action was blocked in combat because of taint from Dominos - DominosActionButton19:SetAttribute()
2/8 23:44:22.436 Interface\AddOns\Dominos\actionBar.lua:158 DominosActionButton19:SetFlyoutDirection()
2/8 23:44:22.436 Interface\AddOns\Dominos\actionBar.lua:538 :UpdateFlyoutDirection()
2/8 23:44:22.436 Interface\AddOns\Dominos\actionBar.lua:290
2/8 23:44:22.436 :Play()
2/8 23:44:22.436 Interface\FrameXML\ActionButton.lua:402 ActionButton_ShowOverlayGlow()
2/8 23:44:22.436 Interface\FrameXML\ActionButton.lua:502 ActionButton_OnEvent()
2/8 23:44:22.436 DominosActionButton23:OnEvent()
2/8 23:44:22.436 An action was blocked in combat because of taint from Dominos - DominosActionButton20:SetAttribute()
2/8 23:44:22.436 Interface\AddOns\Dominos\actionBar.lua:158 DominosActionButton20:SetFlyoutDirection()
2/8 23:44:22.436 Interface\AddOns\Dominos\actionBar.lua:538 :UpdateFlyoutDirection()
2/8 23:44:22.436 Interface\AddOns\Dominos\actionBar.lua:290
2/8 23:44:22.436 :Play()
2/8 23:44:22.436 Interface\FrameXML\ActionButton.lua:402 ActionButton_ShowOverlayGlow()
2/8 23:44:22.436 Interface\FrameXML\ActionButton.lua:502 ActionButton_OnEvent()
2/8 23:44:22.436 DominosActionButton23:OnEvent()
2/8 23:44:22.436 An action was blocked in combat because of taint from Dominos - DominosActionButton21:SetAttribute()
2/8 23:44:22.436 Interface\AddOns\Dominos\actionBar.lua:158 DominosActionButton21:SetFlyoutDirection()
2/8 23:44:22.436 Interface\AddOns\Dominos\actionBar.lua:538 :UpdateFlyoutDirection()
2/8 23:44:22.436 Interface\AddOns\Dominos\actionBar.lua:290
2/8 23:44:22.436 :Play()
2/8 23:44:22.436 Interface\FrameXML\ActionButton.lua:402 ActionButton_ShowOverlayGlow()
2/8 23:44:22.436 Interface\FrameXML\ActionButton.lua:502 ActionButton_OnEvent()
2/8 23:44:22.436 DominosActionButton23:OnEvent()
2/8 23:44:22.436 An action was blocked in combat because of taint from Dominos - DominosActionButton22:SetAttribute()
2/8 23:44:22.436 Interface\AddOns\Dominos\actionBar.lua:158 DominosActionButton22:SetFlyoutDirection()
2/8 23:44:22.436 Interface\AddOns\Dominos\actionBar.lua:538 :UpdateFlyoutDirection()
2/8 23:44:22.436 Interface\AddOns\Dominos\actionBar.lua:290
2/8 23:44:22.436 :Play()
2/8 23:44:22.436 Interface\FrameXML\ActionButton.lua:402 ActionButton_ShowOverlayGlow()
2/8 23:44:22.436 Interface\FrameXML\ActionButton.lua:502 ActionButton_OnEvent()
2/8 23:44:22.436 DominosActionButton23:OnEvent()
2/8 23:44:22.436 An action was blocked in combat because of taint from Dominos - DominosActionButton23:SetAttribute()
2/8 23:44:22.436 Interface\AddOns\Dominos\actionBar.lua:158 DominosActionButton23:SetFlyoutDirection()
2/8 23:44:22.436 Interface\AddOns\Dominos\actionBar.lua:538 :UpdateFlyoutDirection()
2/8 23:44:22.436 Interface\AddOns\Dominos\actionBar.lua:290
2/8 23:44:22.436 :Play()
2/8 23:44:22.436 Interface\FrameXML\ActionButton.lua:402 ActionButton_ShowOverlayGlow()
2/8 23:44:22.436 Interface\FrameXML\ActionButton.lua:502 ActionButton_OnEvent()
2/8 23:44:22.436 DominosActionButton23:OnEvent()
2/8 23:44:22.436 An action was blocked in combat because of taint from Dominos - DominosActionButton24:SetAttribute()
2/8 23:44:22.436 Interface\AddOns\Dominos\actionBar.lua:158 DominosActionButton24:SetFlyoutDirection()
2/8 23:44:22.436 Interface\AddOns\Dominos\actionBar.lua:538 :UpdateFlyoutDirection()
2/8 23:44:22.436 Interface\AddOns\Dominos\actionBar.lua:290
2/8 23:44:22.436 :Play()
2/8 23:44:22.436 Interface\FrameXML\ActionButton.lua:402 ActionButton_ShowOverlayGlow()
2/8 23:44:22.436 Interface\FrameXML\ActionButton.lua:502 ActionButton_OnEvent()
2/8 23:44:22.436 DominosActionButton23:OnEvent()

commented

This is a safe amount of taint to have, I think. Its not ideal, sure, but its a bit of a pita to get action button reuse working and also using multi actionbars.