Dominos

Dominos

Addons
19M Downloads

Cooldown flash visible for hidden buttons when bar is not max length.

HonorWOW opened this issue ยท 0 comments

commented

Addon Version
8.3.12-Retail

World of Warcraft Version
Live

Steps to reproduce:

  1. Put spells in all 12 buttons of DominosFrame1.
  2. Using /dominos config, shrink the size of that bar below 12.
  3. Reload your UI.
  4. Cast a spell that triggers the GCD.

Expected behavior:

  1. No cooldown flash appears for buttons that are not visible on the bar.

Actual behavior:

  1. The cooldown flash is visible for each hidden slot in the bar.

If you resize the bar (causing buttons to be attached/detached), this works correctly, until your UI is reloaded again. I don't know the Dominos code well, but I managed to work around this by adding

if (type(self.MaxLength) == 'function' and (newNumButtons < self:MaxLength())) then
            for i = newNumButtons + 1, self:MaxLength() do
                self:AttachButton(i)
                self:DetachButton(i)

            end
end

to ReloadButtons in core/buttonBar.lua, after the Attach/Detach loops. It's a pretty jank fix, though.