Dominos

Dominos

19M Downloads

button grid slow response

Daenarys opened this issue · 7 comments

commented

The button grid has a slight delay in showing up when picking up action buttons from it, With Bartender4 it shows instantly (same as blizz default) and sometimes when you drag buttons to other slots you have to actually click the slot to place the button in it. I know you've tried fixing that before, but its still not working correctly.

Addon Version
10.0.16

World of Warcraft Version
Retail

commented

@Tuller been experimenting a bit with adding the ACTIONBAR_SHOWGRID and ACTIONBAR_HIDEGRID events to the action bar and calling SetShowGridInsecure, out of combat its as quick as bt4 and blizz, while in combat it doesnt work, so still have to use loadshowgridcontroller/secureenv which it luckily falls back to!

commented

Yeah the reason I had to use the secure stuff was to work around not being able to use the events in combat 😃

In classic, we are able to use that logic.

commented

Got it, but atleast it works as 'normal' out of combat using the event thing ^^
Also I tried it on BT4 and they have it working in combat with the events? how does that work? xD

commented

LibActionButton (which is what bartender uses internally) makes the buttons transparent instead of hiding them. It works visually, but you may notice that the area where empty buttons are isn’t clickable

commented

@Tuller Interesting! thanks for the info :)
So could you perhaps make the gridcontroller only work for when in combat since the events do work properly out of combat? or you're satisfied how it works now ?

commented

It's something to play around with. Typically, I'd want to avoid two code paths for the same thing.

commented

This should be faster in the 10.2.5 implementation