Dominos

Dominos

20M Downloads

Keybinding: primary and secondary buttons reversed after save/reload

speedwaystar opened this issue · 2 comments

commented

Addon Version
11.1.5-retail

World of Warcraft Version
Retail

example: setting keybinds for dominos action button 90 through 96

Image

after a reloadui, buttons 91 through 96 have their primary/secondary keybinds swapped

Image

the primary keybind is shown on the bar as an overlay, so after reloadui i see:

Image

instead of the desired

Image

curiously, reversing the order of the primary/secondary binds on buttons which have this issue makes no difference.

for example:
set primary 1, secondary 2, reloadui, result = 1, 2
set primary 2, secondary 1, reloadui, result = 1, 2

commented

looking in bindings-cache.wtf for the character in question, the observed behaviour is probably due to the kebyind's loading order. the first time a keybind is seen, it's assigned as primary. if a secondary bind to the same button is found, it's assigned to secondary.

i'm also guessing there's no API control over the order those values are written. :/

bind BUTTON3 ACTIONBUTTON6
bind W ACTIONBUTTON12
bind Q CLICK DominosActionButton57:LeftButton
bind E ACTIONBUTTON9
bind BUTTON4 ACTIONBUTTON7
bind F1 CLICK DominosActionButton85:HOTKEY
bind F2 CLICK DominosActionButton86:HOTKEY
bind F3 CLICK DominosActionButton87:HOTKEY
bind F4 CLICK DominosActionButton88:HOTKEY
bind F5 CLICK DominosActionButton89:HOTKEY
bind G ACTIONBUTTON11
bind F ACTIONBUTTON10
bind F8 CLICK DominosActionButton92:HOTKEY
bind F9 CLICK DominosActionButton93:HOTKEY
bind F10 CLICK DominosActionButton94:HOTKEY
bind F11 CLICK DominosActionButton95:HOTKEY
bind F12 CLICK DominosActionButton96:HOTKEY
bind SHIFT-G CLICK DominosActionButton95:HOTKEY
bind SHIFT-F CLICK DominosActionButton94:HOTKEY
bind BUTTON5 ACTIONBUTTON8
bind SHIFT-E CLICK DominosActionButton93:HOTKEY
bind SHIFT-BUTTON3 CLICK DominosActionButton90:HOTKEY
bind SHIFT-W CLICK DominosActionButton96:HOTKEY
bind F6 CLICK DominosActionButton90:HOTKEY
bind F7 CLICK DominosActionButton91:HOTKEY
bind SHIFT-BUTTON4 CLICK DominosActionButton91:HOTKEY
bind SHIFT-BUTTON5 CLICK DominosActionButton92:HOTKEY

after reordering these and making the kebyind file read-only, i can confirm that it (mostly) seems to be read-order bound -- so we're probably screwed.

if you can't think of a way to resolve this programmatically, feel free to close this ticket :/

my solution is to simply make the keys i want to see as button hints primary, and delete the secondary assignments

commented

You’re correct; not too much I can do here