Dragonflight UI Classic

Dragonflight UI Classic

285k Downloads

[BUG] lua error indexing removed globals in 1.15.4

juemrami opened this issue ยท 5 comments

commented

Describe the bug
Just a lua error, bug occurs on loading addon/logging in.

Versions (please complete the following information):
SoD 1.15.4 (currently on PTR)

Additional context
This is not on live, but currently open PTR for SoD. Didnt check non SoD servers, but i imagine the bug is there too.
Just thought id let ya know!

Error Log
1.

1x DragonflightUI/Modules/Minimap.lua:1253: attempt to index global 'MiniMapTrackingFrame' (a nil value)
[string "@DragonflightUI/Modules/Minimap.lua"]:1253: in function `updatePos'
[string "@DragonflightUI/Modules/Minimap.lua"]:1259: in function `ChangeTrackingEra'
[string "@DragonflightUI/Modules/Minimap.lua"]:1842: in function `Era'
[string "@DragonflightUI/Modules/Minimap.lua"]:650: in function <DragonflightUI/Modules/Minimap.lua:643>
[string "=[C]"]: ?
[string "@DragonflightUI/Libs/AceAddon-3.0-13/AceAddon-3.0.lua"]:66: in function <...ns/DragonflightUI/Libs/AceAddon-3.0/AceAddon-3.0.lua:61>
[string "@DragonflightUI/Libs/AceAddon-3.0-13/AceAddon-3.0.lua"]:523: in function <...ns/DragonflightUI/Libs/AceAddon-3.0/AceAddon-3.0.lua:516>
[string "=(tail call)"]: ?
[string "=(tail call)"]: ?
[string "@DragonflightUI/Modules/Config.lua"]:147: in function `ApplySettings'
[string "@DragonflightUI/Modules/Config.lua"]:114: in function <DragonflightUI/Modules/Config.lua:106>
[string "=[C]"]: ?
[string "@DragonflightUI/Libs/AceAddon-3.0-13/AceAddon-3.0.lua"]:66: in function <...ns/DragonflightUI/Libs/AceAddon-3.0/AceAddon-3.0.lua:61>
[string "@DragonflightUI/Libs/AceAddon-3.0-13/AceAddon-3.0.lua"]:523: in function `EnableAddon'
[string "@DragonflightUI/Libs/AceAddon-3.0-13/AceAddon-3.0.lua"]:536: in function `EnableAddon'
[string "@DragonflightUI/Libs/AceAddon-3.0-13/AceAddon-3.0.lua"]:626: in function <...ns/DragonflightUI/Libs/AceAddon-3.0/AceAddon-3.0.lua:611>

Locals:
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = "attempt to index global 'MiniMapTrackingFrame' (a nil value)"
1x DragonflightUI/Mixin/UI.mixin.lua:2642: attempt to index global 'ShowAllSpellRanksCheckBox' (a nil value)
[string "@DragonflightUI/Mixin/UI.mixin.lua"]:2642: in function `ChangeSpellbookEra'
[string "@DragonflightUI/Modules/UI.lua"]:276: in function `ApplySettings'
[string "@DragonflightUI/Modules/UI.lua"]:203: in function <DragonflightUI/Modules/UI.lua:190>
[string "=[C]"]: ?
[string "@DragonflightUI/Libs/AceAddon-3.0-13/AceAddon-3.0.lua"]:66: in function <...ns/DragonflightUI/Libs/AceAddon-3.0/AceAddon-3.0.lua:61>
[string "@DragonflightUI/Libs/AceAddon-3.0-13/AceAddon-3.0.lua"]:523: in function <...ns/DragonflightUI/Libs/AceAddon-3.0/AceAddon-3.0.lua:516>
[string "=(tail call)"]: ?
[string "=(tail call)"]: ?
[string "@DragonflightUI/Modules/Config.lua"]:147: in function `ApplySettings'
[string "@DragonflightUI/Modules/Config.lua"]:114: in function <DragonflightUI/Modules/Config.lua:106>
[string "=[C]"]: ?
[string "@DragonflightUI/Libs/AceAddon-3.0-13/AceAddon-3.0.lua"]:66: in function <...ns/DragonflightUI/Libs/AceAddon-3.0/AceAddon-3.0.lua:61>
[string "@DragonflightUI/Libs/AceAddon-3.0-13/AceAddon-3.0.lua"]:523: in function `EnableAddon'
[string "@DragonflightUI/Libs/AceAddon-3.0-13/AceAddon-3.0.lua"]:536: in function `EnableAddon'
[string "@DragonflightUI/Libs/AceAddon-3.0-13/AceAddon-3.0.lua"]:626: in function <...ns/DragonflightUI/Libs/AceAddon-3.0/AceAddon-3.0.lua:611>
commented

Should be all working again with #249, alpha is on its way to curseforge.

They changed lots of global names like ShowAllSpellRanksCheckBox to ShowAllSpellRanksCheckbox, or MiniMapTrackingFrame to MiniMapTracking.
Also some XML/mixin stuff got straight up deleted, even stuff they use in their own config screens, at least they did when I reverse engineered their code to make my own Dragonflight style settings. So maybe Cata gets changes soon too?

commented

Thanks for the info!
I'm working on a fix, and will push out an alpha version.

commented

I think they also changed some XML templates/mixins - my config screen errors there too now.

Edit: live => PTR are 815 files changed ๐Ÿ˜…

commented

Yea sometimes its best to wait a day or two, i noticed that when the base UI without any addons is throwing error then theyre likely to push some more changes soon that might mess up ur planned fixes.

commented

I found another issue:
They changed RunMacroText to C_Macro.RunMacroText, updated the documentation, but didn't update the one place it got used on secure actionbuttons, so now buttons with macrotext actions dont work, like the Era spellbook tabs for the profession screen.
At least its already reported: Stanzilla/WoWUIBugs#642

--
Also some issues with the profession screen, but I'm holding off working on it a few days, maybe blizzard fixes more stuff.