Dragonflight UI Classic

Dragonflight UI Classic

502k Downloads

[Feature Request] Separate "internal names" from "display names", add localization

ividyon opened this issue ยท 4 comments

commented

Hey,

I absolutely love your addon, but my big problem is that the German grammar, such as "Editmode" and "Actionbar" instead of "Edit Mode" and "Action Bar", and various inconsistencies in labels such as "Anchorframe", "AnchorParent", "Reverse Button order", "Always show Actionbar", "Hide Macro Text" etc are kind of breaking my experience a little.

I was going to contribute corrections to this, but I noticed that your internal code structure doesn't seem to have a separation between an "internal name" (such as ActionBar1) and a localized "display name" (such as "Action Bar 1"). This way, I can't really change those texts without breaking function. Also, if I change those texts, people's existing settings will be reset.

Could you separate these strings in the code? That way, I can make contributions, correct the texts, and make them fit with the Blizzard grammar and terms employed by the devs.

Precise example:

In the DragonflightUI options, users should be able to read "Action Bar 1" instead of "Actionbar1", without affecting functionality.

Likewise, it should also appear as "Action Bar 1" instead of "Actionbar1" to users in the Edit Mode.

Also, these strings should be localizable to other languages.

commented

For the record, I would gladly collaborate on fixing all the wonky text across the addon, and do all the work in making sure the addon is grammatically sound and the texts are all corresponding to Blizzard standards. What I'm asking here is some technical groundwork to allow it to happen.

commented

Hey,
most of the code and descriptions etc were temporary to get things going; I wasnt going to spend much time on good nameing when I dont know what I will keep long term.

But I'm already in the process of a complete rework of the settings, as I need to add more features, but it got increasingly annoying to do with the old structure. I'm also removing a lot of old/duplicated code, so things will be easier.
Localization is one of the last big features I will add before a 1.0 release, and with that I can review the naming etc. I already separated the display names more from the internal variable names, and I will refactor them into one big localization file.

>50% of the settings were duplicated code (e.g. scaling/position options, or actionbar buttons etc), but are now in reused tables; the old system would have been too much annoying work to copy/paste stuff, so I didnt bother really with localization, it was only used for some of the newer stuff.

Example:

Image

Image

I worked about 20 hours on it the last two days, and the structure is way better, and its easier to extend. I think the new system should be ready in a week, will post here when everything is refactored into the localization file.

commented

This all sounds excellent. Thank you very much for your continued work; your addon makes the Classic experience much, much nicer.

commented

I generated localization for the most used modules: #321, still need to add few minor things, and then consolidate some options as some strings are the same and used in more places.
Should all be ready to be worked with in like a week.

The file is quite big, will structure it more in the next days: https://github.com/Karl-HeinzSchneider/WoW-DragonflightUI/blob/main/Localization/enUS.lua