Dragonflight UI Classic

Dragonflight UI Classic

502k Downloads

[BUG] In Season of Discovery, opening a profession panel always shows the filters dropdown

akatechis opened this issue ยท 3 comments

commented

Describe the bug
It's not gamebreaking, but it's an annoyance that the filter dropdown is always visible when I open a profession window.

Error Log
No errors.

Versions (please complete the following information):

  • WoW: SoD
  • Addon: 0.20.5

Additional context
I did a bit of troubleshooting and searching around, and discovered this bit of code:

function DragonFlightUIProfessionCraftMixin:FilterDropdownRefresh()

function DragonFlightUIProfessionCraftMixin:FilterDropdownRefresh()
    -- TODO: find better way
    DragonFlightUIProfessionCraftMixin:ToggleFilterDropdown()
    DragonFlightUIProfessionCraftMixin:ToggleFilterDropdown()
    frameRef:CheckFilter()
end

I noticed that by commenting out the two calls to toggle the dropdown, the issue doesn't occur. However, I don't know what those two lines are meant to accomplish. I also don't know if something else should go in their place, or if it breaks other versions of the game like Cata, or something.

Image
commented

I'm using the old "easymenu" API from blizzard, and it had a few odd bugs. Since then they removed it, so I had to paste in some old blizzard code to get it working again.
I think those two lines fixed some bug where it wasnt rendering right and produced a few lua errors, so it got kinda "refreshed" with that.

I think next week I will rework the dropdown, and probably use the new dropdown API which is much better (used in the new settings dropdowns for example).

commented

Awesome! Thanks for all your work in this!

commented

Rework done: #346