Dragonflight UI Classic

Dragonflight UI Classic

502k Downloads

[BUG] DragonflightUI/Mixin/UI.mixin.lua:1032: bad argument #1 to 'strupper' (string expected, got nil)

psykzz opened this issue ยท 4 comments

commented

Describe the bug
Just spamming once we entered the 4 horsemen on SoD.

Error Log

12x DragonflightUI/Mixin/UI.mixin.lua:1032: bad argument #1 to 'strupper' (string expected, got nil)
[string "=[C]"]: in function `strupper'
[string "@DragonflightUI/Mixin/UI.mixin.lua"]:1032: in function <DragonflightUI/Mixin/UI.mixin.lua:1023>
[string "@DragonflightUI/Mixin/UI.mixin.lua"]:1053: in function <DragonflightUI/Mixin/UI.mixin.lua:1049>
[string "=[C]"]: ?

Locals:
(*temporary) = nil
(*temporary) = "string expected, got nil"

Versions (please complete the following information):

  • Classic wow (SOD)
commented

Hm, wild. The code where your error is, only gets used from the inspect frame when the inspect is ready:

Image
which calls this:
(line 10 here is line 1032 in the file)
Image

Not sure why this would happen on the 4hm fight, but I will just add some failsafe for that: 336401d.

Thanks for the report!
I will include this fix in the next version, probably on curseforge on sunday.

commented

I found that by selecting myself or another player it didn't seem to occur and only happened when i didn't have a target selected

Side note getting images of code like that is pretty cool ๐Ÿ‘€

commented

Side note getting images of code like that is pretty cool ๐Ÿ‘€

Haha, yeah they look nice! I figured you're a programmer yourself, so you might want to see why its wierd ๐Ÿ˜‚
And the screenshots look better than just plain code without syntax highlighting. (btw this is the Codesnap plugin for VSCode)

commented

I tend to use permalink but their not the easiest to setup.

InspectFrame:HookScript('OnEvent', function(self, event, unit, ...)
--
-- print('hookEvent', self:GetName(), event, unit, ...)
if event == 'INSPECT_READY' then
if InspectFrame and InspectFrame.unit then updateBackground(InspectFrame.unit) end
backgroundDesaturate(true)
end
end)