Dragonflight UI Classic

Dragonflight UI Classic

117k Downloads

Request: Bigdebuffs support

dabadoo opened this issue · 8 comments

commented

Would be awesome if we could get bigdebuffs support for the unitframes.

commented

Hey,
somebody also requested that a few weeks ago, so i took a look:
What from the addon isn't compatible?
I know the addon, but I'm not currently using it, so my quick test with default options:
image
Seems fine for me, but I'm not sure.

If something is buggy/off/not working, screenshots would be nice with a quick info how i can reproduce that. Most of my frames are default, only changed in size and textures, so most addons should be compatible (if they dont also change size, anchors etc)

commented

Classic SoD:
I log on my priest and target myself and then buff power word shield.
picture 1 casted PWS
Looks like it works. But then when I change target or just deselect myself, the aura on my player frame goes away.
picture 2 target someone else
The only thing remaining on my player icon is the cooldown text.
If I then retarget myself the aura on my player frame is still missing and only showing text
retarget myself

I also tried casting some CC on random mobs on my druid. I've previously experienced the same thing happening. The CC text duration appeared on the target mobs portrait but the aura icon didn't appear.
This "bug" did not happen from my quick test just now so I am unsure how to replicate it.

This might not just be a bigdebuff issue then. I think it also happned when I previously tested using LoseControl or ClassicAuraDurations for portrait auras. Sometimes it works but other times no icon appears and only text.

commented

hibernate
I tried disabling bidebuffs and enabled classucauradurations and the same thing happned. Text but no icon.
I then tried disabling this addon and with classicauradurations only and it worked as expected
Skærmbillede 2023-12-15 101034

Not getting any errors.

commented

Ah hmm. Im resetting some things on player/target frame after target change, because blizzard overrides a lot of stuff and this was a quick fix for the rare situations something got overriden, and also a way to fix everything when something unexpected happened.
I think the Icon in the portrait gets overriden because i also apply a different mask texture.
Should be possible to make that compatible, will have to look at their code to figure out how to keep the spell icons when I apply my changes.
Thanks for the report, the pictures are very helpful!

commented

I changed some more code, see #57 .
Seems to work like it should.

commented

Can you try to comment out line 2914 and 2916 in 'Modules/Unitframe.lua'?

function Module.RefreshPortrait()
    if UnitHasVehiclePlayerFrameUI('player') then
        -- SetPortraitTexture(PlayerPortrait, 'vehicle', true)
    else
        -- SetPortraitTexture(PlayerPortrait, 'player', true)
    end
end

Those two lines don't seem to really be neccessary, and in my quick test BigDebuffs works like expected, even when target switching. Only issue I found is that the playerframe sometimes refreshes and only show the number. But I guess the target frame is the important part. Will investigate more next week when I have more time.

commented

From just a very quick test it seems the issue described with PWS and switching target has been fixed.

The issue described here

hibernate
I tried disabling bidebuffs and enabled classucauradurations and the same thing happned. Text but no icon. I then tried disabling this addon and with classicauradurations only and it worked as expected Skærmbillede 2023-12-15 101034

Not getting any errors.

Still happens. I suppose it's not a bigdebuffs issue.

Seems good otherwise. 👍

commented

Had this happen yesterday:
Had FF on me. Appears on my player frame and target frame as expected.
picture 1
But then without me changing targets or anything. Somewhere between 6 and 5 seconds left of the FF debuff my player frame only displays time left
picture 2