DragonSpeedway_Music

DragonSpeedway_Music

364 Downloads

On race retry via item - no SFX nor music stop/restart

Shushuda opened this issue ยท 2 comments

commented

Blizz changed the way auras are handled during the race restart. Now the racing aura stays active when player clicks the item to restart the race. This means that there should be an additional check in handleAuraUpdate() to handle this situation. Currently the race start is handled by detecting the race aura's appearance. Since it's not removed, something else should be checked to see if the race got restarted.

Best way would be to trigger sounds and music on race countdown aura drop instead of race aura. Otherwise it would require a bit of if-ology to handle the corner cases.

What happens on race activation:

  • Race countdown aura appears and counts down.
  • Race countdown drops.
  • Race aura appears.

What happens on item click:

  • Race aura does NOT drop - it stays there.
  • Race countdown aura appears and counts down.
  • Race countdown drops.

TODO:

  • On addedAuras: Check for the appearance of race countdown aura.
  • If it's there, set raceCountdownInstanceID to its auraInstanceID.
  • On removedAuraInstanceIDs: Check for the removal of countdownRaceInstanceID.
  • If it's detected, run the code that handles race start - handleDragonRaceStart().
  • On addedAuras: Remove handleDragonRaceStart() from race start detection.
  • On addedAuras: Check if raceInstanceID is set.
  • If yes, then handle race restart to restart the music without some other random things - we don't need victory SFX to play for restart, for example.
commented

Holy shit, I need to add countdown spell IDs for the Reverse races. It's so many... UGHHHHHHH

commented

Done.