DruidMacroHelper

DruidMacroHelper

30k Downloads

HS and POT macro work for cat but not bear

OnceWasPerfect opened this issue ยท 7 comments

commented

I have a macro

#showtooltip
/click dmhStart
/dmh cd hs pot
/use Charged Crystal Focus
/use Healing Potion Injector
/click dmhEnd

If i use it in cat it works as intended, but dire bear pops me to human form.

Running /dmh debug I get the following doing both cat and dire bear

Slash command called: start
Slash command called: cd hs pot
Slash command called: end
Enabling autoUnshift again...
Resetting SpellQueueWindow to 400

Edit: Think i found the issue. On line 329 of DruidMacroHelper.lua it reads
spellBear = L["FORM_BEAR"];

I changed it to
spellBear = L["FORM_DIRE_BEAR"];

And it seems to work.

commented

You are using the alpha release I assume. You may want to set your addon updater to only download full releases. What language is your client?

commented

Sorry should have included the build, its DruidMacroHelper-1.2.1-10-gdaa2a67-bcc.zip. And client is in English. I'm sure I broke your regular bear form vs dire bear form check, and I think there is more to it because I wasn't getting that behavior on my ironskin pots or seeds, just the hs / health pot macro. I did try and remove the healing pot part of so its just healthstone and still got the same behavior.

commented

Hmm.. for me everything looks okay. Can you check the output of /dmh debug in the latest version? It should look like this:

Screenshot_20220526_142132

If it does not (you have [bar:2]!Bear Form; instead of [bar:2]!Dire Bear Form;) can you check what the following scripts return?

/script print(not GetSpellInfo("Dire Bear Form"))
/script print(not GetSpellInfo("Bear Form"))

The first should return false and the second true. If that is the case can you check whether /script DruidMacroHelper:UpdateForms() fixes the issue?

commented

It shows [bar:2]!Dire Bear Form; and all seems to be working correctly in this version.

commented

Strange, I did not change anything related to that issue in the current version. I only added some debugging information. Maybe it is an edge case (race-condition when loading the interface for example) that causes it. Calling DruidMacroHelper:UpdateForms() on PLAYER_ENTERING_WORLD probably is a good idea.

commented

I made those changes, so hopefully that issue should not occur anymore with the latest version

commented

Awesome, i'll grab the new version. Thanks for all the work!