Edit Mode Expanded

Edit Mode Expanded

662k Downloads

Adding new Tracked Buffs doesn't work

Closed this issue ยท 6 comments

commented

There are some issues with editing the "Tracked Buffs" frame of the new Cooldown Manager:

  • adding new spells just doesn't work - while it adds the spell and shows it in the grid, the actual icon never shows even if buff is active

Image

  • there is no way to stretch the frame - it just limits you to 3 icons per row / column, which messes the layout (I understand that this could be a Blizzard limitation which is not possible to change atm, but still worth mentioning)
commented

After the new update the row expands now, thanks!
The issue still persists with the buff though - it's still not showing.

Also, there's a lot of Lua errors now:

411x C stack overflow
[C]: in function 'GetPlayerAuraBySpellID'
[EditModeExpanded/FrameHandlers/CooldownManager.lua]:302: in function <...s/EditModeExpanded/FrameHandlers/CooldownManager.lua:296>
[C]: ?
[C]: ?
[C]: ?
[C]: ?
[C]: ?
[C]: ?
[C]: ?
[C]: ?
[C]: ?
[C]: ?
...[Blizzard_CooldownViewer/CooldownViewer.lua]:100: in function 'OnCooldownIDSet'
[Blizzard_CooldownViewer/CooldownViewer.lua]:854: in function 'OnCooldownIDSet'
[Blizzard_CooldownViewer/CooldownViewer.lua]:80: in function 'SetCooldownID'
[EditModeExpanded/FrameHandlers/CooldownManager.lua]:493: in function <...s/EditModeExpanded/FrameHandlers/CooldownManager.lua:483>
[C]: in function 'RefreshData'
[Blizzard_CooldownViewer/CooldownViewer.lua]:1454: in function 'UpdateShownState'
[Blizzard_CooldownViewer/CooldownViewer.lua]:1311: in function 'OnEvent'
[Blizzard_CooldownViewer/CooldownViewer.lua]:1774: in function 'OnEvent'
[Blizzard_CooldownViewer/CooldownViewer.lua]:1805: in function <...ceBlizzard_CooldownViewer/CooldownViewer.lua:1804>
[C]: ?

Locals:
(*temporary) = "C stack overflow"
(*temporary) = "C stack overflow"
commented

@teelolws issue probably needs to be reopened due to this? Or I can create a new one if needed

commented

Unfortunately there isn't much in that error log to point me to why its happening. I'll have to keep trying to reproduce the error.

commented

If it helps, I've added spells Bulletstorm 389019 and Razor Fragments 384790 on my hunter to the Tracked Buffs active list.
I can also send you my Edit Mode profile.

commented

Well, it seems that I've solved the issue, and it was totally my fault.
Turns out that the actual buff ID's are 389020 and 388998 respectfully - not the same ID's that I got from the talent page.

After clearing up BugSack reports it seems that the Lua error is also gone, so that was probably connected to the wrong ID's as well.
Sorry for confusion and thanks again for your awesome work!

commented

Okay. I'll have to find some way to prevent the error though.