ElvUI Enhanced Again (DF)

ElvUI Enhanced Again (DF)

1M Downloads

New error since Elvui Updates

Cataking opened this issue ยท 4 comments

commented

2x ElvUI/Core/General/Core.lua:379: attempt to call local 'func' (a boolean value) [string "@ElvUI/Core/General/Core.lua"]:379: in function ValueFuncCall'
[string "@ElvUI/Core/General/Core.lua"]:331: in function UpdateMedia' [string "@ElvUI/Core/General/Core.lua"]:1949: in function <ElvUI/Core/General/Core.lua:1915> [string "=[C]"]: ? [string "=[C]"]: in function Initialize'
[string "@ElvUI/Core/init.lua"]:223: in function <ElvUI/Core/init.lua:222>
[string "=[C]"]: ?
[string "@Ace3/AceAddon-3.0-13/AceAddon-3.0.lua"]:66: in function <Ace3/AceAddon-3.0/AceAddon-3.0.lua:61>
[string "@Ace3/AceAddon-3.0-13/AceAddon-3.0.lua"]:523: in function EnableAddon' [string "@Ace3/AceAddon-3.0-13/AceAddon-3.0.lua"]:626: in function <Ace3/AceAddon-3.0/AceAddon-3.0.lua:611> [string "=[C]"]: in function LoadAddOn'
[string "@FrameXML/UIParent.lua"]:538: in function UIParentLoadAddOn' [string "@FrameXML/UIParent.lua"]:743: in function MajorFactions_LoadUI'
[string "@Blizzard_ExpansionLandingPage/Blizzard_DragonflightLandingPage.lua"]:100: in function SetUpMajorFactionList' [string "@Blizzard_ExpansionLandingPage/Blizzard_DragonflightLandingPage.lua"]:93: in function RefreshMajorFactionList'
[string "@Blizzard_ExpansionLandingPage/Blizzard_DragonflightLandingPage.lua"]:88: in function RefreshOverlay' [string "@Blizzard_ExpansionLandingPage/Blizzard_DragonflightLandingPage.lua"]:80: in function <...sionLandingPage/Blizzard_DragonflightLandingPage.lua:76> [string "=[C]"]: in function CreateFrame'
[string "@Blizzard_ExpansionLandingPage/Blizzard_DragonflightLandingPage.lua"]:49: in function CreateOverlay' [string "@Blizzard_ExpansionLandingPage/Blizzard_ExpansionLandingPage.lua"]:63: in function RefreshExpansionOverlay'
[string "@Blizzard_ExpansionLandingPage/Blizzard_ExpansionLandingPage.lua"]:35: in function <...pansionLandingPage/Blizzard_ExpansionLandingPage.lua:33>`

commented

I am by no means a programmer, but after reading one of the thread on the ElvUI github about this issue, there was a change made to the ValueColorUpdate function. Making the changes below cleared the errors for me.

File: ElvUI_Enhanced\modules\datatexts\range.lua
Line 52: Change from local function ValueColorUpdate(hex, r, g, b) to local function ValueColorUpdate(self, hex, r, g, b)
Line 59: Comment out with --

as mentioned, I am not a programmer so I will let the devs on this project review, but so far so good.

commented

This fixed it beautifully for me as well, ty!

commented

I had this issue too, it seems that as of 3.18, the structure of valueColorUpdateFuncs changed enough to break ElvUI_Enhanced. I'm not sure if this preserves the functionality of it, but it seemed to remove the errors for me:
Go to the file:

ElvUI_Enhanced/modules/datatexts/range.lua

and change lines 52 and 59 to be:

local function ValueColorUpdate(_, hex, r, g, b)


E.valueColorUpdateFuncs.RangeEnhanced = ValueColorUpdate

That should make it at least follow the same new structure, but I'm unsure if the function's behaviour needs to be adjusted as well (This just changes the way it gets into the valueColorUpdateFuncs variable, and allows it to follow the new set of arguments).

Just commenting out line 59 would make the range display be completely disabled.

commented

Duplicate as #153