ElvUI Enhanced Again (DF)

ElvUI Enhanced Again (DF)

1M Downloads

LUA Error with elvui 10.88

Moowalker opened this issue ยท 8 comments

commented

Describe the bug
After installing ELvUI 10.88 I get the following LUA errors from the addon:
3x ...ddOns\ElvUI_Enhanced\modules\tooltip\progression.lua:151: hooksecurefunc(): ShowInspectInfo is not a function [C]: in function hooksecurefunc'
...ddOns\ElvUI_Enhanced\modules\tooltip\progression.lua:151: in main chunk

Locals:
`

3x ElvUI\core\toolkit.lua:65: attempt to perform arithmetic on local 'xOffset' (a string value) ElvUI\core\toolkit.lua:65: in function SetOutside'
ElvUI\core\toolkit.lua:176: in function CreateShadow' ...I_Enhanced\modules\unitframes\construct_elements.lua:35: in function Construct_HealGlow'
...ddOns\ElvUI_Enhanced\modules\unitframes\healglow.lua:83: in function ?' ...ies\Ace3\CallbackHandler-1.0\CallbackHandler-1.0-7.lua:119: in function <...ies\Ace3\CallbackHandler-1.0\CallbackHandler-1.0.lua:119> [C]: ? ...ies\Ace3\CallbackHandler-1.0\CallbackHandler-1.0-7.lua:29: in function <...ies\Ace3\CallbackHandler-1.0\CallbackHandler-1.0.lua:25> ...ies\Ace3\CallbackHandler-1.0\CallbackHandler-1.0-7.lua:64: in function Fire'
...s\ElvUI\Libraries\Ace3\AceEvent-3.0\AceEvent-3.0-4.lua:120: in function <...s\ElvUI\Libraries\Ace3\AceEvent-3.0\AceEvent-3.0.lua:119>`

Version (please complete the following information):

  • Version ElvUI 10.88
  • Version Elvui_Enhanced 3.5.5-beta1
commented

Hi! I also got the same LUA Errors along with a few nulls. Did some digging and found the folks with ElvUI changed a few of the functions which led to these. As a workaround, you can make the following minor changes to the ElvUI_Enhanced lua files.

  1. In ElvUI_Enhanced\modules\tooltip\progression.lua, on line 151 change:
    hooksecurefunc(TT, 'ShowInspectInfo', function(self, tt, unit, level, r, g, b, numTries)
    To:
    hooksecurefunc(TT, 'AddInspectInfo', function(self, tt, unit, level, r, g, b, numTries)

  2. In ElvUI_Enhanced\modules\unitframes\construct_elements.lua, on line 35 change:
    frame:CreateShadow('Default')
    To:
    frame:CreateShadow()

This should eliminate the LUA errors and allow you to use ElvUI v10.88 with ElvUI_Enhanced until an official update is made available.

Hope this helps!!

commented

@Kimbosaur - Would you verify that you made the second edit:

  1. In ElvUI_Enhanced\modules\unitframes\construct_elements.lua, on line 35 change:
    frame:CreateShadow('Default')
    To:
    frame:CreateShadow()

Basically the ElvUI devs changed the CreateShadow function to be a bit more dynamic, so it is now expecting an integer value (if any) rather than the string value of 'Default'. By removing that from the function call, you'll correct the error.

commented

Thanks for te responses! I'll check it out tonight and will push an update asap!

commented

I can verify that the changes proposed my @Nujitsu works.

commented

@Nujitsu First off thanks for the assist with this. However I am still getting errors as follows:

ElvUI\core\toolkit.lua:65: attempt to perform arithmetic on local 'xOffset' (a string value) ElvUI\core\toolkit.lua:65: in functionSetOutside'
ElvUI\core\toolkit.lua:176: in function CreateShadow' ...I_Enhanced\modules\unitframes\construct_elements.lua:35: in function Construct_HealGlow'
...ddOns\ElvUI_Enhanced\modules\unitframes\healglow.lua:83: in function ?' ...ibDataBroker\CallbackHandler\CallbackHandler-1.0-7.lua:119: in function <...ibDataBroker\CallbackHandler\CallbackHandler-1.0.lua:119> [C]: ? ...ibDataBroker\CallbackHandler\CallbackHandler-1.0-7.lua:29: in function <...ibDataBroker\CallbackHandler\CallbackHandler-1.0.lua:25> ...ibDataBroker\CallbackHandler\CallbackHandler-1.0-7.lua:64: in function Fire'
...ddOns\AuctionLite\Libs\AceEvent-3.0\AceEvent-3.0-4.lua:120: in function <...ddOns\AuctionLite\Libs\AceEvent-3.0\AceEvent-3.0.lua:119>`

Any ideas on how to patch these?

Thanks in advance

commented

New version with this fix is uploaded to curse. So the new version should be up soon! Thanks for the report and the help.

commented

@Nujitsu Odd. I checked the file and it was as you said it should be. This time, however, I copied your code text over the existing and not it's working.
Thanks again for the fix!!

commented

It may not matter, but the number and order of arguments in Nujitsu's HookSecureFunc fix is incorrect. The new line should be

hooksecurefunc(TT, 'AddInspectInfo', function(self, tt, unit, numTries, r, g, b)