Stuttering out of combat with certain buffs
Defmaster opened this issue ยท 8 comments
Describe the bug
When out of combat the game begins to stutter, when you have a buff which changes the secondary stats (e.g. Void Ritual corruption effect, Overwhelming Power azerite trait)
I could identify that the problem is the constant update in: paperdoll.lua
Line 290-29
PD:RegisterEvent("COMBAT_RATING_UPDATE", "UpdatePaperDoll", false)
PD:RegisterEvent("MASTERY_UPDATE", "UpdatePaperDoll", false)
I don't know if the events are even needed for the paperdoll update. The problem here is, that with every triggered event the itemlevel on sheet gets update (Line 83-102) which costs massive cpu cycle.
This only happens out of combat as the paperdoll update is prevented if in combat.
To Reproduce
Steps to reproduce the behavior:
Get buff from e.g. Void Ritual on dummy. Leave combat when stacking buff is triggered. Watch stutter until buff drops.
Expected behavior
No stuttering ;-)
Version (please complete the following information):
- Version ElvUI [11.311]
- Version Elvui_Enhanced [3.4.1]
Additional context
I commented both mentioned lines out and the stuttering disappeared and noticed no malfunction so far.
I have this same issue, it's damn near gotten me killed while questing. In pvp BGs with loads of people it nearly crashes wow the spluttering is so bad lol.
Until it's fixed by the original author you can just go to:
...\Interface\AddOns\ElvUI_Enhanced\modules\misc\paperdoll.lua
Line 290 and 291
PD:RegisterEvent("COMBAT_RATING_UPDATE", "UpdatePaperDoll", false)
PD:RegisterEvent("MASTERY_UPDATE", "UpdatePaperDoll", false)
And delete those lines. There was no drawback in doing so.
Or in Option you disable the itemlevel display on charactersheet, but with the method mentioned above you still got the item level display AND no stuttering.
I've pushed the update. For now I don't see any reason to keep:
PD:RegisterEvent("COMBAT_RATING_UPDATE", "UpdatePaperDoll", false) PD:RegisterEvent("MASTERY_UPDATE", "UpdatePaperDoll", false)
I would like to rewrite the whole module... but time.... :)
Cool, thank you :D
It's not showing up on Twitch or the Tuk client yet, how do I update it?
mmm, it should. I see the github tag isn't being pickedup by curse. I'll look into it.
I've pushed the update. For now I don't see any reason to keep:
PD:RegisterEvent("COMBAT_RATING_UPDATE", "UpdatePaperDoll", false)
PD:RegisterEvent("MASTERY_UPDATE", "UpdatePaperDoll", false)
I would like to rewrite the whole module... but time.... :)