ElvUI ItemCount

ElvUI ItemCount

221k Downloads

Leaking Globals

Azilroka opened this issue ยท 4 comments

commented

You leak and pollute WoW's global space.. Which can lead to breaking your own addon if other people leak globals as well. If you need some help sorting it out hit up the Tukui, WoWUIDev or WoW AddOns discords.

commented

Thank you for the comment. I would like to make my addon a better citizen of the ElvUI community. Could you provide a specific example, please, that you have observed happening as a result of this addon?

commented

Thank you, I will correct that asap

commented

I've uploaded a new version - please verify the changes are appropriate and re-open if not satisfied. Thanks again

commented

All the color constants at the top.. you are also globalling E, L, V, P, G. Several functions are global.