Description

When breaking the urns (Ashen Phylacteries) in Torghast/Sanctum of Domination, there is a severe lag spike.

Shadow & Light Version

4.24

ElvUI Version

12.34

Steps to Reproduce

1. Enter Torghast
2. Break urn using the right click function
3. Lag Spike

Expected Behavior

Actual Behavior

Lag spike

ElvUI + S&L Enabled

Yes

Yes

Only ElvUI Enabled

No

No

Additional Information

I can only reproduce the error when S+L is enabled.

Error Log

Ok if you want to try something, try the change i did in commit 67ce58b
This might be a bit more helpful as now when that event fires, it wont update if u are in combat or if the window isnt shown, this way u will have to be out of combat and showing the window for it to run... so now when u break them, if ur window isnt open it wont run the update then.

Very weird. I created a completely new ElvUI profile --> Lags gone. Started to import ElvUI (via module control from the profile thatis lagging) sections one by one --> Lags still gone. Started to import S&L sections one by one --> Lags are still gone. Played around a little bit --> Lags are back. Clicked "reset all" in S&L options only --> Lags are gone again. Imported all S&L config section one by one, but all in a row --> Lags are gone. Waited 5 min --> Lags are back. Disabled AFK Mode and Armory Mode, /re, waited 5 min --> Lags are still gone. Activated my lagging profile, deactivated AFK Mode and Armory Mode --> Lags still gone, waited 5 min --> Lags also gone. Re-Activated Armory Mode, waited 5 min --> Lags still gone.
Result: It's the AFK Mode!

ill have to do some testing on it but it shouldnt be an issue but i can double check it later. I need you to provide info though... can u post post a pic of /estatus

also, did you test with ONLY ElvUI, ElvUI_OptionsUI, S&L no other addon regardless if you think its an issue or not (i have to specify this b/c someone usually will say, well i only have this or this and it shouldnt matter... it matters though lol)

Sorry for the confusion. It's the armory mode, 100%: See here

Yes, I am testing with /slerror on. But I think it's not AFK Mode after all. I just did some more tests and changing the AFK Mode setting didn't change anything. BUT, I am absolutely unable to reproduce the lags after I reset the settings of S&L. So it has to be some setting.

Maybe is has something to do with character stats? At least that would make sense because it could be something that gets triggered when combat starts.

It's this function in shadow-and-light/ElvUI_SLE/modules/armory/armory.lua:

function Armory:UpdateCharacterInfo(event)
	if event == "CRITERIA_UPDATE" and InCombatLockdown() then
		return
	end

	if E.db.sle.armory.character.enable then
		M:UpdatePageInfo(_G["CharacterFrame"], "Character")
	end
	if not E.db.general.itemLevel.displayCharacterInfo then
		M:ClearPageInfo(_G["CharacterFrame"], "Character")
	end
end

When breaking Ashen Phylacteries or engaging combat the InCombatLockdown flag is false. Hence, breaking 6-7 Ashen Phylacteries causes this function to be called around 25 times at once, which will then call both UpdatePageInfo and ClearPageInfo, depending on the settings and that causes a massive lag.
If I comment out line 641 in this file, which is:

		Armory:RegisterEvent("CRITERIA_UPDATE", "UpdateCharacterInfo")

the lags disappear.

sounds good ill look at it when i get home in a bit and do some kind of protection

I have the exact same issue and just figured out it's caused by S&L. It's not only Ashen Phylacteries for me, also noticable when I hit 3+ mobs with an arcane explosion on my mage. Not consistent though, sometimes weaker sometimes worse. Ashen Phylacteries basically stops the game for half a second, those are really the extreme case. 100% reproducable with /slerror on. Not happening with only elvui enabled.
Here is a video showing the issue. Look at the huge lag at around 9 seconds. I went through the frames in Premiere Pro and I'd say the game freezes for around 100ms.

@slannik Did you ever solve this with a new profile for example or did you just stop using S&L?

Yeah I am not sure how breaking them could do it, I would def try a new profile as a test. I am redoing a good amount of S&L which hopefully i will be done soon but doing it when i get time here and there (i havent pushed any of it to the dev branch, everything is still local)

We have no bearing on what happens when you right click on those and I have tested even with multiple addons and cant get any issues to "appear". I have heard issues with the empowerment crap but again S&L doesnt have anything to do with those. Unless you can narrow down a specific option that "may" cause your issue then not much any of us can do when we do not see the issue our selves or have something to go by. You disabling S&L could just be a positive side effect with something in S&L not working well with another addon? idk

I will leave it open for now in case I can reproduce this as I do run torghast atm and dont have any issues in regards to what you are saying... I am even taking my time to make sure I don't just break these with right click since I never do it this way lol.

cant reproduce it either

Strange, I've only got ElvUI and S+L enabled and it causes the spike. When I disable S+L the problem goes away. Appreciate you replying and if I find anything else out I'll let you know

I would backup your wtf folder and such. Then test on a new profile then make sure to do /slerror on which will ensure just ElvUI, ElvUI_OptionsUI and Shadow & Light are the only addons running.