ElvUI WindTools

ElvUI WindTools

3M Downloads

[Bug] Error still exists with adding items to the custom list

Fraktyl opened this issue ยท 2 comments

commented

Describe the bug
If you add items to the custom list after a few both the custom list and the black list throw errors when you open that tab. You are unable to add or remove items once this occurs.

My Custom items were:
["customList"] = {
198610, -- [1] - https://www.wowhead.com/item=198610/enchanters-script
198609, -- [2] - https://www.wowhead.com/item=198609/tailoring-examples
193900, -- [3] - https://www.wowhead.com/item=193900/prismatic-focusing-shard
201709, -- [4] - https://www.wowhead.com/item=201709/notebook-of-crafting-knowledge
},

I tried removing each one from the ELVUI.lua saved variables file, but until I completely cleared all of them out it kept throwing eerors.

To Reproduce
Steps to reproduce the behavior:
Add a few items to the custom list.

Expected behavior
No errors

Screenshots
If applicable, add screenshots to help explain your problem.

Information (you can find these in [WindTools-Information]):

  • Addon Version: 3.13
  • ElvUI Version 13.10
  • WoW Build - Whatever retail is on as of 12/14/2002 @ 1042 EST

Additional context
8x ElvUI_WindTools/Options/Item.lua:120: attempt to concatenate local 'name' (a nil value)
[string "@ElvUI_WindTools/Options/Item.lua"]:120: in function member' [string "@ElvUI_Libraries/Core/Ace3/AceConfig-3.0-3/AceConfigDialog-3.0-86/AceConfigDialog-3.0.lua"]:214: in function <...nfig-3.0/AceConfigDialog-3.0/AceConfigDialog-3.0.lua:163> [string "@ElvUI_Libraries/Core/Ace3/AceConfig-3.0-3/AceConfigDialog-3.0-86/AceConfigDialog-3.0.lua"]:1279: in function <...nfig-3.0/AceConfigDialog-3.0/AceConfigDialog-3.0.lua:1144> [string "@ElvUI_Libraries/Core/Ace3/AceConfig-3.0-3/AceConfigDialog-3.0-86/AceConfigDialog-3.0.lua"]:1745: in function FeedGroup'
[string "@ElvUI_Libraries/Core/Ace3/AceConfig-3.0-3/AceConfigDialog-3.0-86/AceConfigDialog-3.0.lua"]:1670: in function <...nfig-3.0/AceConfigDialog-3.0/AceConfigDialog-3.0.lua:1654>
[string "=[C]"]: ?
[string "@ElvUI_Libraries/Core/Ace3/AceGUI-3.0-41/AceGUI-3.0.lua"]:66: in function <.../ElvUI_Libraries/Core/Ace3/AceGUI-3.0/AceGUI-3.0.lua:64>
[string "@ElvUI_Libraries/Core/Ace3/AceGUI-3.0-41/AceGUI-3.0.lua"]:300: in function Fire' [string "@ElvUI_Libraries/Core/Ace3/AceGUI-3.0-41/widgets/AceGUIContainer-TreeGroup.lua"]:510: in function SetSelected'
[string "@ElvUI_Libraries/Core/Ace3/AceGUI-3.0-41/widgets/AceGUIContainer-TreeGroup.lua"]:185: in function <...ce3/AceGUI-3.0/widgets/AceGUIContainer-TreeGroup.lua:181>

commented

Confirmed.
The reason of that bug is that Blizzard's API of items do not work properly for now, sometimes the item info will get in seconds, but the instant returned item name is nil.

I will add a custom asynchronous logic when I have times. (it may takes some time)

Currently Fix
I modified some code in 3.13-fix-2, and it will be released in hours.
If you met the error of the item id is not valid, just try one more time, it should work.
For blacklist, the name fetching fails now will be override with "Unknown" for a temporarily fix.

commented

Ah, gotta love Blizzards API bugs. Appreciate you looking into it. Having the custom list is a huge QOL thing. Love the addon! Thanks!