Enhanced Mythic Plus Loot

Enhanced Mythic Plus Loot

759 Downloads

Random issues I found & suggestions

KurtzPT opened this issue ยท 14 comments

commented

Latest version when this post was made was used.

So if I open and close multiple times the looking for group (keybind i) window. Multiple windows of EnhancedMythicPlusLoot will appear (they usually stack one above the other). Also the same EnhancedMythicPlusLoot window will not close when I close looking for group window.

Same issue will occur when I have the looking for group window opened and I try to track another item in the EnhancedMythicPlusLoot config. Everytime it will pop-up another window.

Lastly, this window is empty and does not show any of the items I added to the tracking list.

commented

Some suggestions:

  1. The window pop-up will never save the previous size and position I gave to it. It should do that or at least have an option to allow us to define this window settings.
  2. The filtering of the items is always done with "OR". If I choose "crit" and "haste" it will show me either loot with crit or haste. It would be great to have a option where it would be inclusive, so in this case it would show me only gear that contains crit AND haste.
  3. Everytime I login, it will refresh the loot table. This should not be the case, it should do this only the first time and not everytime a character logins.
commented

Found the culprit. The addon is ElvUI Windtools

commented

So I disabled all my addons except ElvUI and it works now. The issues do not appear and the loot that I'm tracking appears. Saving the position/size of the window still does not but I assume that is not yet implemented.

I'll try to figure what addon I have that causes an issue with it. I didn't get any lua errors.

commented

If you find out which addon is causing the issue - please let me know - I will try to fix it :)
Thanks <3

commented

I'm dumb, I had LUA errors disabled. I get this error when the issue appears:

Message: .../ElvUI_Libraries/Core/Ace3/AceGUI-3.0/AceGUI-3.0.lua:356: Action[SetPoint] failed because[SetPoint would result in anchor family connection]: attempted from: Frame:SetPoint.
Time: Sat Jun  8 19:16:14 2024
Count: 1
Stack: .../ElvUI_Libraries/Core/Ace3/AceGUI-3.0/AceGUI-3.0.lua:356: Action[SetPoint] failed because[SetPoint would result in anchor family connection]: attempted from: Frame:SetPoint.
[string "=[C]"]: ?
[string "=[C]"]: in function `SetPoint'
[string "@Interface/AddOns/ElvUI_Libraries/Core/Ace3/AceGUI-3.0/AceGUI-3.0.lua"]:356: in function `SetPoint'
[string "@Interface/AddOns/EnhancedMPlusLoot/lootframe.lua"]:21: in function `CreateLootFrame'
[string "@Interface/AddOns/EnhancedMPlusLoot/lootframe.lua"]:135: in function `ShowLootFrame'
[string "@Interface/AddOns/EnhancedMPlusLoot/lootframe.lua"]:155: in function `?'
[string "@Interface/AddOns/ElvUI_Libraries/Core/Ace3/AceHook-3.0/AceHook-3.0.lua"]:90: in function <...lvUI_Libraries/Core/Ace3/AceHook-3.0/AceHook-3.0.lua:87>
[string "=[C]"]: ?
[string "=[C]"]: ?
[string "=[C]"]: ?
[string "=[C]"]: ?
[string "=[C]"]: in function `Show'
[string "@Interface/AddOns/Blizzard_UIParentPanelManager/Mainline/UIParentPanelManager.lua"]:458: in function `SetUIPanel'
[string "@Interface/AddOns/Blizzard_UIParentPanelManager/Mainline/UIParentPanelManager.lua"]:301: in function `ShowUIPanel'
[string "@Interface/AddOns/Blizzard_UIParentPanelManager/Mainline/UIParentPanelManager.lua"]:165: in function <...ParentPanelManager/Mainline/UIParentPanelManager.lua:161>
[string "=[C]"]: in function `SetAttribute'
[string "@Interface/AddOns/Blizzard_UIParentPanelManager/Mainline/UIParentPanelManager.lua"]:769: in function `ShowUIPanel'
[string "@Interface/AddOns/Blizzard_GroupFinder/Mainline/PVEFrame.lua"]:97: in function `PVEFrame_ShowFrame'
[string "@Interface/AddOns/Blizzard_GroupFinder/Mainline/PVEFrame.lua"]:55: in function <...ce/AddOns/Blizzard_GroupFinder/Mainline/PVEFrame.lua:31>
[string "=[C]"]: in function `PVEFrame_ToggleFrame'
[string "TOGGLEGROUPFINDER"]:1: in function <[string "TOGGLEGROUPFINDER"]:1>

Locals: (*temporary) = <function> defined =[C]:-1
commented

Which version did you use?
0.3.3.1 has those bugs fixxed and all of your requested features.

The instant "Fetch loot - success" without retrying is done from the db, not from the Adventure Journal (WoW API).
I'll change the chat output to better differentiate where the data is coming from.

commented

According to CurseForge I'm using 0.3.3.1. I even re-installed from curseforge and same issues happen.~

EDIT: Just confirmed by opening EnhancedMPlusLoot.toc, version 0.3.3.1

commented

Strange. Any lua errors on wow startup or opening the addon?
I've tested on Live, PTR, and Beta (Live with other addons, PTR & Beta with only this addon) and I can not reproduce the issue.
Which class are you playing? At what level? Maybe I can reproduce the issue with a test character.

commented

I even found out what option in Windtools makes this issue appear. When enabling the following:

image

commented

I think occurs, because I anchor to PVEFrame and something is intercepting the PVEFrame.
I'll just anchor to UIParent and save the position of the loot-tracking frame.
But it will probably take a day or two to test and push the fix.

The main window (not the one on the PVEFrame) should already save size and position.
Does it do that for you (With the drag and drop setting enabled/disabled?)
If not I'll install ElvUI and Windtools on PTR and try to fix that too :)

Thanks for all the investigating :)

commented

When I disable the Move Frames option in Windtools, the MythicPlusLoot tracking window will never remember the position I set to. Example:

I move the window like this:

image

But after closing and opning again, it will go to the default location:

image

Of couse with the Move Frames option turned on in Windtools, the window doesn't work at all it gives that big lua error.

EDIT: Oops I realized you were talking the big window where we can select the loot. Yes that one keeps the position.

commented

Perfect - then I can make the small window do it :)

commented

Pushed a fix, that should solve your ploblem.
Also the small loot tracke window will now be moveable by default and remember it's position.
Let me kmow if everything works as expected in version 0.3.3.3 :)

commented

It's working perfectly now! It even makes the loot search with the "AND" clause. Thanks for the updates!