EskaTracker

EskaTracker

44.7k Downloads

Hide in Dungeons Option

ZachieBlade opened this issue · 14 comments

commented

Is your feature request related to a problem? Please describe.
Have you ever been like me? Have you been in a raid, and had things hide, but then joined a dungeon and found that they just don't?

Describe the solution you'd like
Similar to Hide in Raid, Hide in Combat, I'd like a Hide in Dungeon button.

Describe alternatives you've considered
I currently have it set to Hide in Group, but it's an imperfect band-aid.

commented

On that note, I'd also like to see a battleground option too.

commented
commented

I'll add that.

commented

I have some update.
While i was adding that, i have encountered an issue in the order where the condition will be validated compared of others conditions. I can choose the order but it may be not suitable for some people. So i have decided to improve the options about displaying rules, in giving you the choice in which order the conditions will be checked.

I put below an image on what i plan to do:
ekt_newpredefinedmethod

Take note it's simply a first iteration. There are things which are not in the image such as :

  • Up and Down arrow for controlling the conditions order.
  • A 'Continue' checkbox for each row. If this one is enabled, the next condition will be checked even if the current condition isn't validated.
  • An option asking you in which state (hidden or shown) the tracker is if no condition is validated.

I'll ensure the conditions list can be expanded by plugins and external code.

I have no ETA to give on when things will be finished.

@ZachieBlade and @AussieEevee :
If you want really the conditions now, it can be done with 'Status function' method. I can provide my help at this purpose.

commented

The new options will be included in the next update i plan to deploy tomorrow (Wednesday).

commented

I have finished to create the widgets i need for the options. I put below an image shown the final render:
ekt_final_displayingrules_render

Now, time to link the options to tracker and the database. If i encounter no issue, you should soon to be able test these new options.

commented

They are now available in the 1.0.25.
Just a note about of what does the 'blue circle arrow' (by default, enabled). This indicates to the current row, what should do if the condition isn't validated. If it's toggle on, then the next row will be processed, otherwise all the next ones will be ignored.

commented

I broke it! It only accepted 7, and when I tried to add the 8th, it broke.

2018-08-10 07_04_24-world of warcraft

commented

When I reload the UI, I am able to add the 8th, but at the time, it didn't generate the controls to add it before the reload.

commented

This works fine from my side. It occurs each time ?

commented

It happens to me too. Every time, but when I reach 6 & try to add a 7th.

commented

Very strange, i imagine there is no error displayed ?

I need of your addon configuration. so can you give me the content with a pastebin of this file:

World of Warcraft / WTF / Account / {Account ID} / SavedVariables / EskaTracker.lua

commented

Ok, i have needed to reach at the 20th to see the issue. I also detect some optimization issues, and can be the origin of initial problem. I'll put a first fix in the next build i'll deploy soon. Others are planned but need more works. i'll also certainly review on how are displayed the conditions (e.g, limited on number displayed at same time with a page system is my first thought).

commented

The version i've deployed before the BFA release improve greatly the options. Have you encountered issues since ?