FrameSort

FrameSort

88.4k Downloads

frames periodically become unsorted in arena since 10.1

cixel opened this issue · 14 comments

commented

I'm not sure what causes it, but frames become unsorted during some arena matches. It seems like it happens more often than not, but that could be observation bias. Haven't tried without other addons yet.

Here are my settings:
image

commented

Thanks for the bug report, I will look into it this week.

commented

Awesome, thanks! Let me know if there's any testing you'd like me to do.

commented

Update:

My current guess is that Blizzard are refreshing the party/raid frames during combat and FrameSort can't apply sorting/spacing until combat drops. In a BG this could easily happen if someone joins or leaves the BG during combat, but I'm unsure what event/condition is triggering it during arena as the group wouldn't change.

Trying to figure out if there is a way to prevent Blizzard from refreshing frames during combat (and instead wait until combat drops) which I have attempted but haven't managed to block all avenues.

Still investigating a solution.

commented

I can confirm the same issue.
I'll try to pay attention to the team composition, maybe some pets getting summoned/killed could trigger that but no idea really. Might not help with preventing the refresh but to better pinpoint it out.

Thanks for the great addon!

commented

Just released a new version 4.2.1 with SweepyBoop's suggested fix and will see how it goes.

Update: the in-combat raid frame blocking was causing more problems than it solves, so I've deleted it and released 4.2.2 which seems to be more stable now. I'll have to look further into the in-combat blocking issues before re-implementing the UNIT_PET and GROUP_ROSTER_UPDATE blocks.

@alalama @cixel would you mind giving the latest version 4.2.2 a test and see if there is any improvement?

commented

Recent updates to CompactPartyFrame additionally subscribes to UNIT_PET.
So probably try add this to the combat block logic and see if it fixes the issue

commented

Recent updates to CompactPartyFrame additionally subscribes to UNIT_PET. So probably try add this to the combat block logic and see if it fixes the issue

Thanks for letting me know! I will try this.

commented

Update: confirmed two temporary workarounds for now, you can either:

  • Disable "Display Pets" in the Blizzard raid frame settings (this setting doesn't even seem to work anyway).

or

  • Use the Traditional sorting method instead of Taintless.

Hoping to get Taintless mode stable again but not sure how yet.

commented

I've just released 5.0.0 with some major internal changes that should hopefully resolve many of the issues from 10.1.

I found an absolute gem that allows Taintless mode sorting to work during combat, so even if Blizzard reset frames mid-combat FrameSort can re-apply sorting/spacing. Basically SetPoint() calls are not allowed mid-combat, but AdjustPointsOffset() are allowed, so I've refactored all code to leverage this method.

Would be great if anyone could test and see how it goes.

commented

Sorry for the lack of movement here, I haven't been able to play much this weekend. I really appreciate the hard work you've put into figuring this out. I'll aim to test it a bit either today or tomorrow when I get a chance to PvP.

commented

All good! No stress if you're unavailable/busy.

commented

Tried it out in a solo shuffle and some 2s.

Had no issues, even with hunters on my team and pet frames enabled. Mind control also doesn't seem to cause problems. Glad you found a solution you're happy with that seems to work. I'll let you decide if this is enough confirmation to close out the issue.

Thanks for a super useful addon!

commented

That's great news.

I've just tested it out in some 3s and it seems very solid now.

I'll wait a few days for any other news/feedback from the community and then close this off.

commented

Seems to be fixed now, closing issue.